From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-f46.google.com (mail-it0-f46.google.com [209.85.214.46]) by dpdk.org (Postfix) with ESMTP id 702102C12 for ; Tue, 11 Oct 2016 03:23:05 +0200 (CEST) Received: by mail-it0-f46.google.com with SMTP id k64so15804976itb.0 for ; Mon, 10 Oct 2016 18:23:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=YyF2MRrD26ob8TGFq4bJ/NNaf3K7PIomgy2fS8tBCNY=; b=NtpD38vh2eiLe+3tvq8gRI7EnWU+0an4zKtOTD9Qahy3yKEXjtNmi1TZc2waTKBp7y CfB1lbpeMr2xmhh590yYomPxlUz6N3x9jb0BXpnD3OQvuoWV3duRZphGmHJHghZYbCif kcWgZxE80/c7YYWz9wo2txJM8e27zf4QAXvkg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=YyF2MRrD26ob8TGFq4bJ/NNaf3K7PIomgy2fS8tBCNY=; b=aomGVUQnPQyog8Dq1TLN4rU4UaNbCtM+Pi4T1b6tSllIIQJcZ8QQNninT4BQN2/fxO jNq10iC0bY1C0SoDLpWPEM2awtH93fmXOG4x5DeRIWFervTH+suhD7hJYdfRFWy/Uyge Mn+Zyubzrmo6CEE6Cb7o457gOTCeHk2bCbA272uddP2gzQPt2NbGrphPJI2FmWgwTN6M bAuxHwrt3cWpZMLmh1l287++nGkGCMDYWw4N/wbRXqTfDUWsfOTViRGC1cvQ0lTbRA4n CMQOzKGA0WB8Ku7yA9rflMTf64Qtj9jGQY2KwNdgNyKv35jenrgTzFs8cWE+s9uTbZem WKvQ== X-Gm-Message-State: AA6/9RkfjQyZnrveltxY3sfp8wjsjvph2RD9hn7emMqrbPZVHs5G12E5OJBVD37rEG9SkW6Lgj6pQuKEj1R4HGEs X-Received: by 10.36.61.141 with SMTP id n135mr14135392itn.88.1476148984603; Mon, 10 Oct 2016 18:23:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.225.40 with HTTP; Mon, 10 Oct 2016 18:22:24 -0700 (PDT) In-Reply-To: <30145fbb-2d02-de2d-e4b4-d1317645e2db@intel.com> References: <20160929170356.GA52225@C02PT1RBG8WP.aus.broadcom.com> <30145fbb-2d02-de2d-e4b4-d1317645e2db@intel.com> From: Ajit Khaparde Date: Mon, 10 Oct 2016 20:22:24 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 3/4] bnxt: Add support for Async Link Notification X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 01:23:05 -0000 On Mon, Oct 10, 2016 at 10:40 AM, Ferruh Yigit wrote: > Hi Ajit, > > On 9/29/2016 6:03 PM, Ajit Khaparde wrote: > > This patch adds support to get Link notification asynchronously. > > The HW sends Async notifications on default completion ring. The > > PMD processes these notifications and logs a message appropriately. > > > > Signed-off-by: Ajit Khaparde > > --- > > drivers/net/bnxt/Makefile | 1 + > > drivers/net/bnxt/bnxt.h | 6 +- > > drivers/net/bnxt/bnxt_cpr.c | 21 +++--- > > drivers/net/bnxt/bnxt_ethdev.c | 114 ++++++++++++++++++++++++++---- > > drivers/net/bnxt/bnxt_hwrm.c | 93 ++++++++++++------------ > > drivers/net/bnxt/bnxt_irq.c | 156 ++++++++++++++++++++++++++++++ > +++++++++++ > > drivers/net/bnxt/bnxt_irq.h | 51 ++++++++++++++ > > 7 files changed, 367 insertions(+), 75 deletions(-) > > create mode 100644 drivers/net/bnxt/bnxt_irq.c > > create mode 100644 drivers/net/bnxt/bnxt_irq.h > > > > <...> > > > +static inline int > > +rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev, > > + struct rte_eth_link *link) > > +{ > > + struct rte_eth_link *dst =3D link; > > + struct rte_eth_link *src =3D ð_dev->data->dev_link; > > + > > + if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst, > > + *(uint64_t *)src) =3D=3D 0) > > + return 1; > > + > > + return 0; > > +} > > + > > This creates a compilation error: > .../drivers/net/bnxt/bnxt_ethdev.c:444:1: > error: unused function 'rte_bnxt_atomic_read_link_status' > [-Werror,-Wunused-function] > rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev, > ^ > > Since the patches in this patchet really not related, it is OK to send a > =E2=80=8B=E2=80=8B > new version of just this patch. > =E2=80=8BSure. Let me respin it. Thanks =E2=80=8B > > Thanks, > ferruh > >