From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9898FA034E; Thu, 7 May 2020 00:14:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3075D1DB54; Thu, 7 May 2020 00:14:49 +0200 (CEST) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id 361E31DB2C for ; Thu, 7 May 2020 00:14:47 +0200 (CEST) Received: by mail-ot1-f67.google.com with SMTP id j4so2759905otr.11 for ; Wed, 06 May 2020 15:14:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6btXSSbWRPJjJl1G+b9UZVYNeJWV4R/aBeSSBq/2P/Q=; b=WswMFojHIOhMKL+9t79weU709DgCaFX1DPR5YzTJtxQEDsyIKyOoDK7dkj1TsfsVNi yWdm2xPITurEXBu2b4P8hvzNiJgK4ZywSmGTdfXwzucvTR1DBjEPETWKxKv48keNoMYW T8EHS//h6yeCabu1wYxIXE39tqgHRfhOWatk8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6btXSSbWRPJjJl1G+b9UZVYNeJWV4R/aBeSSBq/2P/Q=; b=I08ZNftZqqlf6ZLLpFWnvYpKIHxp8qpgrbIE1FhC3zszpxiAnfL9Q4aa6BngTPamgM Z9MkBA2YK7yLLq0Brgo4gHPDWf9+W++b0Dh/Ab/XguUOt2fGu+0Gv5bxfBJU4MMiGpSH sJ5J0M4tLYBR2SDwo8uHbs/IocqzBDqpi7ZKPx+topIlJbmTxVApwrFI+qtww5HwyUDr 2umVTFKXo6wMan1DgQfhfykxKV8yBs4cTFrXtA1r08bRo9u154s6qEBdCabbiPZKAlkB ++j+zaXwT4YBawQlrdlU9zeQGNJRxv2GeGNBuWZ6KFFamy/Bu4zHmpgL3AnAJxQDfk7U TpPg== X-Gm-Message-State: AGi0PuYFZ6LM1rDhtD7Hj27QxhYGa69foj2B1J3G+HNLRhD/sCC2KZyX fSNSUgr0tHxjKdOGs7z0uNG+JPtp0nHRX+46nBIAQA== X-Google-Smtp-Source: APiQypJlCU53IQAotroG50uK6mPEttLZ890jJ9Ox0MclhkN4avMXtqRgDsOFc6j3+L7pKfn+AQM8BKe0jSNOUkhV22E= X-Received: by 2002:a05:6830:1613:: with SMTP id g19mr7342489otr.95.1588803286148; Wed, 06 May 2020 15:14:46 -0700 (PDT) MIME-Version: 1.0 References: <20200505191738.58219-1-ajit.khaparde@broadcom.com> <20200505191738.58219-2-ajit.khaparde@broadcom.com> <6d0bac2f-7295-3f2a-9100-447ce60e45dc@intel.com> In-Reply-To: <6d0bac2f-7295-3f2a-9100-447ce60e45dc@intel.com> From: Ajit Khaparde Date: Wed, 6 May 2020 15:14:29 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Kishore Padmanabha , Michael Baucom Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix overrun of the ulp device params array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 2:17 AM Ferruh Yigit wrote: > On 5/5/2020 8:17 PM, Ajit Khaparde wrote: > > From: Kishore Padmanabha > > > > Fix a buffer overrun issue spotted by coverity while accessing > > the array ulp_device_params. > > If it is spotted by coverity, is there a coverity issue id? > Yes. But in an internal scan. I haven't seen anything reported in this area in the latest coverity report against 20.05-rc1. > > > > Fixes: 313ac35ac701 ("net/bnxt: support ULP session manager init") > > > > Signed-off-by: Kishore Padmanabha > > Reviewed-by: Michael Baucom > > Reviewed-by: Ajit Khaparde > > --- > > drivers/net/bnxt/tf_ulp/ulp_template_db.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_template_db.c > b/drivers/net/bnxt/tf_ulp/ulp_template_db.c > > index 86384169f..e89aefad4 100644 > > --- a/drivers/net/bnxt/tf_ulp/ulp_template_db.c > > +++ b/drivers/net/bnxt/tf_ulp/ulp_template_db.c > > @@ -321,7 +321,7 @@ struct bnxt_ulp_def_ident_info ulp_def_ident_tbl[] = > { > > } > > }; > > > > -struct bnxt_ulp_device_params ulp_device_params[] = { > > +struct bnxt_ulp_device_params > ulp_device_params[BNXT_ULP_DEVICE_ID_LAST] = { > > [BNXT_ULP_DEVICE_ID_WH_PLUS] = { > > .global_fid_enable = BNXT_ULP_SYM_YES, > > .byte_order = (enum bnxt_ulp_byte_order) > > > >