From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Ori Kam <orika@nvidia.com>
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
Andrey Vesnovaty <andreyv@nvidia.com>,
NBU-Contact-Thomas Monjalon <thomas@monjalon.net>,
Slava Ovsiienko <viacheslavo@nvidia.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
dpdk-dev <dev@dpdk.org>, "jer@marvell.com" <jer@marvell.com>,
Jerin Jacob <jerinjacobk@gmail.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Ori Kam <orika@mellanox.com>,
Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
"andrey.vesnovaty@gmail.com" <andrey.vesnovaty@gmail.com>,
Ray Kinsella <mdr@ashroe.eu>,
Neil Horman <nhorman@tuxdriver.com>,
Thomas Monjalon <tmonjalon@nvidia.com>,
Samik Gupta <samik.gupta@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API
Date: Thu, 24 Sep 2020 12:25:11 -0700 [thread overview]
Message-ID: <CACZ4nhtQob5_pu129GFCORe=kxTV9NRKYZfRN4x7j2w-SLaWGw@mail.gmail.com> (raw)
In-Reply-To: <MN2PR12MB4286DBE84D53C62BA5E8D87AD63E0@MN2PR12MB4286.namprd12.prod.outlook.com>
On Thu, Sep 17, 2020 at 9:03 AM Ori Kam <orika@nvidia.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Andrew Rybchenko <arybchenko@solarflare.com>
> > Sent: Thursday, September 17, 2020 6:34 PM
> > <samik.gupta@broadcom.com>
> > Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API
> >
> > On 9/16/20 10:20 PM, Ajit Khaparde wrote:
> > > On Wed, Sep 16, 2020 at 8:52 AM Andrey Vesnovaty <andreyv@nvidia.com>
> > wrote:
> > >>
> > >> Hi Ajit
> > >>
> > >> For shared action configuration I have following suggestion:
> > >>
> > >> struct rte_flow_shared_action_conf {
> > >> uint32_t no_ingress: 1;
> > >> uint32_t no_egress: 1;
> > >> };
> > >> /*...*/
> > >> rte_flow_shared_action_create(..., const struct
> > rte_flow_shared_action_conf *conf, ...);
> > >>
> > >> What do you think?
> > > Andrey, I think this is good.
> > > Application can specify the direction and PMD can decide whether if
> > > it needs to honor it or ignore it.
> > > Please send the updated version of the patch.
> >
> > Personally I dislike negative flags, offloads, fields etc.
> > Don't we have a policy to avoid it. At least we have it for
> > offloads. I see no string reasons here to use negative
> > instead of positive here.
>
> Agree I think it is better to use positive values and the same names as the
> attribute in the flow.
Has a new version of the patch been submitted? Thanks
>
next prev parent reply other threads:[~2020-09-24 19:25 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 12:05 [dpdk-dev] [PATCH] " Andrey Vesnovaty
2020-07-03 15:02 ` Jerin Jacob
2020-07-03 15:21 ` Thomas Monjalon
2020-07-04 9:54 ` Andrey Vesnovaty
2020-07-04 10:10 ` Andrey Vesnovaty
2020-07-04 12:33 ` Jerin Jacob
2020-07-05 10:26 ` Ori Kam
2020-07-06 9:00 ` Jerin Jacob
2020-07-06 12:28 ` Ori Kam
2020-07-06 13:32 ` Andrey Vesnovaty
2020-07-07 2:30 ` Jerin Jacob
2020-07-07 6:21 ` Ori Kam
2020-07-07 15:21 ` Ferruh Yigit
2020-07-07 17:24 ` Ori Kam
2020-07-07 17:52 ` Ferruh Yigit
2020-07-07 19:38 ` Jerin Jacob
2020-07-07 21:03 ` Ori Kam
2020-07-08 9:25 ` Jerin Jacob
2020-07-08 9:47 ` Ori Kam
2020-07-08 11:00 ` Jerin Jacob
2020-07-08 11:50 ` Thomas Monjalon
2020-07-08 12:18 ` Ori Kam
[not found] ` <20200708204015.24429-2-andreyv@mellanox.com>
2020-07-13 8:04 ` [dpdk-dev] [PATCH v2 1/6] ethdev: " Kinsella, Ray
2020-07-13 10:16 ` Andrew Rybchenko
2020-07-15 8:54 ` Andrew Rybchenko
2020-07-15 9:00 ` Andrew Rybchenko
2020-09-15 11:30 ` Andrey Vesnovaty
[not found] ` <20200708204015.24429-3-andreyv@mellanox.com>
2020-07-13 8:06 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Kinsella, Ray
2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Andrey Vesnovaty
2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API Andrey Vesnovaty
2020-09-12 2:18 ` Ajit Khaparde
2020-09-15 11:50 ` Andrey Vesnovaty
2020-09-15 15:49 ` Ajit Khaparde
2020-09-16 15:52 ` Andrey Vesnovaty
2020-09-16 19:20 ` Ajit Khaparde
2020-09-17 15:33 ` Andrew Rybchenko
2020-09-17 16:02 ` Ori Kam
2020-09-24 19:25 ` Ajit Khaparde [this message]
2020-09-26 11:09 ` Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 00/10] RTE flow shared action Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 01/10] ethdev: add flow shared action API Andrey Vesnovaty
2020-10-04 11:10 ` Ori Kam
2020-10-06 10:22 ` Andrey Vesnovaty
2020-10-04 17:00 ` Stephen Hemminger
2020-10-04 17:01 ` Stephen Hemminger
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 02/10] ethdev: add conf arg to shared action icreate API Andrey Vesnovaty
2020-10-04 11:11 ` Ori Kam
2020-10-06 10:28 ` Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 03/10] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 04/10] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 05/10] net/mlx5: shared action PMD Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 06/10] net/mlx5: shared action PMD create conf arg Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 07/10] net/mlx5: driver support for shared action Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 08/10] net/mlx5: shared action create conf drv support Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 09/10] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty
2020-10-04 11:21 ` Ori Kam
2020-10-06 10:34 ` Andrey Vesnovaty
2020-10-03 22:06 ` [dpdk-dev] [PATCH v3 10/10] app/testpmd: support shared action Andrey Vesnovaty
2020-10-04 11:28 ` Ori Kam
2020-10-04 12:04 ` Ori Kam
2020-10-06 10:36 ` Andrey Vesnovaty
2020-10-04 11:14 ` [dpdk-dev] [PATCH v3 00/10] RTE flow " Ori Kam
2020-10-06 10:28 ` Andrey Vesnovaty
2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 2/6] common/mlx5: modify advanced Rx object via DevX Andrey Vesnovaty
2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 3/6] net/mlx5: modify hash Rx queue objects Andrey Vesnovaty
2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 4/6] net/mlx5: shared action PMD Andrey Vesnovaty
2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 5/6] net/mlx5: driver support for shared action Andrey Vesnovaty
2020-07-08 21:39 ` [dpdk-dev] [PATCH v2 6/6] examples/flow_filtering: utilize shared RSS action Andrey Vesnovaty
2020-07-09 4:44 ` Jerin Jacob
2020-07-09 6:08 ` Ori Kam
2020-07-09 12:25 ` Andrey Vesnovaty
2020-07-09 12:39 ` Thomas Monjalon
2020-07-09 4:39 ` [dpdk-dev] [PATCH v2 0/6] add flow shared action API + PMD Jerin Jacob
2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 0/2] RTE flow shared action Andrey Vesnovaty
2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add flow shared action API Andrey Vesnovaty
2020-10-07 6:27 ` Ori Kam
2020-10-06 20:08 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: support shared action Andrey Vesnovaty
2020-10-07 6:30 ` Ori Kam
2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 0/2] RTE flow " Andrey Vesnovaty
2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add flow shared action API Andrey Vesnovaty
2020-10-07 13:01 ` Ori Kam
2020-10-07 21:23 ` Ajit Khaparde
2020-10-08 7:28 ` Andrey Vesnovaty
2020-10-07 12:56 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: support shared action Andrey Vesnovaty
2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 0/2] RTE flow " Andrey Vesnovaty
2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add flow shared action API Andrey Vesnovaty
2020-10-07 18:36 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: support shared action Andrey Vesnovaty
2020-10-07 20:01 ` Ajit Khaparde
2020-10-08 10:58 ` Andrey Vesnovaty
2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 0/2] RTE flow " Andrey Vesnovaty
2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add flow shared action API Andrey Vesnovaty
2020-10-08 22:30 ` Ajit Khaparde
2020-10-14 11:47 ` Andrey Vesnovaty
2020-10-12 14:19 ` Andrew Rybchenko
2020-10-13 20:06 ` Andrey Vesnovaty
2020-10-14 6:49 ` Andrew Rybchenko
2020-10-14 7:22 ` Thomas Monjalon
2020-10-14 11:43 ` Andrey Vesnovaty
2020-10-14 11:42 ` Andrey Vesnovaty
2020-10-08 11:51 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: support shared action Andrey Vesnovaty
2020-10-08 23:54 ` Ajit Khaparde
2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 0/2] RTE flow " Andrey Vesnovaty
2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add shared actions to flow API Andrey Vesnovaty
2020-10-14 11:44 ` Andrew Rybchenko
2020-10-14 16:17 ` Ferruh Yigit
2020-10-14 11:40 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: support shared action Andrey Vesnovaty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhtQob5_pu129GFCORe=kxTV9NRKYZfRN4x7j2w-SLaWGw@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=andrey.vesnovaty@gmail.com \
--cc=andreyv@nvidia.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jer@marvell.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=mdr@ashroe.eu \
--cc=nhorman@tuxdriver.com \
--cc=orika@mellanox.com \
--cc=orika@nvidia.com \
--cc=samik.gupta@broadcom.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=tmonjalon@nvidia.com \
--cc=viacheslavo@mellanox.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).