From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75634A0547; Tue, 20 Apr 2021 07:32:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5BB254159C; Tue, 20 Apr 2021 07:32:13 +0200 (CEST) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by mails.dpdk.org (Postfix) with ESMTP id AE36641598 for ; Tue, 20 Apr 2021 07:32:12 +0200 (CEST) Received: by mail-qk1-f175.google.com with SMTP id t17so9802498qkg.4 for ; Mon, 19 Apr 2021 22:32:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=1ApG48H3etyF8HwKcAtR4/Iqhi4xtp/bKMNL5nwtyg8=; b=H/+DLsvfAQKYbDqEoyuXD6Ssy1mpnmd5I/JM83jiwoL3e0/Uig4fhb7jmOQwIqVxKG zh6x3SsJfIYffk5FEfvQW3zXXQxIw5Yjgf6QJkqEXaDH5b7g4/JarewIzO2e3vly8LJA SZAqpQJJnnWAYKNSIIFrEqWpiYdxWuJzjltQc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=1ApG48H3etyF8HwKcAtR4/Iqhi4xtp/bKMNL5nwtyg8=; b=SQ5RABXOK+xbK9vxmi29ELfL7NjMTWF4A2O2dZKkSoyH3uwisqqf4NxxoA8gw3gaA+ mUlulBwRj/qtHt+Dpj2HE37i51E2PjdWdmjfl7SybiCYxzwalyOv243tFovhD5g3hsUQ L3H9uuaeT3Vt2d3Ta2ZsKGU2hXI+u9tnI1M6jkDJn+/LYB3fOM4o+fRdKeYvdR5jFAxj Pu2Y0gtfpFTqxfWcNxokM3uamOcd12pZoi7k5GmcWEdU6oGM2HVzVj7cYgZ5DGv3IrlZ 53RXtiPtxTsb2q5rNkMBHOmNB53OzWF/N5dFRi4shBNZGGklogAJ2mEAZ5xeyydLPggt NX5w== X-Gm-Message-State: AOAM532b5463eNzWtziELgHTa6KpT6u2A2qN6lAr7fYFy0YQodb3OYXm XjRSOb7OX8SQlT9UvlDS14tGzTd9ZCzxMPD9u3WlBA== X-Google-Smtp-Source: ABdhPJyfr9Plgc3tDsyWEIQlV7H0vnQVpFQYwJJ3cUtJt9NZZcLgQJhjpBi2n9oDT9ApogLONeoGkr4LWBzAt/5fx8k= X-Received: by 2002:a05:620a:6ce:: with SMTP id 14mr15727176qky.423.1618896732049; Mon, 19 Apr 2021 22:32:12 -0700 (PDT) MIME-Version: 1.0 References: <20210420040845.28725-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210420040845.28725-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Mon, 19 Apr 2021 22:31:55 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000a92a4405c060c40b" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix cancelling health check alarm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000a92a4405c060c40b Content-Type: text/plain; charset="UTF-8" On Mon, Apr 19, 2021 at 8:46 PM Kalesh A P wrote: > > From: Kalesh AP > > Driver cancels the health check alarm only if error recovery is enabled > in the FW. This can cause an issue. There is a small window where the > driver receives the async event from fw and port close is invoked > immediately. Driver clears BNXT_FLAG_RECOVERY_ENABLED flag when it gets > the async event from FW. As a result, the health check alarm will not > get canceled during port close and causes a segfault when the alarm tries > to read Heartbeat register. > > Fix this by cancelling the health check alarm unconditionally during > port stop. > > Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Kumar Khaparde Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 9da817f..f5d2dc8 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4274,9 +4274,6 @@ void bnxt_schedule_fw_health_check(struct bnxt *bp) > > static void bnxt_cancel_fw_health_check(struct bnxt *bp) > { > - if (!bnxt_is_recovery_enabled(bp)) > - return; > - > rte_eal_alarm_cancel(bnxt_check_fw_health, (void *)bp); > bp->flags &= ~BNXT_FLAG_FW_HEALTH_CHECK_SCHEDULED; > } > -- > 2.10.1 > --000000000000a92a4405c060c40b--