From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2E46FA0C48;
	Wed,  7 Jul 2021 00:58:48 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 18C2B406FF;
	Wed,  7 Jul 2021 00:58:48 +0200 (CEST)
Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com
 [209.85.160.181])
 by mails.dpdk.org (Postfix) with ESMTP id 3FE4F4003C
 for <dev@dpdk.org>; Wed,  7 Jul 2021 00:58:47 +0200 (CEST)
Received: by mail-qt1-f181.google.com with SMTP id y9so655261qtx.9
 for <dev@dpdk.org>; Tue, 06 Jul 2021 15:58:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=j705acyfZ+kqzQP7xgyIt9+J/7/vGF5IzSUVob4FOeA=;
 b=c7VaM0iYgWeIWl+VWycIBitifrged4Z9E2SDd+4pk2BW+43Qqjdxr2WtTXnW0WgYut
 AA4LVCySMwtIoOs1q9NSeEF3bca2CnEi0V0k1PirFu6GBWgrNiQ8MVCVkjZm6xhWTbhM
 WjxMTFQC5nqNJJ0MSoHiTb8aNsHSyIqxmvMn8=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=j705acyfZ+kqzQP7xgyIt9+J/7/vGF5IzSUVob4FOeA=;
 b=aHtCSWDjeWfmH+qk7Xor3Mwuf9sB1mWAp0+OAALJ/S5iI20XrtASuoNzxdCBuggFb+
 P/bDDo4KgGKbz4ytzc2eK2JOYqZOMgbGFYX9Y8Z48bfLH5gRYrOGjuABGCswCiZIpAtm
 VLRQjeXT9rj+nntCF1kCNdjtQFgfxdNDY2JRLwG4OP5alkEU41HTI4i72AYuowb55/Xu
 HLxf2eVHk8YiX9vzWIrB1Vcs/hS0lRat37BqCKBYNwfxxiA55AvoU+9Xy7avdhwGHb7F
 UREBmjzorv8CAE6+Yusrn7rbrIcq0Y1E+TiFhr68APJS1BY7+L5sonvZxloahodv1sCS
 ca6w==
X-Gm-Message-State: AOAM530dXmLG3gHgsLpkm4mCZATTPO9pFUqTZJTb7T2Idg6sFDH4YqOC
 c5fUSbJ6a86wm4IZQC3BheznTDJ90XheFE2KBSmClg==
X-Google-Smtp-Source: ABdhPJwfVqiGJ/c44AbUW2qvYf8Vk6LUoVIZM5t16Olg4uArQYA0droFNGFAweTltKARBzfm0CIUS+MiHl7K/KsPgDo=
X-Received: by 2002:ac8:5048:: with SMTP id h8mr15476544qtm.194.1625612326616; 
 Tue, 06 Jul 2021 15:58:46 -0700 (PDT)
MIME-Version: 1.0
References: <20210530085929.29695-1-venkatkumar.duvvuru@broadcom.com>
 <20210613000652.28191-1-ajit.khaparde@broadcom.com>
 <20210613000652.28191-9-ajit.khaparde@broadcom.com>
 <4117236.U6UGKAdq3r@thomas>
In-Reply-To: <4117236.U6UGKAdq3r@thomas>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Tue, 6 Jul 2021 15:58:30 -0700
Message-ID: <CACZ4nhtXYPskuhiVm6R3k4KvVTinX1HyuWt0mu_Aw0c833CpmQ@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Farah Smith <farah.smith@broadcom.com>, dpdk-dev <dev@dpdk.org>, 
 Randy Schacher <stuart.schacher@broadcom.com>, 
 Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>, 
 Peter Spreadborough <peter.spreadborough@broadcom.com>
Content-Type: multipart/signed; protocol="application/pkcs7-signature";
 micalg=sha-256; boundary="00000000000049ca7e05c67c5d3b"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH v2 08/58] net/bnxt: add action SRAM
 translation
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

--00000000000049ca7e05c67c5d3b
Content-Type: text/plain; charset="UTF-8"

On Mon, Jul 5, 2021 at 2:24 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> 13/06/2021 02:06, Ajit Khaparde:
> > From: Farah Smith <farah.smith@broadcom.com>
> >
> > - Translate Truflow action types for Thor to HCAPI RM
> >   resource defined SRAM banks.
> > - move module type enum definitions to tf_core API
> > - Switch to subtype concept for RM.
> > - alloc/free working for Thor SRAM table type for full AR.
> >
> > Signed-off-by: Farah Smith <farah.smith@broadcom.com>
> > Signed-off-by: Randy Schacher <stuart.schacher@broadcom.com>
> > Signed-off-by: Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>
> > Reviewed-by: Peter Spreadborough <peter.spreadborough@broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> [...]
>
> I see 2 issues in the beginning of this patch:
>
> > --- a/drivers/net/bnxt/hcapi/cfa/hcapi_cfa.h
> > +++ b/drivers/net/bnxt/hcapi/cfa/hcapi_cfa.h
> > @@ -1,281 +1,126 @@
> > -/* SPDX-License-Identifier: BSD-3-Clause
> > - * Copyright(c) 2019-2021 Broadcom
> > - * All rights reserved.
> > +/*
> > + *   Copyright(c) Broadcom Limited.
> > + *   All rights reserved.
> >   */
>
> SPDX copyright is removed.
>
> >
> > +/*!
> > + *   \file
> > + *   \brief Exported functions for CFA HW programming
> > + */
> >  #ifndef _HCAPI_CFA_H_
> >  #define _HCAPI_CFA_H_
> >
> >  #include <stdio.h>
> > +#include <stddef.h>
> >  #include <string.h>
> >  #include <stdbool.h>
> >  #include <stdint.h>
> >  #include <stddef.h>
> > +#include <errno.h>
>
> stddef.h is included twice.
>
> Please fix in next-net-brcm, thanks.
>
Done.
Updated patch merged in dpdk-next-net-brcm. Thanks

--00000000000049ca7e05c67c5d3b--