From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92C9BA2EFC for ; Tue, 17 Sep 2019 03:56:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 226041BEC0; Tue, 17 Sep 2019 03:56:04 +0200 (CEST) Received: from mail-oi1-f195.google.com (mail-oi1-f195.google.com [209.85.167.195]) by dpdk.org (Postfix) with ESMTP id 20F731BEBC for ; Tue, 17 Sep 2019 03:56:03 +0200 (CEST) Received: by mail-oi1-f195.google.com with SMTP id w6so1437659oie.11 for ; Mon, 16 Sep 2019 18:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VPAyFUu3E/YcsYWIWfnCGBqZegTQ+gBq+3zIu2GxOwU=; b=DoEAoXz6np0qDN+fgbZ72Hurl/oKYy7zv6XxQeRpvcSK1TsdV5TJEY8sZz72Z2pSgM +UuEaFev14V/PUHjmvHTXTaBLb4W67NrloKLPD+XkTlKG7kUfn8A56EBh7H4tYHNxjA2 6pu3qsbQDGrP0kWzb19cTLhnD+wLpSl2FVSxU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VPAyFUu3E/YcsYWIWfnCGBqZegTQ+gBq+3zIu2GxOwU=; b=KvK5xmkgl9URRvIdfSYp0cDKxi4jlGQ2iOE4z25hDfZ5V5H2G3i3l6ExAqkF9zD6MR w9bEAc82Zm199l2HSmkBgt7pCBA2+5+pW5x7HJd9oPhKU+l13fmDP9p1y8/aGN35CwZV DA10oxMplFBzgVGh7F6hncOkhThZ2fB+AXob2k0QKkJ+vCvwv/yGKceWBo6UfR5PHrjB Cb7MSKcSduc0+1FoBiosGmTtGT6b2Wcy3TkuFA2r5pt/HedQFT7+UYCBbxj9A1G6bH0v ga9LJO08lCpi+BbWIwVM6kyTtLxR9dMxnOwHt2Gs3BTalk6uHOwOAoLqONIdLeia6EM6 WXBg== X-Gm-Message-State: APjAAAWo9d8hYOzU5o8mCWcZgHYqIyHLLfZIajKNgMzKGxI4GfVGIHX6 0n5CnRCTzPa0i3aZHzow0M+fFJDJQaAqeZAwb2pu8A== X-Google-Smtp-Source: APXvYqyN7U68WxwOMGE+jBaVZB90HXvggahu4lgBFJofX+IgkBJdbxRZZpw/CSUW7FiE4p/lipMPg0Q/TBKR63M1ggM= X-Received: by 2002:aca:b654:: with SMTP id g81mr1752127oif.153.1568685361950; Mon, 16 Sep 2019 18:56:01 -0700 (PDT) MIME-Version: 1.0 References: <1567751873-15964-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-6-git-send-email-gavin.hu@arm.com> In-Reply-To: <1568633238-47888-6-git-send-email-gavin.hu@arm.com> From: Ajit Khaparde Date: Mon, 16 Sep 2019 18:55:45 -0700 Message-ID: To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, Thomas Monjalon , Bruce Richardson , yong.liu@intel.com, yinan.wang@intel.com, Somnath Kotur , Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com, steve.capper@arm.com, dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 5/5] net/bnxt: enforce io barrier for doorbell command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 16, 2019 at 4:27 AM Gavin Hu wrote: > The doorbell ringing operation requires a rte_io_mb immediately to make > the command complete and visible to the device before reading the > response, otherwise it may read stale or invalid responses. > > Fixes: ca241d9a0952 ("net/bnxt: use I/O device memory read/write API") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 2d5dc00..7d192e3 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -134,6 +134,12 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, > void *msg, > /* Ring channel doorbell */ > bar = (uint8_t *)bp->bar0 + mb_trigger_offset; > rte_write32(1, bar); > + /* > + * Make sure the channel doorbell ring command complete before > + * reading the response to avoid getting stale or invalid > + * responses. > + */ > + rte_io_mb(); > > /* Poll for the valid bit */ > for (i = 0; i < HWRM_CMD_TIMEOUT; i++) { > -- > 2.7.4 > >