From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE460A04C3; Mon, 28 Sep 2020 16:58:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 404E21D8F1; Mon, 28 Sep 2020 16:58:19 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id B17161D8F0 for ; Mon, 28 Sep 2020 16:58:16 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id 26so1619945ois.5 for ; Mon, 28 Sep 2020 07:58:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gLD1yBIvBqYTSSLVTTgaIW1gBSWHXvTyaIcNmj2BN4A=; b=KIRRHQPQE1etDCTV7og3Fk7C4yWigENJFAOBtchLHxbKJTML2rLXHfu8jQrW5FJRYg Gk8P8uO7Lsd65IC90rQ0d/fGknfoWeNQKbgAUMqA8TL+qLwK9G0TOJevSKXU7BaDyeFG C17PkrjaN34HI6mtA7UCw13tO91rfXB1m5X9w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gLD1yBIvBqYTSSLVTTgaIW1gBSWHXvTyaIcNmj2BN4A=; b=Y36tK6KsQ1/jyzDOlbd+o5u6VIy76Cmwyph5NFSGPTOtcZ389q7QbKekCluXAfHJq4 sVl55F+FaY0VqUUK1NH/+WtNtKTPfcfVvmPYBXkIBeKuyTsd8JN2Qy7Lrq1PsfFEJTwH ClV/L9gWnepL0GJbyl5dM1Ix6tIHMPBfOYGgJXj0g4rFD7fdNNtdfFPCTV/GXrCq7yZN KVRhh/DUOTORvL6Zt4ooikBxWyHVZhg5cc69sCcF3XrFn5eMSOWuJ07XtAZO3MdwCTZ6 UpKqf0DctWgL9LJMOKp0Sk1sKyIMAcbjRi3jVrNjE8tAh6iF34o3vABP3YHmIBsR8lOv AM2w== X-Gm-Message-State: AOAM531Alz/XS8C7lAFKx2gmZXugJxCfU0ToqHwcXZ42TLC799I9LRH6 JrTrOZPbQM5zoi8ZY0KQZvX/xqmuTHwQicEmjcP1hA== X-Google-Smtp-Source: ABdhPJxNxf6pTrDuQviHEIn5zfRg6FDXNqDq8jaXGy0n1znzWnCdyZxErju1JngbkYg5mkyLZKyfZzXCkAygTKDSkww= X-Received: by 2002:aca:4904:: with SMTP id w4mr1136278oia.179.1601305095498; Mon, 28 Sep 2020 07:58:15 -0700 (PDT) MIME-Version: 1.0 References: <20200913220711.3768597-1-thomas@monjalon.net> <20200927234249.3198780-1-thomas@monjalon.net> <20200927234249.3198780-20-thomas@monjalon.net> <156fdbd3-d673-92ab-5a72-b19564170cdb@oss.nxp.com> In-Reply-To: <156fdbd3-d673-92ab-5a72-b19564170cdb@oss.nxp.com> From: Ajit Khaparde Date: Mon, 28 Sep 2020 07:57:59 -0700 Message-ID: To: "Sachin Saxena (OSS)" Cc: Thomas Monjalon , dpdk-dev , Ferruh Yigit , Andrew Rybchenko , Ciara Loftus , Qi Zhang , Shepard Siegel , Ed Czeck , John Miller , Steven Webster , Matt Peters , Somnath Kotur , Rahul Lakkireddy , Hemant Agrawal , Jeff Guo , Haiyue Wang , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , Gagandeep Singh , John Daley , Hyong Youb Kim , Xiao Wang , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Beilei Xing , Jingjing Wu , Qiming Yang , Alfredo Cardigliano , Rosen Xu , Shijith Thotton , Srisivasubramanian Srinivasan , Matan Azrad , Shahaf Shuler , Zyta Szpak , Liron Himi , Stephen Hemminger , "K. Y. Srinivasan" , Haiyang Zhang , Long Li , Martin Spinler , Heinrich Kuhn , Harman Kalra , Akhil Goyal , Jerin Jacob , Maciej Czekaj , Maxime Coquelin , Chenbo Xia , Zhihong Wang , Yong Wang , Anatoly Burakov Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 19/25] drivers/net: check process type in close operation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 28, 2020 at 2:56 AM Sachin Saxena (OSS) wrote: > > For dpaa, dpaa2, enetc and pfe > > Reviewed-by: Sachin Saxena > > On 28-Sep-20 5:12 AM, Thomas Monjalon wrote: > > The secondary processes are not allowed to release shared resources. > Only process-private ressources should be freed in a secondary process. > Most of the time, there is no process-private ressource, > so the close operation is just forbidden in a secondary process. > > After adding proper check in the port close functions, > some redundant checks in the device remove functions are dropped. > > Signed-off-by: Thomas Monjalon > --- > drivers/net/af_xdp/rte_eth_af_xdp.c | 3 +++ > drivers/net/ark/ark_ethdev.c | 3 +++ > drivers/net/avp/avp_ethdev.c | 3 +++ > drivers/net/bnxt/bnxt_ethdev.c | 3 +++ > drivers/net/bnxt/bnxt_reps.c | 3 +++ For bnxt, Reviewed-by: Ajit Khaparde