From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35220A2EFC for ; Tue, 17 Sep 2019 03:56:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0615F1BEC0; Tue, 17 Sep 2019 03:56:47 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 828031BEBC for ; Tue, 17 Sep 2019 03:56:45 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id k25so1435146oiw.13 for ; Mon, 16 Sep 2019 18:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gFHctbKgQzUgQq1EH42gMz9j87lgUVJXrcb3j5d0Ip0=; b=DN/+4Y1E1Za4lheKEydXpobfJsOqOUVDoeFeK90+jfQgEde/+Y88nFhW9QVjitVGHl 8AFAqLnlt3pjfxkANssseiu4SzyxMlCRar/QjR1JcRqohVJGL2c8FmgditrvW6ot6HXX z1neUrS08UIOKOPc+AG6NR+fZWt7XPTvTfjpo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gFHctbKgQzUgQq1EH42gMz9j87lgUVJXrcb3j5d0Ip0=; b=szPOfhv/7a0Bzix7XAVL370DYEYNkbAIwNVNz4+p0a9hPKN5VzpMnjHOo3dEpAUE1b UpxpwAcYPH4rU631nKQWkufM4QrEk1r6e/upyBorLMhCez6V51Ea2gI3n7V67ktzIPGK 7cZOzuyz2kNoYuscXfBaqmG5WVkijpJBfKxhbf73QaURwL6b8gaTSbNngpuzTJNRxkFA q2u00j/OzVy4NmnHYCon0CRM/M9h9OoACYleb/i89Ho5e6OJAULJjAL5M5H/syKxADKe 1ycZyZDL5XqjNisbbY0thASorZHAh7cLOsGWiXfBGBtGUEUVsLF1C/ruXfgaoa1AVlpv Um9w== X-Gm-Message-State: APjAAAVZCD7QDzUhzkfzV/es4vVEWiQyut+zzQwrI0Oq17votAha9q4G fvCxbN2Yzxjdt0N8XfSeshN6F5MaAC40ikrWWyXiVg== X-Google-Smtp-Source: APXvYqzQ9g0YcWnLp4OjuH05CiI8KGK7TYUQZdy0X0aI5P7solby6374JoyM2gsi7NvuzHYbB2wqY3RvvMf5FJ5pFbI= X-Received: by 2002:aca:b388:: with SMTP id c130mr1945275oif.27.1568685404647; Mon, 16 Sep 2019 18:56:44 -0700 (PDT) MIME-Version: 1.0 References: <1567751873-15964-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-1-git-send-email-gavin.hu@arm.com> <1568633238-47888-5-git-send-email-gavin.hu@arm.com> In-Reply-To: <1568633238-47888-5-git-send-email-gavin.hu@arm.com> From: Ajit Khaparde Date: Mon, 16 Sep 2019 18:56:27 -0700 Message-ID: To: Gavin Hu Cc: dev@dpdk.org, nd@arm.com, Thomas Monjalon , Bruce Richardson , yong.liu@intel.com, yinan.wang@intel.com, Somnath Kotur , Honnappa.Nagarahalli@arm.com, ruifeng.wang@arm.com, steve.capper@arm.com, dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 4/5] net/bnxt: replace with cio barrier for doorbell resp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 16, 2019 at 4:27 AM Gavin Hu wrote: > To read the doorbell response, which is held in the host CIO memory, > rte_cio_rmb is sufficient. > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") > Cc: stable@dpdk.org > > Signed-off-by: Gavin Hu > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_hwrm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 1d9fb17..2d5dc00 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -138,7 +138,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, > void *msg, > /* Poll for the valid bit */ > for (i = 0; i < HWRM_CMD_TIMEOUT; i++) { > /* Sanity check on the resp->resp_len */ > - rte_rmb(); > + rte_cio_rmb(); > if (resp->resp_len && resp->resp_len <= bp->max_resp_len) { > /* Last byte of resp contains the valid key */ > valid = (uint8_t *)resp + resp->resp_len - 1; > -- > 2.7.4 > >