From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B8583A0562; Tue, 4 May 2021 06:02:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37D884014D; Tue, 4 May 2021 06:02:10 +0200 (CEST) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mails.dpdk.org (Postfix) with ESMTP id BD00640147 for ; Tue, 4 May 2021 06:02:08 +0200 (CEST) Received: by mail-qk1-f181.google.com with SMTP id u20so7350238qku.10 for ; Mon, 03 May 2021 21:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IJbPStTkmit+YWKHecXGYKE+zE2Go4ASPh2z8It0Pdo=; b=fICotlDhsvUVkIgJElZ37j8CfMeYfGoSk/Kw1LlXmpH4qdVwugpuCY+S9mZ7V1K2ql dZtTekhJjMoQnpTmCLa5SK4556TESxHjBlKABwzKjM6D7g5lSWqmwv3oSnrrDR/kMKAI v1a2nuW+gDm/JsLU5Dnl9ZvllvWdYtJ3S4XuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IJbPStTkmit+YWKHecXGYKE+zE2Go4ASPh2z8It0Pdo=; b=PVA7XMhB1SHdBfOADKydhdLCSQiL4xr2JKY2tkfuhcVNCex6Bg1qIspfpXRlFMWc8m olBpObqxKZ2pZm9UotQekShg4BR7dr17wHMQSrIu3bJhWM6yCH40pgqJhp1NSlbQAA/9 cDIxeC5iQV3JT7F/un8Bl4KfgjGe0wx6hGwIIuTLKJxfVzOKlNdq3eLDO83yNinSA4q9 PTY0Y5AA7EIhPGSxsTGzUxhiTn/1JnkWJ8B5u/0oVOBB5cMWSSht183pLE4aoggDRsKI dbyKa7LRvvG4KS7LBcP9HnNUWhfImKNMF766G9tb9zHj1X/7uqux0O9V9xXyEqh+OUPU 3wHw== X-Gm-Message-State: AOAM533OaY87oscjG8bVpnxEiFNiuuFNOvk89RlTp9vijlLiEEtc/8Qv QCrxoW+vxPxK6GKUknH+Weupmu20f5f3K3zHXyrzCg== X-Google-Smtp-Source: ABdhPJxSO84JGbt6Ms16vYcvQPHON2qSdBOvEVYYreSi/evD2w7Lx3dThi6hhoonBgRluFGZnBrWnFbiQhLwGabcPSA= X-Received: by 2002:a05:620a:6ce:: with SMTP id 14mr22812170qky.423.1620100928000; Mon, 03 May 2021 21:02:08 -0700 (PDT) MIME-Version: 1.0 References: <20210503052150.29189-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210503052150.29189-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Mon, 3 May 2021 21:01:51 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000054f55e05c1792430" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to prevent device access in error state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000054f55e05c1792430 Content-Type: text/plain; charset="UTF-8" On Sun, May 2, 2021 at 10:00 PM Kalesh A P < kalesh-anakkur.purayil@broadcom.com> wrote: > From: Kalesh AP > > Driver should prevent any DMA with the device when it > detects an error. When firmware is in fatal state, > stop tx/rx by assigning them to dummy functions. > > Fixes: be14720def9c ("net/bnxt: support FW reset") > Fixes: 9d0cbaecc91a ("net/bnxt: support periodic FW health monitoring") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Andy Gospodarek > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index 719eb68..822853a 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4275,6 +4275,8 @@ static void bnxt_check_fw_health(void *arg) > bp->flags |= BNXT_FLAG_FATAL_ERROR; > bp->flags |= BNXT_FLAG_FW_RESET; > > + bnxt_stop_rxtx(bp); > + > PMD_DRV_LOG(ERR, "Detected FW dead condition\n"); > > if (bnxt_is_master_func(bp)) > -- > 2.10.1 > > --00000000000054f55e05c1792430--