From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3092CA052B; Fri, 31 Jul 2020 07:03:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C866C1C002; Fri, 31 Jul 2020 07:03:52 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id BF9102862 for ; Fri, 31 Jul 2020 07:03:50 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id 93so11640053otx.2 for ; Thu, 30 Jul 2020 22:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2jV9LbE8cnbWhaeYCsK1tMjk3xvUJouw8Wy9iKxUuFM=; b=Am6BHA7ihIobXJg8V2xvoBBsK8VKop4L7PVTosst2xBu9FEkEQjyJLQWMwXLLzBFlF UUqJ6rFsFrgqgJa9E56dpk0JnSkgcnHNp46PzU04Vdag0Lvaq5hWFjOzyFstzoe4+fPE CKpAf346vlJE3zqw7mqO0qsaLwFQvQ9sx4Fbw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2jV9LbE8cnbWhaeYCsK1tMjk3xvUJouw8Wy9iKxUuFM=; b=hXUQy2uosZpUVYormigyJAjTRkvLNDHUwvZvpUz+qkXuqiMJaHZVwcrWwqk/Xyy4mK QESlvuL2dKe88BYMyJsubTnXe14rVnn8Fy7aEVMi5BrYeAjsARm4eEucGtTTo7QXO8Lw WSsfVBJPmNnDdFh+/w4IuYwXwV1EkPiX70xY3ljqQ4T+JG+9M8JgBr1PNOZkbkvX6y8l CoPn2SR8+PTlucb/fwyIQqjpGgSq39hI4G3mTo/3+cs21h9jo4tkah4At5w7AH09QjBk Fc3pK4vJjLH+SLcnxku7LzpzCecBFQEw4ai8hWLo9KMgCtMaTq6EpnJ0bAXh6EriWIVk +ZdQ== X-Gm-Message-State: AOAM532yFew798laXifaU3dAc3gsvg4fNV9R4c4VbMqoWitrjDLf9ATX wFhyR6jO7YQsiON7bxvkdcXyVrEVbooN0c4RTDV3SQ== X-Google-Smtp-Source: ABdhPJx93jUCXQg9kFX2JuXXiYirI+nBLHk0FbwXfu4tFBQKdt4nyM3OaAgjTp0e8j3X/m+fVsLeL8KykELK/e12gDw= X-Received: by 2002:a9d:3784:: with SMTP id x4mr1441796otb.95.1596171829797; Thu, 30 Jul 2020 22:03:49 -0700 (PDT) MIME-Version: 1.0 References: <20200731023444.27986-1-gaurav1086@gmail.com> In-Reply-To: <20200731023444.27986-1-gaurav1086@gmail.com> From: Ajit Khaparde Date: Thu, 30 Jul 2020 22:03:33 -0700 Message-ID: To: Gaurav Singh Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bxnt: remove redundant null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 30, 2020 at 7:35 PM Gaurav Singh wrote: > vxlan_mask cannot be NULL since its already being accessed > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index 320b53d94..33a074387 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, > } > > /* Check if VNI is masked. */ > - if (vxlan_spec && vxlan_mask) { > + if (vxlan_mask) { > vni_masked = > !!memcmp(vxlan_mask->vni, vni_mask, > RTE_DIM(vni_mask)); > -- > 2.17.1 > >