From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0B0CA04C3; Sat, 12 Sep 2020 06:53:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B2051C11D; Sat, 12 Sep 2020 06:53:25 +0200 (CEST) Received: from mail-oo1-f68.google.com (mail-oo1-f68.google.com [209.85.161.68]) by dpdk.org (Postfix) with ESMTP id 0A5B34C7B for ; Sat, 12 Sep 2020 06:53:24 +0200 (CEST) Received: by mail-oo1-f68.google.com with SMTP id y25so2779476oog.4 for ; Fri, 11 Sep 2020 21:53:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=heJkuVl2mob9URS3e3dDACyEPlzka8kNDwS9fu7dJ2g=; b=V519RPf0O/ccB3E/hse5wXfnfSKZdy2NiuRtar4zsF8ZIWd5/yYVdjbmDdr1jPHAfm j3h0Fh+Mmqpi9+S2HANh2v/LkL8e7taltxZUrgGlxXj5R7aYBjSO+hcFETrAA7Gx51Dy uQegmSflS75W3J5AbmCCIX/wql4ykGI3j/xx8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=heJkuVl2mob9URS3e3dDACyEPlzka8kNDwS9fu7dJ2g=; b=biqV6QL+vaA6g5lzs/s3AxjJtjXyPfvsB539F7c10d44Pobnw+sCO/r8j6K1IyXLAB srDZYSZ2mfblU2nIRMhJE0i1uB5i6QmKed31HnTuEd5sNortZuTfKtfpL8VlpS6dNSMv 6rSBitM/dWDImb2DmZxqYLfb4YYdTRAZD+zTKcHsBjyZp0uNbB42L3YbBzqj/L4TtMUJ 16MkdzYtghl5nbkqbyrb8L3QTuKD+Wfbt/eAQZpQbcmouELqq17dnRkncw9tUxaSj7Un VZxLvmZMejt0IOQukWcz95MNRxyKBMlsxp+F0PcvBhgRUVUtZQYcxNLpuSJ5hveq8fNu lWNQ== X-Gm-Message-State: AOAM532FnuXDqjT0m0/AqeblgDjJN8mW/SdMpperwQKPhucpShWHerwh hJbczE7hL2u79n+1BQ6utTZnM0D5OlbEsF6mij/vhw== X-Google-Smtp-Source: ABdhPJxFrWMpnQVcAEIsfsVVjY3bfSnGfVOAftwTA4XmguxlboX2BFROkevJ6xMm/rHkBvI9y8EDycMP+/OQQPcasAw= X-Received: by 2002:a4a:ea99:: with SMTP id r25mr3884936ooh.15.1599886403177; Fri, 11 Sep 2020 21:53:23 -0700 (PDT) MIME-Version: 1.0 References: <1599534347-20430-1-git-send-email-humin29@huawei.com> <1599722646-19188-1-git-send-email-humin29@huawei.com> <1599722646-19188-2-git-send-email-humin29@huawei.com> In-Reply-To: <1599722646-19188-2-git-send-email-humin29@huawei.com> From: Ajit Khaparde Date: Fri, 11 Sep 2020 21:53:06 -0700 Message-ID: To: "Min Hu (Connor)" Cc: dpdk-dev , Thomas Monjalon , Andrew Rybchenko , Ferruh Yigit , linuxarm@huawei.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH V4 1/3] ethdev: introduce FEC API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 10, 2020 at 12:26 AM Min Hu (Connor) wrote: > This patch adds Forward error correction(FEC) support for ethdev. > Introduce APIs which support query and config FEC information in > hardware. > > Signed-off-by: Min Hu (Connor) > Reviewed-by: Wei Hu (Xavier) > Reviewed-by: Chengwen Feng > Reviewed-by: Chengchang Tang > Reviewed-by: Ajit Khaparde > > --- > v2->v3: > add function return value "-ENOTSUP" for API > --- > lib/librte_ethdev/rte_ethdev.c | 50 +++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev.h | 75 > +++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_core.h | 77 > ++++++++++++++++++++++++++++++++ > lib/librte_ethdev/rte_ethdev_version.map | 5 +++ > 4 files changed, 207 insertions(+) > > diff --git a/lib/librte_ethdev/rte_ethdev.c > b/lib/librte_ethdev/rte_ethdev.c > index 7858ad5..b7ac791 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -3642,6 +3642,56 @@ rte_eth_led_off(uint16_t port_id) > return eth_err(port_id, (*dev->dev_ops->dev_led_off)(dev)); > } > > +int > +rte_eth_fec_get_capability(uint16_t port_id, uint8_t *fec_cap) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get_capability, > -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_get_capability)(dev, > + fec_cap)); > +} > + > +int > +rte_eth_fec_get(uint16_t port_id, enum rte_fec_mode *mode) > +{ > + struct rte_eth_dev *dev; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, mode)); > +} > + > +int > +rte_eth_fec_set(uint16_t port_id, enum rte_fec_mode mode) > +{ > + struct rte_eth_dev *dev; > + uint8_t fec_mode_mask; > + int ret; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > + > + ret = rte_eth_fec_get_capability(port_id, &fec_mode_mask); > + if (ret) > + return ret; > + > + /* > + * Check whether the configured mode is within the FEC capability. > + * If not, the configured mode will not be supported. > + */ > + if (!(fec_mode_mask & (1U << (uint8_t)mode))) { > + RTE_ETHDEV_LOG(ERR, "unsupported fec mode=%d\n", mode); > + return -EINVAL; > + } > + > + dev = &rte_eth_devices[port_id]; > + RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_set, -ENOTSUP); > + return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, mode)); > +} > + > /* > * Returns index into MAC address array of addr. Use 00:00:00:00:00:00 to > find > * an empty spot. > diff --git a/lib/librte_ethdev/rte_ethdev.h > b/lib/librte_ethdev/rte_ethdev.h > index 70295d7..c353480 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1511,6 +1511,17 @@ struct rte_eth_dcb_info { > struct rte_eth_dcb_tc_queue_mapping tc_queue; > }; > > +/** > + * This enum indicates the possible (forward error correction)FEC modes > + * of an ethdev port. > + */ > +enum rte_fec_mode { > + ETH_FEC_NOFEC = 0, /**< FEC is off */ > + ETH_FEC_BASER, /**< FEC using common algorithm */ > + ETH_FEC_RS, /**< FEC using RS algorithm */ > + ETH_FEC_AUTO /**< FEC autonegotiation modes */ > +}; > + > #define RTE_ETH_ALL RTE_MAX_ETHPORTS > > /* Macros to check for valid port */ > @@ -3328,6 +3339,70 @@ int rte_eth_led_on(uint16_t port_id); > int rte_eth_led_off(uint16_t port_id); > > /** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > + * > + * Get Forward Error Correction(FEC) capability. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param fec_cap > + * returns the FEC capability from the device, as follows: > + * bit0: nofec > + * bit1: baser > + * bit2: rs > + * bit3: auto > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support. > + * that operation. > + * - (-EIO) if device is removed. > + * - (-ENODEV) if *port_id* invalid. > + */ > +__rte_experimental > +int rte_eth_fec_get_capability(uint16_t port_id, uint8_t *fec_cap); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > + * > + * Get current Forward Error Correction(FEC) mode. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param mode > + * returns the FEC mode from the device. > + * @return > + * - (0) if successful. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support. > + * that operation. > + * - (-EIO) if device is removed. > + * - (-ENODEV) if *port_id* invalid. > + */ > +__rte_experimental > +int rte_eth_fec_get(uint16_t port_id, enum rte_fec_mode *mode); > + > +/** > + * @warning > + * @b EXPERIMENTAL: this API may change, or be removed, without prior > notice > + * > + * Set Forward Error Correction(FEC) mode. > + * > + * @param port_id > + * The port identifier of the Ethernet device. > + * @param mode > + * the FEC mode. > + * @return > + * - (0) if successful. > + * - (-EINVAL) if the FEC mode is not valid. > + * - (-ENOTSUP) if underlying hardware OR driver doesn't support. > + * - (-EIO) if device is removed. > + * - (-ENODEV) if *port_id* invalid. > + */ > +__rte_experimental > +int rte_eth_fec_set(uint16_t port_id, enum rte_fec_mode mode); > + > +/** > * Get current status of the Ethernet link flow control for Ethernet > device > * > * @param port_id > diff --git a/lib/librte_ethdev/rte_ethdev_core.h > b/lib/librte_ethdev/rte_ethdev_core.h > index 32407dd..df9e18a 100644 > --- a/lib/librte_ethdev/rte_ethdev_core.h > +++ b/lib/librte_ethdev/rte_ethdev_core.h > @@ -604,6 +604,76 @@ typedef int (*eth_tx_hairpin_queue_setup_t) > const struct rte_eth_hairpin_conf *hairpin_conf); > > /** > + * @internal > + * Get Forward Error Correction(FEC) capability. > + * > + * @param dev > + * ethdev handle of port. > + * @param fec_cap > + * returns the FEC capability from the device. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, get FEC success. > + * @retval -ENOTSUP > + * operation is not supported. > + * @retval -EIO > + * device is removed. > + * @retval -ENODEV > + * Device is gone. > + */ > +typedef int (*eth_fec_get_capability_t)(struct rte_eth_dev *dev, > + uint8_t *fec_cap); > + > +/** > + * @internal > + * Get Forward Error Correction(FEC) mode. > + * > + * @param dev > + * ethdev handle of port. > + * @param mode > + * returns the FEC mode from the device. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, get FEC success. > + * @retval -ENOTSUP > + * operation is not supported. > + * @retval -EIO > + * device is removed. > + * @retval -ENODEV > + * Device is gone. > + */ > +typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev, enum rte_fec_mode > *mode); > + > +/** > + * @internal > + * Set Forward Error Correction(FEC) mode. > + * > + * @param dev > + * ethdev handle of port. > + * @param mode > + * the FEC mode. > + * > + * @return > + * Negative errno value on error, 0 on success. > + * > + * @retval 0 > + * Success, set FEC success. > + * @retval -ENOTSUP > + * operation is not supported. > + * @retval -EIO > + * device is removed. > + * @retval -ENODEV > + * Device is gone. > + */ > +typedef int (*eth_fec_set_t)(struct rte_eth_dev *dev, enum rte_fec_mode > mode); > + > +/** > * @internal A structure containing the functions exported by an Ethernet > driver. > */ > struct eth_dev_ops { > @@ -752,6 +822,13 @@ struct eth_dev_ops { > /**< Set up device RX hairpin queue. */ > eth_tx_hairpin_queue_setup_t tx_hairpin_queue_setup; > /**< Set up device TX hairpin queue. */ > + > + eth_fec_get_capability_t fec_get_capability; > + /**< Get Forward Error Correction(FEC) capability; */ > + eth_fec_get_t fec_get; > + /**< Get Forward Error Correction(FEC) mode; */ > + eth_fec_set_t fec_set; > + /**< Set Forward Error Correction(FEC) mode; */ > }; > > /** > diff --git a/lib/librte_ethdev/rte_ethdev_version.map > b/lib/librte_ethdev/rte_ethdev_version.map > index 1212a17..33cf5e4 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -241,6 +241,11 @@ EXPERIMENTAL { > __rte_ethdev_trace_rx_burst; > __rte_ethdev_trace_tx_burst; > rte_flow_get_aged_flows; > + > + # added in 20.11 > + rte_eth_fec_get_capability; > + rte_eth_fec_get; > + rte_eth_fec_set; > }; > > INTERNAL { > -- > 2.7.4 > >