From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: drop the unused attribute
Date: Sat, 24 Apr 2021 12:23:50 -0700 [thread overview]
Message-ID: <CACZ4nhtjycbWFv3OrmJrV_zopB=iKb5mx2cp4EnP50-XY9jeUQ@mail.gmail.com> (raw)
In-Reply-To: <20210423052226.13592-1-kalesh-anakkur.purayil@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 2166 bytes --]
On Thu, Apr 22, 2021 at 10:00 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Remove "__rte_unused" instances that are wrongly marked.
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_reps.c | 4 ++--
> drivers/net/bnxt/bnxt_stats.h | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_reps.c b/drivers/net/bnxt/bnxt_reps.c
> index b224a7d..bdbad53 100644
> --- a/drivers/net/bnxt/bnxt_reps.c
> +++ b/drivers/net/bnxt/bnxt_reps.c
> @@ -104,7 +104,7 @@ bnxt_rep_rx_burst(void *rx_queue,
> static uint16_t
> bnxt_rep_tx_burst(void *tx_queue,
> struct rte_mbuf **tx_pkts,
> - __rte_unused uint16_t nb_pkts)
> + uint16_t nb_pkts)
> {
> struct bnxt_vf_rep_tx_queue *vfr_txq = tx_queue;
> struct bnxt_tx_queue *ptxq;
> @@ -548,7 +548,7 @@ int bnxt_rep_dev_info_get_op(struct rte_eth_dev *eth_dev,
> return 0;
> }
>
> -int bnxt_rep_dev_configure_op(__rte_unused struct rte_eth_dev *eth_dev)
> +int bnxt_rep_dev_configure_op(struct rte_eth_dev *eth_dev)
> {
> struct bnxt_representor *rep_bp = eth_dev->data->dev_private;
>
> diff --git a/drivers/net/bnxt/bnxt_stats.h b/drivers/net/bnxt/bnxt_stats.h
> index 0ee2269..ee6b1be 100644
> --- a/drivers/net/bnxt/bnxt_stats.h
> +++ b/drivers/net/bnxt/bnxt_stats.h
> @@ -12,7 +12,7 @@ void bnxt_free_stats(struct bnxt *bp);
> int bnxt_stats_get_op(struct rte_eth_dev *eth_dev,
> struct rte_eth_stats *bnxt_stats);
> int bnxt_stats_reset_op(struct rte_eth_dev *eth_dev);
> -int bnxt_dev_xstats_get_names_op(__rte_unused struct rte_eth_dev *eth_dev,
> +int bnxt_dev_xstats_get_names_op(struct rte_eth_dev *eth_dev,
> struct rte_eth_xstat_name *xstats_names,
> __rte_unused unsigned int limit);
> int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev,
> --
> 2.10.1
>
next prev parent reply other threads:[~2021-04-24 19:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-23 5:22 Kalesh A P
2021-04-24 19:23 ` Ajit Khaparde [this message]
2021-04-28 15:48 ` Ferruh Yigit
2021-04-29 4:20 ` Kalesh Anakkur Purayil
2021-04-29 11:08 ` Ferruh Yigit
2021-04-29 11:37 ` Kalesh Anakkur Purayil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhtjycbWFv3OrmJrV_zopB=iKb5mx2cp4EnP50-XY9jeUQ@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).