From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C78F0A0521; Tue, 28 Jul 2020 07:22:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 904321BFF5; Tue, 28 Jul 2020 07:22:31 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 8D8DF1BFF2 for ; Tue, 28 Jul 2020 07:22:30 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id 93so3874790otx.2 for ; Mon, 27 Jul 2020 22:22:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KKdsbht7VOOY+0OBDqFV3kv05CH13A363n0OW2+4vQo=; b=UQQNmLKiOGOdb1AloNTVn1Xc3AD6UdI5Wqz6cV0yFrnpReRZNvOeFhRCBEipJga36j vSyUBa6QuNybGt8NuFK7eMGacF6k3rqeZ+5CK0W6C8ULsddg6XYwt08IhMYimL6vPBsm JOWNwKY68hAoYQprDSXjLPBe73//sTZysshvc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KKdsbht7VOOY+0OBDqFV3kv05CH13A363n0OW2+4vQo=; b=Wf7fUBMYFdFAv7LmFXwy+bSW5dhpDRV0/l+l+4pBJAUetB3NV/9I70V65z9IG2+znG wEYvjaAZatPakeDaEZTctL6pAO7T+ClkhovRn0fvep59ryb1D/Wxj84065wD6pga6xGS sroew0G6q4+w4bezmWYQa/1CPSRwf9A7TfqYSCAaKvTPdVsqsRqLe8GSUkGZQGdzpM88 8lHO09v7Dkml6WUSBhT8yF7XdQFDgsvsKxa4h4vdFF6mUkyYOzq/5D2K5rk+mVjHJsSR VdrQt8miufpbCxExzI9MSPeEr2mtcwUpGPHCZG1X7Ch7Gyb/qQL6qCTnQJjlWZNDObVW Yezg== X-Gm-Message-State: AOAM531RwPHggR1QcI8UC3cP75IFszDqWfkXvclyHThSuzhUcw+ENFT1 V/sm9/Obi/dNk6mXoByVXB+kAODZLlH0JPmr+UbqJMMx9o4= X-Google-Smtp-Source: ABdhPJxVVoCnI8UuSOc8vaGb5oqj1HwMmU8GeLBqKS3m9b7fTB4OGD2TQYKPOV0qRbgLE5WWMLfNVwEm+EBsZ4y4mTs= X-Received: by 2002:a9d:5f92:: with SMTP id g18mr21508343oti.95.1595913749760; Mon, 27 Jul 2020 22:22:29 -0700 (PDT) MIME-Version: 1.0 References: <20200723115639.22357-1-somnath.kotur@broadcom.com> <20200724053235.71069-1-ajit.khaparde@broadcom.com> <20200724053235.71069-10-ajit.khaparde@broadcom.com> <64484f93-7ee6-fc41-4fd6-ed73f42f69e8@intel.com> In-Reply-To: <64484f93-7ee6-fc41-4fd6-ed73f42f69e8@intel.com> From: Ajit Khaparde Date: Mon, 27 Jul 2020 22:22:13 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Kishore Padmanabha , Michael Baucom Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 09/22] net/bnxt: ignore VLAN priority mask X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jul 27, 2020 at 3:30 AM Ferruh Yigit wrote: > On 7/24/2020 6:32 AM, Ajit Khaparde wrote: > > From: Kishore Padmanabha > > > > This is a work around for the OVS setting offload rules that > > are passing vlan priority mask as wild card and currently we > > do not support it. > > > > Signed-off-by: Kishore Padmanabha > > Reviewed-by: Michael Baucom > > --- > > drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > > index 67f9319d6..665f5d381 100644 > > --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > > +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c > > @@ -709,8 +709,17 @@ ulp_rte_vlan_hdr_handler(const struct rte_flow_item > *item, > > vlan_tag |= ~ULP_VLAN_TAG_MASK; > > vlan_tag = htons(vlan_tag); > > > > +#ifdef ULP_DONT_IGNORE_TOS > > ulp_rte_prsr_mask_copy(params, &idx, &priority, > > sizeof(priority)); > > +#else > > + /* > > + * The priority field is ignored since OVS is setting it as > > + * wild card match and it is not supported. This is a work > > + * around and shall be addressed in the future. > > + */ > > + idx += 1; > > +#endif > > ulp_rte_prsr_mask_copy(params, &idx, &vlan_tag, > > sizeof(vlan_tag)); > > ulp_rte_prsr_mask_copy(params, &idx, > &vlan_mask->inner_type, > > > > Hi Ajit, > > What sets the 'ULP_DONT_IGNORE_TOS', I don't see it in our build system. > If ways > 'else' leg is taken, why not drop the macro completely? > Ferruh, Yes. I will submit a v4 to take care of that. Thanks Ajit