From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C5B4A0528; Thu, 9 Jul 2020 16:34:56 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F0CD1E8F4; Thu, 9 Jul 2020 16:34:56 +0200 (CEST) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by dpdk.org (Postfix) with ESMTP id 541291E8BC for ; Thu, 9 Jul 2020 16:34:55 +0200 (CEST) Received: by mail-oi1-f193.google.com with SMTP id k4so2053996oik.2 for ; Thu, 09 Jul 2020 07:34:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=itaP2eGsSysB7K7lwQT6jgH5fzZJBnVJKVWCdl88SPY=; b=hqXo1v0h55ZvdFJMmZJwHeGlesUryneNJAsvDCOxQ2pVErljhcvkb6O9NoFOnYmu1c 7hzc6OYqOsmDrP9MUaBjsayoTWLFeudit8ND9oAMZm/dU6lQfG1Di5mi5e7nlsRVaYAm m0FdKVU0ARCAymS0vouGC082xFYec/oPor1+Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=itaP2eGsSysB7K7lwQT6jgH5fzZJBnVJKVWCdl88SPY=; b=kRlx5ho9UyjSHvj3WgzCvBOxh0n8ZQEVz95CJZ2fgpJ6hw1RyazeVyIuJT/fhVrUw+ BiMxZPZ99bF5BJFJdrayNPcpZqfDNTRO6um+cusSDoznDJ0rbBRKJgoGbFmfmACL7JOJ waNzBbOZecxLucUlWyOBYdagMqZlyZw3BGTVFmySDX7Yoj+4I+VRPNBmThiDYDk5gBCz RlO57qtB1Wlc4p3FeGePQBwKgpbaxyaSUGF3FieFBr2mxY1LBXZ/YMTuMWNUejFMvFdj bbGVbPGFdByDqso0pd9Hfyo0KvXXWAMm2+HJYERoggzKeD0dVg63NAGjYGyK3omCjUaL 4gBw== X-Gm-Message-State: AOAM533+RmpM2/RVmiKxKk8SQdXIXLvib3LNxnU4p2o7OUbBdectE4rO lZMFSMaThLoO8gaVo6nhMKL80G0cLwit5U9qIWrVXQ== X-Google-Smtp-Source: ABdhPJwc8QKbIAtngKTd3V2c1y8MBFiXL3ywAwVztI9VDMEOpq1HGnl8ocxlpYiqV0HnHQsqIssvbvEWt5hLVaiker8= X-Received: by 2002:aca:5347:: with SMTP id h68mr286462oib.168.1594305294379; Thu, 09 Jul 2020 07:34:54 -0700 (PDT) MIME-Version: 1.0 References: <20200709081504.12336-1-david.marchand@redhat.com> In-Reply-To: <20200709081504.12336-1-david.marchand@redhat.com> From: Ajit Khaparde Date: Thu, 9 Jul 2020 07:34:38 -0700 Message-ID: To: David Marchand Cc: dpdk-dev , Ferruh Yigit , Thomas Monjalon , Somnath Kotur , Randy Schacher , Venkat Duvvuru , Peter Spreadborough Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix build issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 9, 2020 at 1:15 AM David Marchand wrote: > In existing build env, RTE_LIBRTE_BNXT_PMD_SYSTEM is unset. > Testing against a n value does not work and we end up with a link issue: > > /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_alloc': > .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1040: undefined reference > to `tf_em_ext_alloc' > /usr/bin/ld: tf_core/tf_em_common.o: in function `tf_em_ext_common_free': > .../dpdk/drivers/net/bnxt/tf_core/tf_em_common.c:1047: undefined reference > to `tf_em_ext_free' > collect2: error: ld returned 1 exit status > gmake[4]: *** [.../dpdk/mk/rte.lib.mk:95: librte_pmd_bnxt.so.20.0.3] > Error 1 > gmake[3]: *** [.../dpdk/mk/rte.subdir.mk:35: bnxt] Error 2 > > Fixes: b2da02480cb7 ("net/bnxt: support EEM system memory") > > Signed-off-by: David Marchand > Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/tf_core/Makefile | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bnxt/tf_core/Makefile > b/drivers/net/bnxt/tf_core/Makefile > index b4fbdd00fc..806471427c 100644 > --- a/drivers/net/bnxt/tf_core/Makefile > +++ b/drivers/net/bnxt/tf_core/Makefile > @@ -16,10 +16,10 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_msg.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_tbl.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_common.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_internal.c > -ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM), n) > -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c > +ifeq ($(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM),y) > +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_system.c > else > -SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD_SYSTEM) += tf_core/tf_em_system.c > +SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_em_host.c > endif > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_session.c > SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) += tf_core/tf_device.c > -- > 2.23.0 > >