From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC04BA09E4; Thu, 21 Jan 2021 17:03:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5769140D20; Thu, 21 Jan 2021 17:03:17 +0100 (CET) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by mails.dpdk.org (Postfix) with ESMTP id CB24C140D0A for ; Thu, 21 Jan 2021 17:03:16 +0100 (CET) Received: by mail-qt1-f178.google.com with SMTP id j26so1854229qtq.8 for ; Thu, 21 Jan 2021 08:03:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/MgzvzHiQsR4k2HIVHchFE89n9wjyjB7lz5ojNoFUns=; b=MCNnLgMLDenZZH5/0F51kmHElGXSuofntQL66+RncJv/5B1kJI1hpL5heGygG9qRmj 5Vv00CeuQDSqP9u46VK1FsBihNk1RJUBrY3/l7oHB/UdmGwaGg8Tk5tQzlzU6BpwNb5S 9hU+YH0Ca2jYj80Jn9HUgEKRGcFJxbSzR8uMY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/MgzvzHiQsR4k2HIVHchFE89n9wjyjB7lz5ojNoFUns=; b=InBByzhspEBTclwudSiHUbDHPQs/EjD/rqs8+5CpSWCmteh5BjfHH2L5LNpciuKVpE a6kZPOKHYxMDPE6lA22QxjfccmKFfmnwvCGZ5noCJTch/G7ncfSsAI8MKHnfBJf6dAFG +ALJnlEVt9jsPTPQIlVDShfk5f8fCfS7Ay8gKDzyEvveavMyAV3qZET+Z2lC7nap9QsW KGQqEQEkGJI26wSM+Ivg7CVlJ+7pupwPSnvZLFyWvpbtHFsf2H+KXUYJ67hi6tUYhHEs 64ccOjWBUkn7PfUnqI54wHwtpeNTej3lqRKL+eJW0ewubp7iFebjBzJQGxD22xlX7EZO TTnw== X-Gm-Message-State: AOAM533Zmya0s2dD1GggRoPZgtnHOadat7zhpIfShObAeANpHfxKQrns ArDPUvqvACR/REiSJ4zd2rI3jsoC6zQSSgxKIqyyqA== X-Google-Smtp-Source: ABdhPJwnLQHmcemxki+sZgcFy1USWLpLnAx9Nn+NVfDl8lRqXHUqOKSrDjFAp1VPVwFILa0Y5HG2rHqN/fxNQFcOwZc= X-Received: by 2002:ac8:5894:: with SMTP id t20mr298201qta.194.1611244995210; Thu, 21 Jan 2021 08:03:15 -0800 (PST) MIME-Version: 1.0 References: <20210114022716.7999-1-ajit.khaparde@broadcom.com> <20210121071656.32879-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210121071656.32879-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Thu, 21 Jan 2021 08:02:58 -0800 Message-ID: To: Ajit Khaparde Cc: dpdk-dev , Somnath Kotur Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000a85ac605b96b3570" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v3] net/bnxt: fix lock handling in stop and close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000a85ac605b96b3570 Content-Type: text/plain; charset="UTF-8" On Wed, Jan 20, 2021 at 11:17 PM Ajit Khaparde wrote: > > From: Somnath Kotur > > err_recovery_lock needs to be released before returning in > stop and close_op if FW_RESET flag is set. > > Fixes: dd3613560573 ("net/bnxt: check chip reset in dev stop and close") > Signed-off-by: Somnath Kotur > Reviewed-by: Ajit Khaparde Patch applied to dpdk-next-net-brcm. > --- > v1->v2: rebased to latest dpdk-next-net and updated commit log. > v2->v3: rebased to latest dpdk-next-net. > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index f439aeee4..89e42ef14 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1374,6 +1374,7 @@ static int bnxt_dev_stop_op(struct rte_eth_dev *eth_dev) > if (bp->flags & BNXT_FLAG_FW_RESET) { > PMD_DRV_LOG(ERR, > "Adapter recovering from error..Please retry\n"); > + pthread_mutex_unlock(&bp->err_recovery_lock); > return -EAGAIN; > } > pthread_mutex_unlock(&bp->err_recovery_lock); > @@ -1497,6 +1498,7 @@ static int bnxt_dev_close_op(struct rte_eth_dev *eth_dev) > if (bp->flags & BNXT_FLAG_FW_RESET) { > PMD_DRV_LOG(ERR, > "Adapter recovering from error...Please retry\n"); > + pthread_mutex_unlock(&bp->err_recovery_lock); > return -EAGAIN; > } > pthread_mutex_unlock(&bp->err_recovery_lock); > -- > 2.21.1 (Apple Git-122.3) > --000000000000a85ac605b96b3570--