From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D93C3A09E4; Fri, 29 Jan 2021 03:15:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 775024067B; Fri, 29 Jan 2021 03:15:08 +0100 (CET) Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) by mails.dpdk.org (Postfix) with ESMTP id 1637840395 for ; Fri, 29 Jan 2021 03:15:07 +0100 (CET) Received: by mail-qk1-f180.google.com with SMTP id x81so7484325qkb.0 for ; Thu, 28 Jan 2021 18:15:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q2L3BQtrheW826Mqm51iw8PwW+52hvZfaiCsgzS+Ygs=; b=U7VXk3gp7DL9zL8M8iVM8I6PCA071k/PHSsfUdvqf9zjbX7m3JHDe0Fn9SEqj243xv 3apfU8SyaArkC15HNCTL5gODNIYUqUXcJhaA890DmsI0VgT31mc9bcqfxWukbszF3fUX z83DtCsV1wS1usbPiQe8bKYXyR5Vj2PpFyfwc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q2L3BQtrheW826Mqm51iw8PwW+52hvZfaiCsgzS+Ygs=; b=NXRTFZRrrDrPwG7iSmNIOqL33KiX2RBWby8V+Ru0iyOSNijC641oa7/5f3fgB18ZmO cyQXiCoDcVgc/LsBXyLZ3DZ2kXekziL+5b7z7tIm9Gbiay1YlrEDV8UpdSFdO90tAlX+ rY+nbgldVN2kRwNBOBLQAx5ByrY/MqTi29tYaLqLQFMNJfQ0RBIzRQPAL4iWp+FxeB2O pjDznjOdpfwmPC0Ws0FNGGczCTMcPMt282XCLZB8VxKhwkxYfjKsi2NaEEAMPW55A0/2 IjnuskZu26TUDtaG2v36JpEQNtRwIywsxITan+504vuzxcNL5QgLpodVKT0bvd2IYrTO GRXA== X-Gm-Message-State: AOAM532/ma/ttNUXkVzCHOy2u22deBFX8yAn4DYGifJhzMRVXJhC3PSa FKQRmUUkVfUBWGgeAPCRFDJ/CG5h83jx9AkVjtC1LabW4kSANA== X-Google-Smtp-Source: ABdhPJy3Wx2rCqCGFonp4iMPr3VT4d0LqCiUuzhXFWdLoim6G17EW+0/pQm/Pvuq3qNOAcHil5icY1IgAtJVa4x6qCw= X-Received: by 2002:a05:620a:ec9:: with SMTP id x9mr2390591qkm.333.1611886506241; Thu, 28 Jan 2021 18:15:06 -0800 (PST) MIME-Version: 1.0 References: <20210128035330.27049-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210128035330.27049-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Thu, 28 Jan 2021 18:14:48 -0800 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000a5856a05ba0092aa" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix mbuf flags for PTP packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000a5856a05ba0092aa Content-Type: text/plain; charset="UTF-8" On Wed, Jan 27, 2021 at 7:30 PM Kalesh A P wrote: > > From: Kalesh AP > > Commit "899f06130724" broke the update of mbuf flags for PTP packets. > "mbuf->ol_flags" is overwritten in bnxt_set_ol_flags() function. > > Fixes: 899f06130724 ("net/bnxt: add Rx logic for 58818 chips") > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Kumar Khaparde Patch applied to dpdk-next-net-brcm/for-next-net. Thanks > --- > drivers/net/bnxt/bnxt_rxr.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index 969cae1..9fc03ae 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -589,6 +589,12 @@ bnxt_set_ol_flags(struct bnxt_rx_ring_info *rxr, struct rx_pkt_cmpl *rxcmp, > ol_flags |= PKT_RX_RSS_HASH; > } > > +#ifdef RTE_LIBRTE_IEEE1588 > + if (unlikely((flags_type & RX_PKT_CMPL_FLAGS_MASK) == > + RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP)) > + ol_flags |= PKT_RX_IEEE1588_PTP | PKT_RX_IEEE1588_TMST; > +#endif > + > mbuf->ol_flags = ol_flags; > } > > @@ -842,10 +848,8 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, > #ifdef RTE_LIBRTE_IEEE1588 > if (unlikely((rte_le_to_cpu_16(rxcmp->flags_type) & > RX_PKT_CMPL_FLAGS_MASK) == > - RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP)) { > - mbuf->ol_flags |= PKT_RX_IEEE1588_PTP | PKT_RX_IEEE1588_TMST; > + RX_PKT_CMPL_FLAGS_ITYPE_PTP_W_TIMESTAMP)) > bnxt_get_rx_ts_p5(rxq->bp, rxcmp1->reorder); > - } > #endif > > if (cmp_type == CMPL_BASE_TYPE_RX_L2_V2) { > -- > 2.10.1 > --000000000000a5856a05ba0092aa--