From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7920BA04AF;
Wed, 19 Aug 2020 19:46:15 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id E3E8D1C026;
Wed, 19 Aug 2020 19:46:14 +0200 (CEST)
Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com
[209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 1B4651BE7D
for <dev@dpdk.org>; Wed, 19 Aug 2020 19:46:14 +0200 (CEST)
Received: by mail-oi1-f196.google.com with SMTP id b22so21736917oic.8
for <dev@dpdk.org>; Wed, 19 Aug 2020 10:46:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=q1fVv0roFdxdrYEGyiMVbV4ppwgryDlnmMxTIWIW6T8=;
b=NXFiK0QZQaQiCHYgFbfv+gYVaobf/CkHuiH05MpamBthh4T5ocIXz3n5uZX0/fEzig
IIH0LsqDYJjdR3HhwFKqFn5/uI5N99gDDqm289FhOsEUQHEktXm3uTZpkTcnOWOpd0I0
pt6+MjjhTo6m0BPixj/octyIrUWGvhystKV4U=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=q1fVv0roFdxdrYEGyiMVbV4ppwgryDlnmMxTIWIW6T8=;
b=TU2yMnuK3un8tI/rh1tRqp8jJtMB9QJqth5uwKW00DgtdqXbnfief3zbaoCsH5GcxK
Vm8DN4UX3pk+jEcgpIKKQPIuFVATUKR4Frc53WooqdYgJ3tHh4QrjUjZ0oZJvt2uG5iX
8yrP5bixnPpWh+d2EgmMdqS7Dw9dozJwxRgT8m4og7dtV/f5b9o2CEaGcbWtoTqamjlA
CYN7Q2IJ3ERnEYvYgZmpTRA8+DX6fITQLuuPORsKel6KUkHLB3FF55C2lYBNlD0rwCsw
KmsxwkQ5bgfAiOsMVlBXR24yQNfIIwFjk2XHCb82Gu2HCVKBkA+DcfU+Ejd7IITxMooV
rcFw==
X-Gm-Message-State: AOAM532GE3ESTLB0DLOE6J4HMf4niJq0PAlYKQvd3WqBLZ6LzIdzwEx3
utvP0reobjdoeWDVEgkF6m1L01czEQfjBmKvkL/M5Q==
X-Google-Smtp-Source: ABdhPJx2ivguHWUvX1p060GjMduLcSU0/c/Xf4nsacfQaE1+wZSzLskjVi5ZY97/kY6zpvaeC8bXxJEcBEda7urJJqY=
X-Received: by 2002:aca:f550:: with SMTP id t77mr3987561oih.168.1597859173219;
Wed, 19 Aug 2020 10:46:13 -0700 (PDT)
MIME-Version: 1.0
References: <1597310476-11293-1-git-send-email-juraj.linkes@pantheon.tech>
<1597401092-13713-1-git-send-email-juraj.linkes@pantheon.tech>
<1597401092-13713-2-git-send-email-juraj.linkes@pantheon.tech>
In-Reply-To: <1597401092-13713-2-git-send-email-juraj.linkes@pantheon.tech>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Wed, 19 Aug 2020 10:45:57 -0700
Message-ID: <CACZ4nhu-hu+fDcghpR_QDirQRxUSDKu9RYg0atPeUjrF7hPWdg@mail.gmail.com>
To: =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Aaron Conole <aconole@redhat.com>,
maicolgabriel@hotmail.com, dpdk-dev <dev@dpdk.org>,
Ruifeng Wang <ruifeng.wang@arm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v7 1/5] net/bnxt: add support for aarch32
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Fri, Aug 14, 2020 at 3:32 AM Juraj Linke=C5=A1 <juraj.linkes@pantheon.te=
ch>
wrote:
> From: Ruifeng Wang <ruifeng.wang@arm.com>
>
> Expand vector PMD support to aarch32.
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
> drivers/net/bnxt/Makefile | 2 +-
> drivers/net/bnxt/bnxt_rxq.h | 2 +-
> drivers/net/bnxt/bnxt_rxr.h | 2 +-
> drivers/net/bnxt/bnxt_txr.h | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile
> index 0c5b74918..06a47dc49 100644
> --- a/drivers/net/bnxt/Makefile
> +++ b/drivers/net/bnxt/Makefile
> @@ -43,7 +43,7 @@ SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) +=3D rte_pmd_bnxt.c
> ifeq ($(CONFIG_RTE_ARCH_X86), y)
> SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) +=3D bnxt_rxtx_vec_sse.c
> endif
> -ifeq ($(CONFIG_RTE_ARCH_ARM64), y)
> +ifneq ($(filter y,$(CONFIG_RTE_ARCH_ARM) $(CONFIG_RTE_ARCH_ARM64)),)
> SRCS-$(CONFIG_RTE_LIBRTE_BNXT_PMD) +=3D bnxt_rxtx_vec_neon.c
> endif
>
Thanks for the changes.
With makefiles being deprecated, I don't think this will be required.
That said, I don't see drivers/net/bnxt/meson.build being modified.
Is that not required?
> diff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h
> index d5ce3b6d5..1c4027711 100644
> --- a/drivers/net/bnxt/bnxt_rxq.h
> +++ b/drivers/net/bnxt/bnxt_rxq.h
> @@ -22,7 +22,7 @@ struct bnxt_rx_queue {
> uint16_t nb_rx_hold; /* num held free RX desc */
> uint16_t rx_free_thresh; /* max free RX desc to
> hold */
> uint16_t queue_id; /* RX queue index */
> -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> defined(RTE_ARCH_ARM)
> uint16_t rxrearm_nb; /* number of descs to reinit.
> */
> uint16_t rxrearm_start; /* next desc index to
> reinit. */
> #endif
> diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
> index 2bf46cd91..e2fba1647 100644
> --- a/drivers/net/bnxt/bnxt_rxr.h
> +++ b/drivers/net/bnxt/bnxt_rxr.h
> @@ -221,7 +221,7 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq);
> int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id);
> int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id);
>
> -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> defined(RTE_ARCH_ARM)
> uint16_t bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,
> uint16_t nb_pkts);
> int bnxt_rxq_vec_setup(struct bnxt_rx_queue *rxq);
> diff --git a/drivers/net/bnxt/bnxt_txr.h b/drivers/net/bnxt/bnxt_txr.h
> index 7715c11b8..38e5ac9df 100644
> --- a/drivers/net/bnxt/bnxt_txr.h
> +++ b/drivers/net/bnxt/bnxt_txr.h
> @@ -59,7 +59,7 @@ uint16_t bnxt_xmit_pkts(void *tx_queue, struct rte_mbuf
> **tx_pkts,
> uint16_t nb_pkts);
> uint16_t bnxt_dummy_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,
> uint16_t nb_pkts);
> -#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64)
> +#if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) ||
> defined(RTE_ARCH_ARM)
> uint16_t bnxt_xmit_pkts_vec(void *tx_queue, struct rte_mbuf **tx_pkts,
> uint16_t nb_pkts);
> #endif
> --
> 2.20.1
>
>