From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 140C7A04B5;
Wed, 30 Sep 2020 15:41:12 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C9B611DAEC;
Wed, 30 Sep 2020 15:41:08 +0200 (CEST)
Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com
[209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 325561D669
for <dev@dpdk.org>; Wed, 30 Sep 2020 15:41:07 +0200 (CEST)
Received: by mail-ot1-f68.google.com with SMTP id n61so1816532ota.10
for <dev@dpdk.org>; Wed, 30 Sep 2020 06:41:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=GBhK3vROftZ/GGdY5uAYmMHJaNzvsBPlttpOfcj79xw=;
b=G/yD4SqwRxFXPpzgMMy7cEDozLmbkP+MPhx3o0FcAqbAwX7syIoUwNk+vVmGdpZPPI
x3r5VJ6w3pm7LP8zd88htk52sBfQgsH8THBfWo2ksc5WoOUPeiObtdLdsjlu4It714lp
sis5ojV4zKo8Xh53yfeYKlvkShtDOESmXZiWU=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=GBhK3vROftZ/GGdY5uAYmMHJaNzvsBPlttpOfcj79xw=;
b=Cfq/lCwfTFnJQTW0cyP3DrKdngeDKLHC0LekyH6t1cAQNGF1z/I5uQIoByq3cJqYnN
QVfszRchgDk4hppFcmjjSDuODeCgBpCcp2zEgGgErK318h4xGzvxS0RBjSbCuW9aYpHO
eMQzfkuccRpTTvcug+QEGHfkCsLtUxl+PDU0+Plyi4ne/vDxKL/EGFnK2NZ3bUj2KlGt
LlHvOqS7qXFfN+v2JUMBQrWX5TsbcZOd5KtHCGpPCaVYMacdE9n/pofy1fNpus65a2as
iOLZmPGoLuKw+jOHsGmrugyU5IkolN6zJ5wePJJWoj+VJAAClrzHJ3YHGedFq089JLWW
GPbA==
X-Gm-Message-State: AOAM5302rcpUrV7sGCS7Yyl44vBLzitavVxwLbijPMayQkR6DOzLD00I
Ad8M5zwihjfQ36dLdW6MT1tCb5js8W5pmdKDnAEnLw==
X-Google-Smtp-Source: ABdhPJwp0P3FSZX4s6SBOhgK3TBWneACteB+l9ojixVGY1vk0AN8R6uYFs5TyRGvckXwSifRy4JgLXbCoa4qA5vFYFE=
X-Received: by 2002:a9d:5e4:: with SMTP id 91mr1490121otd.95.1601473265040;
Wed, 30 Sep 2020 06:41:05 -0700 (PDT)
MIME-Version: 1.0
References: <20200925053702.80367-1-chenbo.xia@intel.com>
<20200930042328.22507-1-chenbo.xia@intel.com>
In-Reply-To: <20200930042328.22507-1-chenbo.xia@intel.com>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Wed, 30 Sep 2020 06:40:48 -0700
Message-ID: <CACZ4nhu0Jt=SZQ=1LxXbOq+Z9MOefhBdQy+5vZH5r8KhNqkUTA@mail.gmail.com>
To: Chenbo Xia <chenbo.xia@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, Somnath Kotur <somnath.kotur@broadcom.com>,
Qiming Yang <qiming.yang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
Rasesh Mody <rmody@marvell.com>, Shahed Shaikh <shshaikh@marvell.com>,
Shahaji Bhosle <sbhosle@broadcom.com>,
Kishore Padmanabha <kishore.padmanabha@broadcom.com>,
Michael Baucom <michael.baucom@broadcom.com>,
Venkat Duvvuru <venkatkumar.duvvuru@broadcom.com>,
Xiaoyun Li <xiaoyun.li@intel.com>,
Ferruh Yigit <ferruh.yigit@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
irusskikh@marvell.com,
Wenzhuo Lu <wenzhuo.lu@intel.com>, Beilei Xing <beilei.xing@intel.com>,
"Iremonger, Bernard" <bernard.iremonger@intel.com>, nikhil.rao@intel.com,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
Jerin Jacob <jerin.jacob@caviumnetworks.com>,
Marko Kovacevic <marko.kovacevic@intel.com>, Ori Kam <orika@nvidia.com>,
Bruce Richardson <bruce.richardson@intel.com>, radu.nicolau@intel.com,
Akhil Goyal <akhil.goyal@nxp.com>, tomasz.kantecki@intel.com, skori@marvell.com,
pbhagavatula@marvell.com, "Mcnamara, John" <john.mcnamara@intel.com>,
dpdk stable <stable@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v3 1/3] net: fix variable size of ethdev port
id
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, Sep 29, 2020 at 9:28 PM Chenbo Xia <chenbo.xia@intel.com> wrote:
>
> The ethdev port id should be 16 bits now. This patch changes the
> variable size of port id in some net drivers from 8 bits to 16
> bits.
>
> Fixes: 09b23f8b9df6 ("net/bnxt: fix port stop process and cleanup resources")
> Fixes: 769de16872ab ("net/bnxt: fix port default rule create/destroy")
> Fixes: 50370662b727 ("net/ice: support device and queue ops")
> Fixes: a50d7cbbdad7 ("net/qede: support registers dump")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chenbo Xia <chenbo.xia@intel.com>
For bnxt,
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> ---
> drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 2 +-
> drivers/net/bnxt/tf_ulp/ulp_def_rules.c | 6 +++---
> drivers/net/ice/ice_rxtx.h | 4 ++--
> drivers/net/qede/base/bcm_osal.h | 2 +-
> drivers/net/qede/qede_regs.c | 2 +-
> 5 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
> index e8927f629..3d148029e 100644
> --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
> +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
> @@ -646,7 +646,7 @@ static void
> bnxt_ulp_destroy_vfr_default_rules(struct bnxt *bp, bool global)
> {
> struct bnxt_ulp_vfr_rule_info *info;
> - uint8_t port_id;
> + uint16_t port_id;
> struct rte_eth_dev *vfr_eth_dev;
> struct bnxt_vf_representor *vfr_bp;
>
> diff --git a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> index 2d0c3bccc..fdd2692f6 100644
> --- a/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> +++ b/drivers/net/bnxt/tf_ulp/ulp_def_rules.c
> @@ -402,7 +402,7 @@ void
> bnxt_ulp_destroy_df_rules(struct bnxt *bp, bool global)
> {
> struct bnxt_ulp_df_rule_info *info;
> - uint8_t port_id;
> + uint16_t port_id;
>
> if (!BNXT_TRUFLOW_EN(bp) ||
> BNXT_ETH_DEV_IS_REPRESENTOR(bp->eth_dev))
> @@ -466,7 +466,7 @@ int32_t
> bnxt_ulp_create_df_rules(struct bnxt *bp)
> {
> struct bnxt_ulp_df_rule_info *info;
> - uint8_t port_id;
> + uint16_t port_id;
> int rc;
>
> if (!BNXT_TRUFLOW_EN(bp) ||
> @@ -540,7 +540,7 @@ bnxt_ulp_create_vfr_default_rules(struct rte_eth_dev *vfr_ethdev)
> struct rte_eth_dev *parent_dev = vfr->parent_dev;
> struct bnxt *bp = parent_dev->data->dev_private;
> uint16_t vfr_port_id = vfr_ethdev->data->port_id;
> - uint8_t port_id;
> + uint16_t port_id;
> int rc;
>
> if (!bp || !BNXT_TRUFLOW_EN(bp))
> diff --git a/drivers/net/ice/ice_rxtx.h b/drivers/net/ice/ice_rxtx.h
> index 9fa57b3b2..e4309b8b9 100644
> --- a/drivers/net/ice/ice_rxtx.h
> +++ b/drivers/net/ice/ice_rxtx.h
> @@ -68,7 +68,7 @@ struct ice_rx_queue {
> uint16_t rxrearm_start; /**< the idx we start the re-arming from */
> uint64_t mbuf_initializer; /**< value to init mbufs */
>
> - uint8_t port_id; /* device port ID */
> + uint16_t port_id; /* device port ID */
> uint8_t crc_len; /* 0 if CRC stripped, 4 otherwise */
> uint8_t fdir_enabled; /* 0 if FDIR disabled, 1 when enabled */
> uint16_t queue_id; /* RX queue index */
> @@ -112,7 +112,7 @@ struct ice_tx_queue {
> uint8_t pthresh; /**< Prefetch threshold register. */
> uint8_t hthresh; /**< Host threshold register. */
> uint8_t wthresh; /**< Write-back threshold reg. */
> - uint8_t port_id; /* Device port identifier. */
> + uint16_t port_id; /* Device port identifier. */
> uint16_t queue_id; /* TX queue index. */
> uint32_t q_teid; /* TX schedule node id. */
> uint16_t reg_idx;
> diff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm_osal.h
> index 5d4df5907..814000039 100644
> --- a/drivers/net/qede/base/bcm_osal.h
> +++ b/drivers/net/qede/base/bcm_osal.h
> @@ -372,7 +372,7 @@ void qede_hw_err_notify(struct ecore_hwfn *p_hwfn,
> /* TODO: */
> #define OSAL_SCHEDULE_RECOVERY_HANDLER(hwfn) nothing
>
> -int qede_save_fw_dump(uint8_t port_id);
> +int qede_save_fw_dump(uint16_t port_id);
>
> #define OSAL_SAVE_FW_DUMP(port_id) qede_save_fw_dump(port_id)
>
> diff --git a/drivers/net/qede/qede_regs.c b/drivers/net/qede/qede_regs.c
> index 1f2dbc6e7..d2ea1c910 100644
> --- a/drivers/net/qede/qede_regs.c
> +++ b/drivers/net/qede/qede_regs.c
> @@ -242,7 +242,7 @@ qede_write_fwdump(const char *dump_file, void *dump, size_t len)
> }
>
> int
> -qede_save_fw_dump(uint8_t port_id)
> +qede_save_fw_dump(uint16_t port_id)
> {
> struct rte_eth_dev *eth_dev = &rte_eth_devices[port_id];
> struct rte_dev_reg_info regs;
> --
> 2.17.1
>