From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DEFFA0C40; Wed, 28 Jul 2021 06:09:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4AC0B410F9; Wed, 28 Jul 2021 06:09:36 +0200 (CEST) Received: from mail-qv1-f51.google.com (mail-qv1-f51.google.com [209.85.219.51]) by mails.dpdk.org (Postfix) with ESMTP id 68E2D40E64 for ; Wed, 28 Jul 2021 06:09:34 +0200 (CEST) Received: by mail-qv1-f51.google.com with SMTP id g6so896267qvj.8 for ; Tue, 27 Jul 2021 21:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WF7zmWM0ws3mhbWuFdPOWlXDitsYFBdHcQ/hSWzDGpI=; b=WTdj61vHI2LovkPOdJ2CP7JsG65rR9m39r4inZLQ2RuQtBM398rAzGr64UdPCsaaR1 UlAQOpTDizjM+WKlE/SZ2y6h110nCYef0UUfI5BPh4U1kpq/GWx9EDOeTtcJ24/wXas6 1TUaLvWOgTNbcn9UKkq8VrlAXapHTxXaNonAs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WF7zmWM0ws3mhbWuFdPOWlXDitsYFBdHcQ/hSWzDGpI=; b=KixOkoHnjsPhda39hlxtZ7duPNv4ThmNHsChnlr/4rp9YNthEmBCxhlzWpW4k9/Dn6 B0awncTZfeyeD1mYBJ+I/zoXbhfnJThKy0HACoTt1jUpjhbKa9gnybzS0xfRXXaMWfvl Y7HdoQNWDtdoDgTk/nnzcZlbetIPeJg15A/FjnOK0q9x2ECRwKIa8sV/PQ16mkA1EiLj dx2Hh8B20QgY5QLveUnt4C0XK82sCor0bHwjiff0KTEgJ/ssevJwglgRLjqbqYj3/X6F lll3r+Z4jZ6+lDrQUSAVvznVLA8G29/Adhw+ujNu4yjUmStNnDbl4XQzY/koHzDb/Puv i8cA== X-Gm-Message-State: AOAM532G1QDaxMhACdKECqWvUnlnWsMNNBj3n+lHHp+jkIvVGOmaUngc 8fwq4rGkAacXrcFl3A9uBxuRLr5DfC8VmOD9nIqZbQ== X-Google-Smtp-Source: ABdhPJzBUQAqNXz2xtPhKCTktM+Cbt2aPmdZzDIQEpzlnKCZKiA1sHbzsdyFtas2U0QQ9lCaFOgg6YymSb6AbMbMT0A= X-Received: by 2002:ad4:5d6e:: with SMTP id fn14mr9881053qvb.35.1627445373694; Tue, 27 Jul 2021 21:09:33 -0700 (PDT) MIME-Version: 1.0 References: <20210719083309.15428-1-getelson@nvidia.com> <20210727130757.30724-1-getelson@nvidia.com> In-Reply-To: <20210727130757.30724-1-getelson@nvidia.com> From: Ajit Khaparde Date: Tue, 27 Jul 2021 21:09:17 -0700 Message-ID: To: Gregory Etelson Cc: dpdk-dev , Olivier Matz , Andrew Rybchenko , Ferruh Yigit , Thomas Monjalon , dpdk stable , Xiaoyun Li Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000068f62205c827277f" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix TX checksum calculation for tunnel X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000068f62205c827277f Content-Type: text/plain; charset="UTF-8" On Tue, Jul 27, 2021 at 6:08 AM Gregory Etelson wrote: > > TX checksum of a tunnelled packet can be calculated for outer headers > only or for both outer and inner parts. The calculation method is > determined by application. > If TX checksum calculation can be offloaded, hardware ignores > existing checksum value and replaces it with an updated result. > If TX checksum is calculated by a software, existing value must be > zeroed first. > The testpmd checksum forwarding engine always zeroed inner checksums. > If inner checksum calculation was offloaded, that header was left > with 0 checksum value. > Following outer software checksum calculation produced wrong value. > The patch zeroes inner IPv4 checksum only before software calculation. > > Fixes: 51f694dd40f5 ("app/testpmd: rework checksum forward engine") > Cc: stable@dpdk.org > > Signed-off-by: Gregory Etelson Acked-by: Ajit Khaparde --00000000000068f62205c827277f--