From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id 3E60E4CC5 for ; Mon, 5 Nov 2018 18:38:30 +0100 (CET) Received: by mail-ot1-f66.google.com with SMTP id 40so8545456oth.4 for ; Mon, 05 Nov 2018 09:38:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=D55aD36dNWaVCbcpEhDvuT4bGPfr3eU9fs/2Bbudkr0=; b=HryIGYOdPwQFnZ6N4kFfpcNOjAcGrUjC6icZ4X1l7+UmNtj2ivHH/kEYwqjir++P1P 23MB3PiiPQm3nxOKBMUSrAZQi5b5uGybDT/9CM5lutv464JAqY9dE6fioYxWRmOovARq 9GK4bIAz5/N0m7PUJJS6WPbZ0JHWIX9ais0Sw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=D55aD36dNWaVCbcpEhDvuT4bGPfr3eU9fs/2Bbudkr0=; b=Q7E2vhsUa+4YCRLQkzBzlbR7EW6B0hxUz5P2Bi7BOnNEb5MzkANQasYTLB7ROrfjG4 SIqY+UdDCoTi+IY/rI37SMqKNBYfPsvWOHNZpCGBztX092BtHsbXiHY7d/hVIvcNJvi0 JE45hMVyJ9e/jlACdpscrBxJrFjfLsesaL/Q1TMDYm5YQUeIygEscxMexwF7WOX1eL1Z Stf1to7yw8TNzXVt9HdZ7rDHunvjAOgoLGxBzHY6ALJkHZalLlJKmkesnGoWQhEsNWOX 3kCY4OhfIOWGjpiXGNE7wD2M72f1SkQz1Wqjk2/76jVchfxMC6xDbDZjqyxLh2SVoKJp p7eQ== X-Gm-Message-State: AGRZ1gItLVBnQD4lx0dMazwcrS6Z915gv97mOkiJaC0WeK++00JuE9bC FNvN/6d4vZbEsDG/0Ur8Fiz7aCVJwZ4YHd/5ymCIAg== X-Google-Smtp-Source: AJdET5eSfftFP9G/0VLqYAF4FbozdB2QOYBkzNGeOvmdJpw8+KEmPJwJbsiTyt0XaHAS6dCaSwwa6WdV8ihkFlruJYc= X-Received: by 2002:a9d:2ea9:: with SMTP id w38mr7420989ota.99.1541439509447; Mon, 05 Nov 2018 09:38:29 -0800 (PST) MIME-Version: 1.0 References: <20181028043542.87350-1-ferruh.yigit@intel.com> In-Reply-To: <20181028043542.87350-1-ferruh.yigit@intel.com> From: Ajit Khaparde Date: Mon, 5 Nov 2018 09:38:13 -0800 Message-ID: To: Ferruh Yigit Cc: Somnath Kotur , dev@dpdk.org, dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix uninitialized variable access X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Nov 2018 17:38:30 -0000 On Sat, Oct 27, 2018 at 8:36 PM Ferruh Yigit wrote: > ag_cons is used uninitialized, it is used when DEBUG enabled, remove > debug code. > > Fixes: 0958d8b6435d ("net/bnxt: support LRO") > Cc: stable@dpdk.org > > Signed-off-by: Ferruh Yigit > Acked-by: Ajit Khaparde We have not enabled this for debug for a while now. We can remove this. Thanks > --- > drivers/net/bnxt/bnxt_rxr.c | 24 ------------------------ > 1 file changed, 24 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index c7bc88481..1bfc63d93 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -102,25 +102,6 @@ static inline void bnxt_reuse_rx_mbuf(struct > bnxt_rx_ring_info *rxr, > rxr->rx_prod = prod; > } > > -#ifdef BNXT_DEBUG > -static void bnxt_reuse_ag_mbuf(struct bnxt_rx_ring_info *rxr, uint16_t > cons, > - struct rte_mbuf *mbuf) > -{ > - uint16_t prod = rxr->ag_prod; > - struct bnxt_sw_rx_bd *prod_rx_buf; > - struct rx_prod_pkt_bd *prod_bd, *cons_bd; > - > - prod_rx_buf = &rxr->ag_buf_ring[prod]; > - > - prod_rx_buf->mbuf = mbuf; > - > - prod_bd = &rxr->ag_desc_ring[prod]; > - cons_bd = &rxr->ag_desc_ring[cons]; > - > - prod_bd->address = cons_bd->addr; > -} > -#endif > - > static inline > struct rte_mbuf *bnxt_consume_rx_buf(struct bnxt_rx_ring_info *rxr, > uint16_t cons) > @@ -377,9 +358,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, > uint32_t tmp_raw_cons = *raw_cons; > uint16_t cons, prod, cp_cons = > RING_CMP(cpr->cp_ring_struct, tmp_raw_cons); > -#ifdef BNXT_DEBUG > - uint16_t ag_cons; > -#endif > struct rte_mbuf *mbuf; > int rc = 0; > uint8_t agg_buf = 0; > @@ -482,8 +460,6 @@ static int bnxt_rx_pkt(struct rte_mbuf **rx_pkt, > if (rxcmp1->errors_v2 & RX_CMP_L2_ERRORS) { > /* Re-install the mbuf back to the rx ring */ > bnxt_reuse_rx_mbuf(rxr, cons, mbuf); > - if (agg_buf) > - bnxt_reuse_ag_mbuf(rxr, ag_cons, mbuf); > > rc = -EIO; > goto next_rx; > -- > 2.17.2 > >