From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f196.google.com (mail-qk0-f196.google.com [209.85.220.196]) by dpdk.org (Postfix) with ESMTP id 9921DA49C for ; Wed, 21 Mar 2018 20:28:00 +0100 (CET) Received: by mail-qk0-f196.google.com with SMTP id z184so6718788qkc.1 for ; Wed, 21 Mar 2018 12:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZFYGYlYCQWsmv3QbmFXbh24aDcsB9hMhHq5jBJpgdt4=; b=UzAGoWKmVjnR+LdzbZh1QPV67Kti7sBzYw02Q+TnVJijVA8Xd2MrOzmcgjQcevaJ3a sMZKAGkJ8MiORE4EcP+LIyYvhrcVAxJtQSRe8lDrqPpP1w6ou9bHOU/mNuPPdrma2xb1 Po/gpfpOylD0ReIPO1MkXXOZ7IWpFz+WL8nEE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZFYGYlYCQWsmv3QbmFXbh24aDcsB9hMhHq5jBJpgdt4=; b=IS7vpnjcIchb6FD8XcszbadrQIWkMOIhh6rHNaHZnk92enBmJoIXj7cCBL0fws+lUg AhKiX7vzsKbB1GTttKVMnF5smbtlA1wjMluv/N83oFmnOQ/HvtwOSHynyNwJ50hO3XqR WecXQfvtPfKYBMrfluGwP9+4OE8ad5SzihhVfTETqMRpp+FGv9u4rJTVdreWxRXXvQ2g 4lR0GYNOcdv8JpEuoKVHslYF22/HCEWjnWSxd5MLmp8T+55Ullg4FcUJGNlrgly+hS7v sGAe4ht9jzvF7XUjAUi1AOWSV0wmF4b7picFh1dK8uNEOqJ7VsvzGtWqrMFyJQZA7pVy /zTA== X-Gm-Message-State: AElRT7FhO60RLLW/Rr03VqCoz3rxe3PD353LaMo8eYVztuXp3uZI2NSf RFh+C22AFhVSNMPhU2SZtyuWLsmGtWnha2gNwXcqDw== X-Google-Smtp-Source: AG47ELvv5zmw8zFudXfvUFhAUN1gQNtqKJmnWjHySBWieRHSM7akaKaZIkfEd0ZIYrv42RvvK7UIXC33z5W+khzs7Cs= X-Received: by 10.55.16.4 with SMTP id a4mr29341367qkh.288.1521660480087; Wed, 21 Mar 2018 12:28:00 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.58.134 with HTTP; Wed, 21 Mar 2018 12:27:19 -0700 (PDT) In-Reply-To: References: <20180306194020.71231-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Wed, 21 Mar 2018 12:27:19 -0700 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Shahaf Shuler Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: switch to the new offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 19:28:01 -0000 Hi Shahaf, Well, the application could. While we can't ignore the advantages of enabling the offloads. I felt if we should really mandate applications to request all the supported offloads? Thanks Ajit On Wed, Mar 21, 2018 at 12:08 PM, Ferruh Yigit wrote: > On 3/6/2018 7:40 PM, Ajit Khaparde wrote: > > Update bnxt PMD to new ethdev offloads API. > > Signed-off-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_ethdev.c | 59 +++++++++++++++++++++++++++++- > ------------ > > 1 file changed, 41 insertions(+), 18 deletions(-) > > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ > ethdev.c > > index 21c46f833..cca4ef40c 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -146,6 +146,27 @@ static const struct rte_pci_id bnxt_pci_id_map[] = { > > ETH_RSS_NONFRAG_IPV6_TCP | \ > > ETH_RSS_NONFRAG_IPV6_UDP) > > > > +#define BNXT_DEV_TX_OFFLOAD_SUPPORT (DEV_TX_OFFLOAD_VLAN_INSERT | \ > > + DEV_TX_OFFLOAD_IPV4_CKSUM | \ > > + DEV_TX_OFFLOAD_TCP_CKSUM | \ > > + DEV_TX_OFFLOAD_UDP_CKSUM | \ > > + DEV_TX_OFFLOAD_TCP_TSO | \ > > + DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | \ > > + DEV_TX_OFFLOAD_VXLAN_TNL_TSO | \ > > + DEV_TX_OFFLOAD_GRE_TNL_TSO | \ > > + DEV_TX_OFFLOAD_IPIP_TNL_TSO | \ > > + DEV_TX_OFFLOAD_GENEVE_TNL_TSO | \ > > + DEV_TX_OFFLOAD_MULTI_SEGS) > > + > > +#define BNXT_DEV_RX_OFFLOAD_SUPPORT (DEV_RX_OFFLOAD_VLAN_FILTER | \ > > + DEV_RX_OFFLOAD_VLAN_STRIP | \ > > + DEV_RX_OFFLOAD_IPV4_CKSUM | \ > > + DEV_RX_OFFLOAD_UDP_CKSUM | \ > > + DEV_RX_OFFLOAD_TCP_CKSUM | \ > > + DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM | \ > > + DEV_RX_OFFLOAD_JUMBO_FRAME | \ > > + DEV_RX_OFFLOAD_CRC_STRIP) > > + > > static int bnxt_vlan_offload_set_op(struct rte_eth_dev *dev, int mask); > > static void bnxt_print_link_info(struct rte_eth_dev *eth_dev); > > > > @@ -430,21 +451,14 @@ static void bnxt_dev_info_get_op(struct > rte_eth_dev *eth_dev, > > dev_info->min_rx_bufsize = 1; > > dev_info->max_rx_pktlen = BNXT_MAX_MTU + ETHER_HDR_LEN + > ETHER_CRC_LEN > > + VLAN_TAG_SIZE; > > - dev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP | > > - DEV_RX_OFFLOAD_IPV4_CKSUM | > > - DEV_RX_OFFLOAD_UDP_CKSUM | > > - DEV_RX_OFFLOAD_TCP_CKSUM | > > - DEV_RX_OFFLOAD_OUTER_IPV4_CKSUM; > > - dev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT | > > - DEV_TX_OFFLOAD_IPV4_CKSUM | > > - DEV_TX_OFFLOAD_TCP_CKSUM | > > - DEV_TX_OFFLOAD_UDP_CKSUM | > > - DEV_TX_OFFLOAD_TCP_TSO | > > - DEV_TX_OFFLOAD_OUTER_IPV4_CKSUM | > > - DEV_TX_OFFLOAD_VXLAN_TNL_TSO | > > - DEV_TX_OFFLOAD_GRE_TNL_TSO | > > - DEV_TX_OFFLOAD_IPIP_TNL_TSO | > > - DEV_TX_OFFLOAD_GENEVE_TNL_TSO; > > + > > + dev_info->rx_queue_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT; > > Hi Ajit, > > Is bnxt supports queue level offloads? If not PMD should return 0 as > rx_queue_offload_capa and tx_queue_offload_capa. > > > + dev_info->rx_offload_capa = BNXT_DEV_RX_OFFLOAD_SUPPORT; > > + if (bp->flags & BNXT_FLAG_PTP_SUPPORTED) > > + dev_info->rx_offload_capa |= DEV_RX_OFFLOAD_TIMESTAMP; > > + dev_info->tx_queue_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT; > > + dev_info->tx_offload_capa = BNXT_DEV_TX_OFFLOAD_SUPPORT; > > + dev_info->flow_type_rss_offloads = BNXT_ETH_RSS_SUPPORT; > > > > /* *INDENT-OFF* */ > > dev_info->default_rxconf = (struct rte_eth_rxconf) { > > @@ -454,7 +468,8 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev > *eth_dev, > > .wthresh = 0, > > }, > > .rx_free_thresh = 32, > > - .rx_drop_en = 0, > > + /* If no descriptors available, pkts are dropped by > default */ > > + .rx_drop_en = 1, > > }; > > > > dev_info->default_txconf = (struct rte_eth_txconf) { > > @@ -465,8 +480,6 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev > *eth_dev, > > }, > > .tx_free_thresh = 32, > > .tx_rs_thresh = 32, > > - .txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | > > - ETH_TXQ_FLAGS_NOOFFLOADS, > > }; > > eth_dev->data->dev_conf.intr_conf.lsc = 1; > > > > @@ -510,6 +523,16 @@ static void bnxt_dev_info_get_op(struct rte_eth_dev > *eth_dev, > > static int bnxt_dev_configure_op(struct rte_eth_dev *eth_dev) > > { > > struct bnxt *bp = (struct bnxt *)eth_dev->data->dev_private; > > + uint64_t tx_offloads = eth_dev->data->dev_conf.txmode.offloads; > > + uint64_t rx_offloads = eth_dev->data->dev_conf.rxmode.offloads; > > + > > + if (tx_offloads != BNXT_DEV_TX_OFFLOAD_SUPPORT) > > + PMD_DRV_LOG(ERR, "Tx offloads requested 0x%lx supported > 0x%x\n", > > + tx_offloads, BNXT_DEV_TX_OFFLOAD_SUPPORT); > > Isn't is possible that application request only a subset of the supported > offloads? > > And should API return an error for this case? > > > + > > + if (rx_offloads != BNXT_DEV_RX_OFFLOAD_SUPPORT) > > + PMD_DRV_LOG(ERR, "Rx offloads requested 0x%lx supported > 0x%x\n", > > + rx_offloads, BNXT_DEV_RX_OFFLOAD_SUPPORT); > > > > bp->rx_queues = (void *)eth_dev->data->rx_queues; > > bp->tx_queues = (void *)eth_dev->data->tx_queues; > > > >