From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f173.google.com (mail-qt0-f173.google.com [209.85.216.173]) by dpdk.org (Postfix) with ESMTP id 8ED2B1B36F for ; Fri, 26 Jan 2018 18:34:27 +0100 (CET) Received: by mail-qt0-f173.google.com with SMTP id f4so3150859qtj.6 for ; Fri, 26 Jan 2018 09:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=22moMTLQ3JzOgO6YOLq7ULpHaH97Tietyqfy8TUqagg=; b=MhJm3KqUN7RXJpidCZpQT0cIm/lOYFL85DbqtY7wdfy0fHPRgT+ae/Il5ilNIVzSeY jhd3DBrLeolo+jyCqby8zQ8cmjORQ141Ows2atd7KQtt4p3kflBhcH9bPZISqoqeuevr OGbPIkjGZBwjSSKq11DDVRo2wGrwFsGaL4J4U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=22moMTLQ3JzOgO6YOLq7ULpHaH97Tietyqfy8TUqagg=; b=FSOSFI1t7sHMiI2xmISDGJBCxfijeFdXrwNE0Gnl89F+T9yShjSrK1wUAGR5FTPxrK 3Cz1QHaqBKOWwbDWUs8WOKPNQqhdeaUh4jnbuI/wBbmokaFDjdd3ciIZVPT9IKIvBUdV vQ/BOnuJhyF7+Bm8IdhJWHfASugl0nDxKTCkLrzOLRE0Rcg9sfeYnXOFd41TBCO7RmMz KBwer62K39IUucZwzEbBwe6XW65ezCEjGdRT5rcA6VDD3tt6GoOsO8pfc/RdjidXT0jo 66p8CRNoY1cmjg+Crz9Le/4NimltQzTk1hLIyhGCTJyzuG04WuTGFCrqcYATJ2w2V9YK qqAw== X-Gm-Message-State: AKwxytfxJEKf977Vgvu/XzwP0xToihD97gSPmZ+j0KP2i7gooaCH0Tz5 tghxLeI6cvkkM2wmirb0An0zsE5gFEUAZlKhRdpS9Q== X-Google-Smtp-Source: AH8x227w80TXifY+LBy9FGjgGtwQPCcMc2TjcaLIK/qKrJvaL4OANRurCmuLQdUJgjUSpe0psp32yiwVLGpF0YlxnMk= X-Received: by 10.237.53.45 with SMTP id a42mr24930906qte.96.1516988066954; Fri, 26 Jan 2018 09:34:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.237.45.197 with HTTP; Fri, 26 Jan 2018 09:33:45 -0800 (PST) In-Reply-To: References: <4e127fe7-7351-31b5-40d4-37d850c5fb12@intel.com> <20180125224757.82325-1-ajit.khaparde@broadcom.com> <20180125224757.82325-7-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Fri, 26 Jan 2018 09:33:45 -0800 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 6/7] net/bnxt: add 100G speed detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jan 2018 17:34:27 -0000 On Fri, Jan 26, 2018 at 9:08 AM, Ferruh Yigit wrote: > On 1/25/2018 10:47 PM, Ajit Khaparde wrote: > > When the driver is loaded on a 100G NIC, the port speed is not > > displayed correctly. Parse the 100G speed before displaying it. > > > > Signed-off-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_hwrm.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.= c > > index 8fac05251..d412e51fc 100644 > > --- a/drivers/net/bnxt/bnxt_hwrm.c > > +++ b/drivers/net/bnxt/bnxt_hwrm.c > > @@ -2139,6 +2139,8 @@ static uint32_t bnxt_parse_hw_link_speed(uint16_t > hw_link_speed) > > break; > > case HWRM_PORT_PHY_QCFG_OUTPUT_LINK_SPEED_50GB: > > eth_link_speed =3D ETH_SPEED_NUM_50G; > > This case doesn't have a "break" statement, which looks like > unintentional, but > if it is intentional please put /* Fallthrough */ comment to prevent buil= d > error > [1]. > =E2=80=8BNo. Its unintentional. I copy pasted those lines from the test set= up and =E2=80=8Bmissed it. I am sending a fresh set. =E2=80=8BThanks=E2=80=8B > > [1] > ...dpdk/drivers/net/bnxt/bnxt_hwrm.c: In function > =E2=80=98bnxt_parse_hw_link_speed=E2=80=99: > ...dpdk/drivers/net/bnxt/bnxt_hwrm.c:2141:18: error: this statement may > fall > through [-Werror=3Dimplicit-fallthrough=3D] > eth_link_speed =3D ETH_SPEED_NUM_50G; > ...dpdk/drivers/net/bnxt/bnxt_hwrm.c:2142:2: note: here > case HWRM_PORT_PHY_QCFG_OUTPUT_LINK_SPEED_100GB: > ^~~~ > > > + case HWRM_PORT_PHY_QCFG_OUTPUT_LINK_SPEED_100GB: > > + eth_link_speed =3D ETH_SPEED_NUM_100G; > > break; > > case HWRM_PORT_PHY_QCFG_OUTPUT_LINK_SPEED_2GB: > > default: > > > >