From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E29B4A0562; Fri, 19 Mar 2021 01:06:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B3CB140FB0; Fri, 19 Mar 2021 01:06:03 +0100 (CET) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id D92B34003F for ; Fri, 19 Mar 2021 01:06:01 +0100 (CET) Received: by mail-qk1-f173.google.com with SMTP id y18so1194794qky.11 for ; Thu, 18 Mar 2021 17:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dgHk5pPYt7dGmIxkMFTL+MZ523Ts3ksJvXBLCcoONsw=; b=Lx9pEciVuAYDFIRWJZ4Rv0xqHHmdVob8FgpjTZopVrKudcCei6xm/CPfBMPyXrKRVS +AXCY9iEJomYOrk2N5YsfsD90tjJLubq8wF3CCB2jHA3oAiVoHjx+bWm5C3ddZUKmZpj tqg7FMFyVHN5mRh4MHaAqDZOhP1jpefx2Jv1s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dgHk5pPYt7dGmIxkMFTL+MZ523Ts3ksJvXBLCcoONsw=; b=lccGX1MqHYtMQ1YRXRu82/WzKRT9La3cTlSMJsVO68Ttczl/30Pgoz3SObqaMHA1sF fyU+k3jedHkpUppekejXR/g+H+pO0Lnzus7aDqVkO9bnfpu4fPmC7uGtnzsYA3/fTwqH fMG14B5uDWOHGYjL/N807HvkfL7sJY+Gi2CZMRcU9ToUtHBKhI9J+GROpRzDja7w6zYd 5u4x5OMjnpml6+z8rECtrMev6QUYMEZFAAFBgwvT6nLwy5FBRYJhMhB7k9/yp+QiwiKP x+iByB0G/jxh5bXwjzIIh/vvdV+NDiSYnF6+cRL9H2TICxCVkgaR5NfSChiu2Y9M6IjQ k71g== X-Gm-Message-State: AOAM532L+4HtydoBwG4pWlcZRVYO46uFr4aL9htuCNRZ4KSxCWvJdHzr 8kOYd4KUpvI2zcIyPBZCcCXQ9UwE/nNs9mzga8S4Dd1Nfqxa1Zm/ X-Google-Smtp-Source: ABdhPJzxYmxnFDrsOpK2t5GbUHF//KtuEaH9opoLVUeDK1pq2RqSIdXOfnBkzH/rpxs4JfOqQzocmjH1FqWbr84Ex+M= X-Received: by 2002:a37:43cc:: with SMTP id q195mr7151650qka.455.1616112360704; Thu, 18 Mar 2021 17:06:00 -0700 (PDT) MIME-Version: 1.0 References: <20210318004730.24360-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210318004730.24360-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Thu, 18 Mar 2021 17:05:44 -0700 Message-ID: To: dpdk-dev Cc: dpdk stable Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000033a00305bdd87b0e" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS context cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000033a00305bdd87b0e Content-Type: text/plain; charset="UTF-8" On Wed, Mar 17, 2021 at 5:47 PM Ajit Khaparde wrote: > > The PMD is allocating an extra RSS context with each port start. > But it is freeing only one RSS context during port stop. So at some point > we run out of RSS contexts when we do multiple port stop/start sequences. > bnxt_hwrm_vnic_ctx_alloc() is called by bnxt_setup_one_vnic(), but > bnxt_hwrm_vnic_ctx_free() is not called in the corresponding > bnxt_free_one_vnic(). > > Fix this by calling bnxt_hwrm_vnic_ctx_free() in bnxt_free_one_vnic(). > > Fixes: 7fe5668d2ea3 ("net/bnxt: support VLAN filter and strip") > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 1997783a7d..ff92f999db 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -2531,6 +2531,10 @@ static int bnxt_free_one_vnic(struct bnxt *bp, uint16_t vnic_id) > } > bnxt_del_dflt_mac_filter(bp, vnic); > > + rc = bnxt_hwrm_vnic_ctx_free(bp, vnic); > + if (rc) > + return rc; > + > rc = bnxt_hwrm_vnic_free(bp, vnic); > if (rc) > return rc; > -- > 2.21.1 (Apple Git-122.3) > --00000000000033a00305bdd87b0e--