From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 587B3A0C4A; Tue, 13 Jul 2021 06:23:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AB5F1411CC; Tue, 13 Jul 2021 06:23:00 +0200 (CEST) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by mails.dpdk.org (Postfix) with ESMTP id 76C774069E for ; Tue, 13 Jul 2021 06:22:59 +0200 (CEST) Received: by mail-qt1-f181.google.com with SMTP id c9so11605073qte.6 for ; Mon, 12 Jul 2021 21:22:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ehIsZUbi34FDpoHhqNxznhzX1dDZa/gNZAQjbUMjxJA=; b=ewkrKKNOgKw9oqa96+S0MRENDrijXuu8OsKmQAEyWGgIMMjWBPzX5jR+xJBeu6FgxH pR/818SZswkVhLne/JKsAze5UiioVBEEI2hEwsKJitBerfonnWRd7YOHkGScn/DPh4Rx HqU6+pMCqJkBsfDFFZIxa+Uu0kcYLOFyP5dvI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ehIsZUbi34FDpoHhqNxznhzX1dDZa/gNZAQjbUMjxJA=; b=ZWwraT6aZly+U5DTa2P9hCGvKYNYJBsf5EbC++sFoMHOy4vD+0cZ9l/7ZDZFrODjlO uyzuIxyYdxTq22IqJStgaO6Q6eqmYYhvEFx2e8rLHbjCYPKDgLpfsA7G3D+iX0JXAGen 1ZCLJRattxy9XQVxP1ftsMrMuTjoNHuo36DccHPnWVfGRCwFjJhVhTT2IeMBDWeOljpd 98iFMGMbkagVNarb9oJlAgsmn+9FzQZgq41lv22/M7giHDYTTamF9ocsQagUMeZNW0EU WG4DgxAzx3LnEp9N8ZOAlYUYAZGbUy+L7gpgVpcCQ5Usr/Y8jmYh1YsDDXxtYUbbNRQ/ 6qfw== X-Gm-Message-State: AOAM5335R0PuDnzzW2yhzRYuIc++SwAgzy27OStggTRxqA5bN7JvXn05 QmnCDjtVhA6oZU+HaZzilCd2Th9D95K2hvn9PVf85g== X-Google-Smtp-Source: ABdhPJwsPQX+jl4bOXAGPx0cfjzgxTBdU+oOMsMx/J5MfRn3h2M7DnUhvPCzhrGDl38UBvYgHhc/gcZ5i4O8iXxKZHM= X-Received: by 2002:ac8:7f53:: with SMTP id g19mr2147765qtk.225.1626150178568; Mon, 12 Jul 2021 21:22:58 -0700 (PDT) MIME-Version: 1.0 References: <1625306220-1268-1-git-send-email-liweifeng96@126.com> <1625307642-1360-1-git-send-email-liweifeng96@126.com> In-Reply-To: <1625307642-1360-1-git-send-email-liweifeng96@126.com> From: Ajit Khaparde Date: Mon, 12 Jul 2021 21:22:41 -0700 Message-ID: To: Weifeng Li Cc: Somnath Kotur , dpdk-dev , dpdk stable Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000c5d2c605c6f997db" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: fix nested lock at bond mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000c5d2c605c6f997db Content-Type: text/plain; charset="UTF-8" On Sat, Jul 3, 2021 at 3:21 AM Weifeng Li wrote: > Bnxt register lsc callback (bond_ethdev_lsc_event_callback) when > working at bond mode. This callback will dead lock when lsc > interrupt triggered. > > lsc interrupt -> > bnxt_handle_async_event -> > bnxt_link_update_op -> > bond_ethdev_lsc_event_callback (lsc_lock) -> > bnxt_link_update_op -> > bond_ethdev_lsc_event_callback (lsc_lock dead lock) > > Fixes: c2faa1d1969e ("net/bnxt: add support for LSC interrupt event") > Cc: stable@dpdk.org > > Signed-off-by: Weifeng Li > Reviewed-by: Ajit Khaparde Updated the commit headline to "fix nested lock during bonding" during merge. Patch applied to dpdk-next-net-brcm. Thanks > --- > v2: fix coding style issues > --- > drivers/net/bnxt/bnxt_cpr.c | 2 ++ > drivers/net/bnxt/bnxt_ethdev.c | 5 ----- > 2 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c > index 2c7fd78..f4c9c72 100644 > --- a/drivers/net/bnxt/bnxt_cpr.c > +++ b/drivers/net/bnxt/bnxt_cpr.c > @@ -111,6 +111,8 @@ void bnxt_handle_async_event(struct bnxt *bp, > case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_LINK_SPEED_CFG_CHANGE: > /* FALLTHROUGH */ > bnxt_link_update_op(bp->eth_dev, 0); > + rte_eth_dev_callback_process(bp->eth_dev, > + RTE_ETH_EVENT_INTR_LSC, NULL); > break; > case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_PF_DRVR_UNLOAD: > PMD_DRV_LOG(INFO, "Async event: PF driver unloaded\n"); > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index 495c6cd..619b7b8 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1844,11 +1844,6 @@ int bnxt_link_update_op(struct rte_eth_dev > *eth_dev, int wait_to_complete) > if (new.link_status != eth_dev->data->dev_link.link_status || > new.link_speed != eth_dev->data->dev_link.link_speed) { > rte_eth_linkstatus_set(eth_dev, &new); > - > - rte_eth_dev_callback_process(eth_dev, > - RTE_ETH_EVENT_INTR_LSC, > - NULL); > - > bnxt_print_link_info(eth_dev); > } > > -- > 1.8.3.1 > > --000000000000c5d2c605c6f997db--