From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED08A0C55; Wed, 13 Oct 2021 23:35:34 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F1925410DB; Wed, 13 Oct 2021 23:35:33 +0200 (CEST) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mails.dpdk.org (Postfix) with ESMTP id B156940E50 for ; Wed, 13 Oct 2021 23:35:32 +0200 (CEST) Received: by mail-io1-f46.google.com with SMTP id i189so1396799ioa.1 for ; Wed, 13 Oct 2021 14:35:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JiaTBSoZqHnTSUASYivYYM5edFu6tgVXHtNWEAJKcds=; b=gesItyOS3jvInEMjVhoXPpDZIy/u/yneMEOzW9QNZjLb8tWEYFFDiO139DKsLDNgW5 MKV6lO2uKnXT+8LMU9lfc2MqaaS4YWGSQBrf8XAxM+SNtrkq4VT0r2Yp4zNFwRkSaMgv Gl9LpRNMg45Dy2bZ3fzjQGXx0Gj4AgFvgI85Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JiaTBSoZqHnTSUASYivYYM5edFu6tgVXHtNWEAJKcds=; b=56epcXHHRq3uugJcSxapObZpsjNh/HfBp6EcVFEa7BHVXhOg2cVtZX0bMusWtbx3Sn MUmIZu9carUfjQO+FXX6YajfQFFLFsCCTuQhafx0vyJUuOSPNGiwPPj+2A4PqJnhWbZn WqCEbaun9416kNrd45oV3FF5EgBeCeRdHynom6ijOtvi8FUZxllFfU+u3jCZmnneCp/4 ZHw2MdnlPdcy8Eu6QwhQ9+XByFBuIhMjZPOgjSUXw/2Z98mi56nNKYyGAknLzIaA6Jkq YC+snYZvJIbET/Ao3zwxKxXgTJMvjzeCmtdWpF2ms6hRykGsMkgx9vwZBu05HShENliB 95pA== X-Gm-Message-State: AOAM5330IgXErhXkT3b0psugRQ4i6D0DU9rGM/OkDbgTCsYAmLwzq/N1 hH84a/4PaX9xbcwRNdefVNLWAxYFQWRPeLUbsCeE+Q== X-Google-Smtp-Source: ABdhPJxMavD2kZbyMv8cC9sXjV+VD14WSfskIiRAUk9obv3nRE/OQOLWUD0MJSbi/uXfvFsjlIdvgklAVOdo01TC4jo= X-Received: by 2002:a05:6638:41a2:: with SMTP id az34mr1340275jab.4.1634160931980; Wed, 13 Oct 2021 14:35:31 -0700 (PDT) MIME-Version: 1.0 References: <20211013163101.2811453-1-ferruh.yigit@intel.com> In-Reply-To: From: Ajit Khaparde Date: Wed, 13 Oct 2021 14:35:15 -0700 Message-ID: To: Ferruh Yigit Cc: Somnath Kotur , dpdk-dev Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000dff1cd05ce42bd6f" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove debug macro breaking build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000dff1cd05ce42bd6f Content-Type: text/plain; charset="UTF-8" On Wed, Oct 13, 2021 at 12:23 PM Ferruh Yigit wrote: > > On 10/13/2021 6:34 PM, Ajit Khaparde wrote: > > On Wed, Oct 13, 2021 at 9:31 AM Ferruh Yigit wrote: > >> > >> Setting 'RTE_LIBRTE_BNXT_TRUFLOW_DEBUG' macro cause build error, > >> removing it. > >> > >> Also with meson build system compile time debug macros should be > >> documented in driver documentation, since there is not other way to > > s/not/no > > > >> figure out their existence. > >> > >> Signed-off-by: Ferruh Yigit > > With thanks and above nit, :-) > > > > Reviewed-by: Ajit Khaparde > > > > Other option is to fix the build error when macro is set, would you like > to go with that option? No. There is more that we would like to add if we want to add debug capability. Currently what you are trying to remove is a bit half baked which should not have sneaked in. So removing it for now is perfectly fine. > > And can you please send a separate patch to document the remaining > compile time macros in the driver guide? Sure. I will go through the code and take care of that. --000000000000dff1cd05ce42bd6f--