From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 712F6A0353; Thu, 6 Aug 2020 17:50:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5C2712C28; Thu, 6 Aug 2020 17:50:32 +0200 (CEST) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id 3EF7D2B87 for ; Thu, 6 Aug 2020 17:50:30 +0200 (CEST) Received: by mail-ot1-f66.google.com with SMTP id v21so29244546otj.9 for ; Thu, 06 Aug 2020 08:50:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zOGTZ/Rgvjo5Vtyjg3mztMhCLn4jk31Hx9hnD1XGLuA=; b=gxSmwZJyK/6ooDWnvmnmArJq84Fa05vLcFEokUODmueTJY7owxfNYPFvtUH5Qqf3ID 9uVkDVNH3HD/Lo2hZTjYyrm0DiBHlzPgdxXzvdLLYhZqiTfBpQkjWIcmfuvbszEKOhUp 3sQ6pROs+YicAE2g0Yl4YOUcvrCzz1ZVkZNSI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zOGTZ/Rgvjo5Vtyjg3mztMhCLn4jk31Hx9hnD1XGLuA=; b=R/9D77JkFTY/lDEo+s/nOGqn5e/MAkiEWom7neEFjmNetIxXJe3oYemvHqwEAZgOBO gj9OFmryUrzlAkEX4t31SvaJDG1qNqArU22vtlp6GuJEjKfBRsRjkcjOD/PKYFv8yldr yJQOANirq9sSA/2Qmq+YQzHs/Gkuzkr78pGE20U6GPoa/8eyLaZxrro3rg/XtBzAI43W //AP8r7Rb6Lov/sPUdvySpl3ELjEcjEgCAseIHCPCsZSs5dYp0L8vUBmqcbPucRcFyAc pDSsVqeGR4JCMa3g5eSLUfnzGBw4kXi6kKQy+yzuSro0UoZIrq6gfBxLx6gtXxfhPaYD iotw== X-Gm-Message-State: AOAM531WjdmB2d2rlb905ZiQ+Yl30EP4XKlXdkotRMxr8I30kJGG326O cAfjM7UfgOsTmnuOK2hfieSxK9JkmjI8HvKET5NLtA== X-Google-Smtp-Source: ABdhPJxtocAjGQ59ESrkZ8zu9FHLW4E4e3uESNJB+7qHgYlskXKNsFml8S3V2/fPDnDQwtC4J2J6vYEHZ+/V+SHjBhM= X-Received: by 2002:a9d:8c9:: with SMTP id 67mr8380388otf.154.1596729029393; Thu, 06 Aug 2020 08:50:29 -0700 (PDT) MIME-Version: 1.0 References: <50e5d2139368c54b414379b18a59ed46c12893f5.1596556981.git.dekelp@mellanox.com> <2923630.3o79E1KD6h@thomas> In-Reply-To: From: Ajit Khaparde Date: Thu, 6 Aug 2020 08:50:13 -0700 Message-ID: To: Andrew Rybchenko Cc: Thomas Monjalon , Dekel Peled , dpdk-dev , Jerin Jacob , Stephen Hemminger , maxime.coquelin@redhat.com, Olivier Matz , David Marchand , Ferruh Yigit , Asaf Penso Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] doc: announce change in ETH and VLAN item structs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Aug 6, 2020 at 8:14 AM Andrew Rybchenko wrote: > On 8/6/20 3:25 PM, Thomas Monjalon wrote: > > 06/08/2020 12:45, Dekel Peled: > >> Structs rte_flow_item_eth and rte_flow_item_vlan will be modified, > >> to include an additional value, indicating existence or absence of VLAN > >> headers following the current header, as proposed in RFC > >> https://mails.dpdk.org/archives/dev/2020-August/177536.html. > >> Because of ABI break this change is proposed for 20.11. > >> > >> Signed-off-by: Dekel Peled > >> --- > >> +* ethdev: The ``struct rte_flow_item_eth`` and ``struct > rte_flow_item_vlan`` > >> + structs will be modified, to include an additional value, indicating > existence > >> + or absence of a VLAN header following the current header, as > proposed in RFC > >> + https://mails.dpdk.org/archives/dev/2020-August/177536.html. > > Specifying match patterns on none or multiple extensions > > is difficult to manage with rte_flow. > > It seems this approach of adding explicit fields in the items > > can work well. > > > > Acked-by: Thomas Monjalon > > Similar to IPv6, it looks required to add extra information to ETH (and may > be VLAN) item, but I'm not sure that proposed solution is 100% OK. > Anyway, the scope of the deprecation notice is ongoing changes, so: > > Acked-by: Andrew Rybchenko > Acked-by: Ajit Khaparde