From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 858AF41DEE; Mon, 6 Mar 2023 03:47:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1A04240ED6; Mon, 6 Mar 2023 03:47:35 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id D6B9840E03 for ; Mon, 6 Mar 2023 03:47:33 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id d10so4644295pgt.12 for ; Sun, 05 Mar 2023 18:47:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1678070853; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=egIQmumVCSrHvibSGwfrAhgIiPobLC+cY88UEJ3hk+g=; b=XFNtZ+jZ1WJqsPg5bjwflvsMgxFV68oskDbhuf2upekByCA1yFjRtt/qLf4EM+kHzj UYoqFqX+bJkshJS/rn72dref7q0jsOhkluS3YCVkMEWpEaaH/Ialb/j9R8FVcEhq0bCl WMdgJeVb8ax9qeVLjz3DosvcrA6oYTEIsGZ78= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678070853; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=egIQmumVCSrHvibSGwfrAhgIiPobLC+cY88UEJ3hk+g=; b=AYanaQzvYLIx8wLc59Bcf7nFERcTcef2EKewG3afgvTjUUIUlCg9N8uawvrJkGociE IO0YCC9HVm0yS8+dgizt74h4B3t0bOgNbDKhWGANk5ag7ljm7CKNU/xtVidlG9OAGeE4 zFv9EHSRGh0253PoW79r3kwNt3F/fNoNQA2WkkMw7V8V3lCrKxAfjfKgXFUj0RbeWFLM 9tfb45sc2ReXKVZHGy5Jv/qZOuR9edLM6X/SwAOiDFOtrAO2fglqz4Xa5+x1TQY8/LQ/ TxU0KsiFjJgNUL+EOLUSyDw9euS0jn4FrHLcS7bzNTWj/TcznTaVQN8igtOs+tCKaTKY pJVw== X-Gm-Message-State: AO0yUKU/RAWFndMEMOOM/YstzA7HqbWH7INGxzURoWY4N1uIzqrH+VE9 mMPLfl2YF+1hJKVr7UGseldeCxp8BqgzO9sTBDEtlQ== X-Google-Smtp-Source: AK7set9k33LUL79rF3pA18DkzM901e3+Ab/A+ICYK03fQjVwBRvPuaBegqwsMOgKrCLC5syT541DIkobqnvj6KngYME= X-Received: by 2002:a63:4f61:0:b0:507:4737:cdb5 with SMTP id p33-20020a634f61000000b005074737cdb5mr676401pgl.8.1678070852887; Sun, 05 Mar 2023 18:47:32 -0800 (PST) MIME-Version: 1.0 References: <20230301030610.49468-1-fengchengwen@huawei.com> <20230301030610.49468-5-fengchengwen@huawei.com> <22657fed-e920-5df9-8b9b-5bd1f986ff57@huawei.com> <1f0ccef2-7bd5-9e8b-a53c-a4d3997c2022@yandex.ru> In-Reply-To: <1f0ccef2-7bd5-9e8b-a53c-a4d3997c2022@yandex.ru> From: Ajit Khaparde Date: Sun, 5 Mar 2023 18:47:15 -0800 Message-ID: Subject: Re: [PATCH 4/5] net/bnxt: use fp ops setup function To: Konstantin Ananyev Cc: fengchengwen , Konstantin Ananyev , "thomas@monjalon.net" , "ferruh.yigit@amd.com" , Somnath Kotur , "dev@dpdk.org" Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000001d50e605f6325159" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000001d50e605f6325159 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Mar 5, 2023 at 7:58=E2=80=AFAM Konstantin Ananyev wrote: > > 03/03/2023 01:38, fengchengwen =D0=BF=D0=B8=D1=88=D0=B5=D1=82: > > On 2023/3/2 20:30, Konstantin Ananyev wrote: > >> > >>> Use rte_eth_fp_ops_setup() instead of directly manipulating > >>> rte_eth_fp_ops variable. > >>> > >>> Cc: stable@dpdk.org > >>> > >>> Signed-off-by: Chengwen Feng > >>> --- > >>> drivers/net/bnxt/bnxt_cpr.c | 5 +---- > >>> drivers/net/bnxt/bnxt_ethdev.c | 5 +---- > >>> 2 files changed, 2 insertions(+), 8 deletions(-) > >>> > >>> diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.= c > >>> index 3950840600..a3f33c24c3 100644 > >>> --- a/drivers/net/bnxt/bnxt_cpr.c > >>> +++ b/drivers/net/bnxt/bnxt_cpr.c > >>> @@ -416,10 +416,7 @@ void bnxt_stop_rxtx(struct rte_eth_dev *eth_dev) > >>> eth_dev->rx_pkt_burst =3D rte_eth_pkt_burst_dummy; > >>> eth_dev->tx_pkt_burst =3D rte_eth_pkt_burst_dummy; > >> > >> I am not that familiar with bnxt driver, but shouldn't we set here > >> other optional fp_ops (descripto_status, etc.) to some dummy values OR= to null values? > > > > I checked the bnxt PMD code, the other fp_ops (rx_queue_count/rx_descri= ptor_status/tx_descriptor_status) > > both add following logic at the beginning of function: > > > > rc =3D is_bnxt_in_error(bp); > > if (rc) > > return rc; > > > > So I think it okey to keep it. > > I still think it is much safer/cleaner to update all fp_ops in one go > (use fp_ops_reset()) here. > But as you believe it would work either way, I'll leave it to bnxt > maintainers to decide. We have been operating without the application being aware of the underlying functionality for some time now. Each step here is an improvement. I think it is okay to keep it simple and update them separately. Thanks Ajit > > > > > >> > >>> > >>> - rte_eth_fp_ops[eth_dev->data->port_id].rx_pkt_burst =3D > >>> - eth_dev->rx_pkt_burst; > >>> - rte_eth_fp_ops[eth_dev->data->port_id].tx_pkt_burst =3D > >>> - eth_dev->tx_pkt_burst; > >>> + rte_eth_fp_ops_setup(eth_dev); > >>> rte_mb(); > >>> > >>> /* Allow time for threads to exit the real burst functions. */ > >>> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_e= thdev.c > >>> index 4083a69d02..d6064ceea4 100644 > >>> --- a/drivers/net/bnxt/bnxt_ethdev.c > >>> +++ b/drivers/net/bnxt/bnxt_ethdev.c > >>> @@ -4374,10 +4374,7 @@ static void bnxt_dev_recover(void *arg) > >>> if (rc) > >>> goto err_start; > >>> > >>> - rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =3D > >>> - bp->eth_dev->rx_pkt_burst; > >>> - rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =3D > >>> - bp->eth_dev->tx_pkt_burst; > >>> + rte_eth_fp_ops_setup(bp->eth_dev); > >>> rte_mb(); > >>> > >>> PMD_DRV_LOG(INFO, "Port: %u Recovered from FW reset\n", > >>> -- > >>> 2.17.1 > >> > >> . > >> > --0000000000001d50e605f6325159 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIH60NH+7QsCgdZGX2b8A xgk+fcT1Mpr0lPHTbYzXPRi1MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMDMwNjAyNDczM1owaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQB7taUG63zRmokDbMOYOMxosFCrRsFQEjnH4Uaq TVr1DvECwave7yHl0dCT7ROj0U3h5Po2P4auXbTOywOEyMjPO8fL0qNt3pkMwdk29HrhoMpZ4BbX dMsCU5gqK1Ari08H3f6GLQ0MLtmQGOQu668QlRLjWoBlo1ObIL+EwSzMNYZUgfVNctVPKbMlDCU1 0as/4AiZ/8Gaj0nevgRXa2YEGbELU8caA5IpXZPUw/kS2VZ8+CL4NnAKWklohy9OP6W9RpYTII1A fHJItrFHpWz0cJ5FUqa/zK5b7McYG9KdEpTQ5BVUIjXvLzRw8/5AT6dexmvbh9cZet91c134rg1v --0000000000001d50e605f6325159--