DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>,
	 Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to not bring link down during reset recovery
Date: Tue, 22 Sep 2020 21:28:25 -0700	[thread overview]
Message-ID: <CACZ4nhuYY87OLScVgcLkGJw7+8y4zAMtphCZPpFxg95Tq00-gg@mail.gmail.com> (raw)
In-Reply-To: <20200922053416.16818-1-somnath.kotur@broadcom.com>

On Mon, Sep 21, 2020 at 10:41 PM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:

> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Driver should not send the phy_cfg request to bring link down
> during reset recovery. If the driver sends the phy_cfg request
> in recovery process, then FW needs to re-establish the link which
> in turn increases the recovery time based on PHY type and link partners.
>
> Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks


> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 05e9a6a..e0afaac 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1323,7 +1323,9 @@ static void bnxt_dev_stop_op(struct rte_eth_dev
> *eth_dev)
>
>         bnxt_cancel_fw_health_check(bp);
>
> -       bnxt_dev_set_link_down_op(eth_dev);
> +       /* Do not bring link down during reset recovery */
> +       if (!is_bnxt_in_error(bp))
> +               bnxt_dev_set_link_down_op(eth_dev);
>
>         /* Wait for link to be reset and the async notification to process.
>          * During reset recovery, there is no need to wait and
> @@ -4377,7 +4379,7 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp,
> uint32_t index)
>
>  static void bnxt_dev_cleanup(struct bnxt *bp)
>  {
> -       bnxt_set_hwrm_link_config(bp, false);
> +       bp->eth_dev->data->dev_link.link_status = 0;
>         bp->link_info->link_up = 0;
>         if (bp->eth_dev->data->dev_started)
>                 bnxt_dev_stop_op(bp->eth_dev);
> --
> 2.10.1
>
>

      reply	other threads:[~2020-09-23  4:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-22  5:34 Somnath Kotur
2020-09-23  4:28 ` Ajit Khaparde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACZ4nhuYY87OLScVgcLkGJw7+8y4zAMtphCZPpFxg95Tq00-gg@mail.gmail.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=kalesh-anakkur.purayil@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).