From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC699A04DB; Thu, 15 Oct 2020 01:27:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 620311DA68; Thu, 15 Oct 2020 01:27:33 +0200 (CEST) Received: from mail-oo1-f65.google.com (mail-oo1-f65.google.com [209.85.161.65]) by dpdk.org (Postfix) with ESMTP id 685361DA67 for ; Thu, 15 Oct 2020 01:27:32 +0200 (CEST) Received: by mail-oo1-f65.google.com with SMTP id w7so286054oow.7 for ; Wed, 14 Oct 2020 16:27:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=SbYB7D6jsGt/eO/1xaBw6qgkBYUrol/4QU9d9LtBBU4=; b=EyLSAGpKIl8qm/dxK/ipTw9bbRuE3laVlV41qCYl9EEMI8DJcN3qPb9hTuFpeQo2Ks YIljg9+Rl/OeCFId7YNdHmXv5fLvEYgGR3MNdSHje8J9389iVwrF4ibBBK5sSnXE2Rq1 lNCwkvLhC7x/yCad2ta16f+Rm3TSL3UANPg38= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SbYB7D6jsGt/eO/1xaBw6qgkBYUrol/4QU9d9LtBBU4=; b=kZLHUZkokKEo5eDMAHJ97JNhtUwGK3rHBk8KQoYCSXDDLkB2ucEMgJ23ixtsEmwOiT wYeODPWKTNBQNQ6IQhIVDUSgzn1mPG41SpyiYWM/xAVp0rEbKF/ApFg4HODf52MjT2x2 QSMvMcNW6Df76IYXlYFFrlkxTM5VVDrGOXALt2NHYRCrquFYFfnNOkvwmvpl4OLR7nqn t8Zf67UM5VCCF9p/i5SnUH6y+KU5TiqV1V4J6aPsm6l33Vje/uAafwrD4nxVXqjxCc3h zb688+40uMvhQgVs4iTvSFJJVigGEXH4Klxjiwc8x7lRVQQJoyLGWsoNLahwZfHDQtHO oDgQ== X-Gm-Message-State: AOAM533QsL4pQ8ZFDxHvUtHv4y3eQT4LnFS+zUr95PepNEzMqI2TUPsy KMvmID6XsOxV5qP+2wqGrMLzjM40TbNbT0u6HezXPQ== X-Google-Smtp-Source: ABdhPJzq5fCyGVaDO17MffxP4EW6soChjBk5PVjCQvJHvaXsy3o+VU06DaaVcYzPrwmXBx+Uda8uDZ5+j+yjqdleIN8= X-Received: by 2002:a4a:d1ae:: with SMTP id z14mr412454oor.52.1602718050547; Wed, 14 Oct 2020 16:27:30 -0700 (PDT) MIME-Version: 1.0 References: <20201012154459.27511-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20201012154459.27511-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Wed, 14 Oct 2020 16:27:14 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix UDP tunnel port remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 12, 2020 at 8:30 AM Kalesh A P wrote: > > From: Kalesh AP > > The HWRM supports only one global destination port for a tunnel type. > > When port is stopped, driver deletes the UDP tunnel port configured > in the HW, but it does not update the counter which causes the > tunnel port addition to fail after port is started again. > > Fixed to update the counter when tunnel port is deleted. > > Fixes: 10d074b2022d ("net/bnxt: support tunneling") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Kumar Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 8 -------- > drivers/net/bnxt/bnxt_hwrm.c | 15 +++++++++++++-- > 2 files changed, 13 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 8b63134..6c1025e 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -2192,14 +2192,6 @@ bnxt_udp_tunnel_port_del_op(struct rte_eth_dev *eth_dev, > } > > rc = bnxt_hwrm_tunnel_dst_port_free(bp, port, tunnel_type); > - if (!rc) { > - if (tunnel_type == > - HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_VXLAN) > - bp->vxlan_port = 0; > - if (tunnel_type == > - HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_GENEVE) > - bp->geneve_port = 0; > - } > return rc; > } > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index faeaf4b..a495dac 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -2750,11 +2750,10 @@ bnxt_free_tunnel_ports(struct bnxt *bp) > if (bp->vxlan_port_cnt) > bnxt_hwrm_tunnel_dst_port_free(bp, bp->vxlan_fw_dst_port_id, > HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_VXLAN); > - bp->vxlan_port = 0; > + > if (bp->geneve_port_cnt) > bnxt_hwrm_tunnel_dst_port_free(bp, bp->geneve_fw_dst_port_id, > HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_GENEVE); > - bp->geneve_port = 0; > } > > void bnxt_free_all_hwrm_resources(struct bnxt *bp) > @@ -3713,6 +3712,18 @@ int bnxt_hwrm_tunnel_dst_port_free(struct bnxt *bp, uint16_t port, > HWRM_CHECK_RESULT(); > HWRM_UNLOCK(); > > + if (tunnel_type == > + HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_VXLAN) { > + bp->vxlan_port = 0; > + bp->vxlan_port_cnt = 0; > + } > + > + if (tunnel_type == > + HWRM_TUNNEL_DST_PORT_FREE_INPUT_TUNNEL_TYPE_GENEVE) { > + bp->geneve_port = 0; > + bp->geneve_port_cnt = 0; > + } > + > return rc; > } > > -- > 2.10.1 >