From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC15AA0540; Wed, 15 Jul 2020 00:03:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 046441C20A; Wed, 15 Jul 2020 00:03:01 +0200 (CEST) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id 6B9561C1DF for ; Wed, 15 Jul 2020 00:02:59 +0200 (CEST) Received: by mail-oi1-f194.google.com with SMTP id h17so216786oie.3 for ; Tue, 14 Jul 2020 15:02:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=V+I6NjoGE0SK1OV/goQifR2vnkGhj+vfbEpTNrLBUd8=; b=Z5nXX5vkLEALs/wiJo3vOI1R/PuVv7OnjGaWAYt0irlNr9FoeVxTyW+98cP9Ju07ZD M11Pw/m6H9dRW38doX/5c1qtGPxZSY5ACdGlYSrIz01VaVEMApwA0ZEYt/pCzev1CvVZ YLxGHkpXdD8ReClP/Dly+KZxq1/SCXUv6q+So= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V+I6NjoGE0SK1OV/goQifR2vnkGhj+vfbEpTNrLBUd8=; b=tqnbYJfC+tqf2NojAVxuQGXJOfpPyUcfe8QerZWtgiisSzqYWB2VnyzYHlK6NlSobz T7MWwzKlaPXPeUlju9D1wRgCNLIvYjTCSkj/FTwL2bRHJV6f59vqlEGefnSXVXjtDaCs KQoB/nwkNX8at4u/ADX4xtaOwsumsQe88fRXav7m+9ZsnHtVBOjFV+vBIDFRTIibrC4s 2yu4MUjCQk/gCuEjN9MCP7VwE3B+WM9tdUoQaw8SnE3skKRpxAlq0/ejVbq/kQsaiBqX CznaTw6Rm2jRyOqO6IqDDBbC5t0b7uvTZaufdaNKdSSR/4Jy6RyNv+LTTaBLmFOVxFCe C3yA== X-Gm-Message-State: AOAM531DwWWcqvaH4+lHVoph3drfPYm3iRFfprZ2ko/uZueW0xtMUW57 +u4vgUfuq5EwronKRn5+Hl/nb1nS4CWKpk74ZboWRQ== X-Google-Smtp-Source: ABdhPJwWL9WIzCORoZvx5+4v3GnTFqERBvTGtkgbG7TtdmG5rVb2ZjYFcbGK9Rd4v0RMBVgTIY8FA8RLumMjKgPSpW8= X-Received: by 2002:aca:5347:: with SMTP id h68mr5569315oib.168.1594764178422; Tue, 14 Jul 2020 15:02:58 -0700 (PDT) MIME-Version: 1.0 References: <20200713051759.18901-1-somnath.kotur@broadcom.com> In-Reply-To: <20200713051759.18901-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Tue, 14 Jul 2020 15:02:42 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix a segfault during Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jul 12, 2020 at 10:23 PM Somnath Kotur wrote: > From: Ajit Khaparde > > When TRUFLOW is not enabled ulp_ctx is not allocated. > In non-vector Tx datapath we are accessing this invalid pointer > resulting in a segfault. Check if TRUFLOW is enabled before > accessing ulp_ctx to avoid this. > > Fixes: f86dc320a894 ("net/bnxt: fill cfa action in Tx descriptor") > > Signed-off-by: Ajit Khaparde > Reviewed-by: Venkat Duvvuru > Signed-off-by: Somnath Kotur > Signed-off-by: Venkat Duvvuru > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_txr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c > index f588426..c741c71 100644 > --- a/drivers/net/bnxt/bnxt_txr.c > +++ b/drivers/net/bnxt/bnxt_txr.c > @@ -132,8 +132,9 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf > *tx_pkt, > PKT_TX_TUNNEL_GRE | PKT_TX_TUNNEL_VXLAN | > PKT_TX_TUNNEL_GENEVE | > PKT_TX_IEEE1588_TMST | > PKT_TX_QINQ_PKT) || > - txq->bp->ulp_ctx->cfg_data->tx_cfa_action || > - txq->vfr_tx_cfa_action) > + (BNXT_TRUFLOW_EN(txq->bp) && > + (txq->bp->ulp_ctx->cfg_data->tx_cfa_action || > + txq->vfr_tx_cfa_action))) > long_bd = true; > > nr_bds = long_bd + tx_pkt->nb_segs; > -- > 2.7.4 > >