From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 38B86A0526; Wed, 22 Jul 2020 02:19:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4ECD71C0C5; Wed, 22 Jul 2020 02:19:00 +0200 (CEST) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by dpdk.org (Postfix) with ESMTP id B16671C0B1 for ; Wed, 22 Jul 2020 02:18:58 +0200 (CEST) Received: by mail-ot1-f66.google.com with SMTP id n24so495479otr.13 for ; Tue, 21 Jul 2020 17:18:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EIobJnJuP96ZI/SlfoFdQUcp/sdGAC9POXy/gXwnKHI=; b=dCxmw42hOuzfx6rTZUaGlo/FPhNojvT19Bg97oqJit+iGPzgSZTB54zod867ECWfGu O6uuyMiWDT8tif8s/PdiaNkcryfpDacxWJUoNgqoy1pcDTA+jx87xr5ZgkWP1nTDv+da vN0elk4WyB6amtPS0+QcVf4ksYKKJoKRKBOo8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EIobJnJuP96ZI/SlfoFdQUcp/sdGAC9POXy/gXwnKHI=; b=r1UEPyReG7z+gf1odi8NbSQowtRBe+IxwkpigYBIDmwn4GB41FShCYpdDaN+YE2wyZ rW9Y32+OhmeGL5jEy0WuqLbEMyE1BwINOkWg7TjRr0jNCTxk+Wj3Bgs1n7936nUF4EEF l4OyS/wJ4tnYb2N1w0Av+OaPWc4oFBy59h8gJRdy8981BnArjEqzJohlCSVq2az2SDMH HYah+o/RcEYBaPKuBrNabpuXoigTpgIZBQlREbXuxi7Pa3WFvNBGhrMqwqTFbP+qMW6D St6WZREbIpo/VW+Qot0gdrZYbips58iL/vVpmAYR4VbkhIHSKFcDwX8qd/1PXYjZuSjz CbxA== X-Gm-Message-State: AOAM532oCTuv1pgmiIpjJaTqfuJhY2g0JX5o1fFnSBRmAJuOi8lUpS44 uAnpvKfN569K22iT29C/a/+hYmtxzTEM8FVWHBB4Hg== X-Google-Smtp-Source: ABdhPJwM97ZLnvlCNvpvgfmOhRwsCsCkNjkHVMM08hQiqpWbpRykViODixjaABLK2yZsuyVSqqbvrwW3XeBVPVTL7U0= X-Received: by 2002:a9d:3b1:: with SMTP id f46mr28579338otf.154.1595377137507; Tue, 21 Jul 2020 17:18:57 -0700 (PDT) MIME-Version: 1.0 References: <20200721174712.48625-1-ajit.khaparde@broadcom.com> <6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com> In-Reply-To: <6e27fb42-4e42-96a7-d025-6a49f0a30395@intel.com> From: Ajit Khaparde Date: Tue, 21 Jul 2020 17:18:41 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Bruce Richardson , Thomas Monjalon , David Marchand Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: add meson build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 21, 2020 at 4:09 PM Ferruh Yigit wrote: > On 7/21/2020 6:47 PM, Ajit Khaparde wrote: > > Add an option in meson build to indicate the memory management scheme. > > bnxt_eem_system is set to false by default. > > > > Signed-off-by: Ajit Khaparde > > <...> > > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -2,6 +2,8 @@ > > > > option('armv8_crypto_dir', type: 'string', value: '', > > description: 'path to the armv8_crypto library installation > directory') > > +option('bnxt_eem_system', type: 'boolean', value: false, > > + description: 'EEM system memory support') > > option('disable_drivers', type: 'string', value: '', > > description: 'Comma-separated list of drivers to explicitly > disable.') > > option('drivers_install_subdir', type: 'string', value: > 'dpdk/pmds-', > > > > I think it was a design decision to not have all Make config options to > meson > build, and reduce compile time configuration as much as possible. > > For a while we are pushing back new compile time config options unless > they are > really must, the 'RTE_LIBRTE_BNXT_PMD_SYSTEM' has been merged mostly > because it > has been missed. > > Instead of introducing this PMD level compile time option to meson, can it > be > possible to convert the config to runtime config. In the past we have used > the > device arguments many times for same reason, can something similar be used > here? > Sure. I can take a look at that.