From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Lance Richardson <lance.richardson@broadcom.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: fix VLAN strip flags in sse mode
Date: Wed, 22 Jan 2020 15:23:28 -0800 [thread overview]
Message-ID: <CACZ4nhufB3ox-rHjZr91wtLW2ZQZ-yAhSNimXqL0TPMvg0cQ3g@mail.gmail.com> (raw)
In-Reply-To: <20200122231840.37215-1-ajit.khaparde@broadcom.com>
On Wed, Jan 22, 2020 at 3:18 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> When the VLAN is stripped from the packet on receive the
> driver must set the PKT_RX_VLAN_STRIPPED flag in the mbuf.
> This is done correctly for normal receive in the bnxt driver
> but was not being handled correctly in the new SSE code.
>
> Fixes: bc4a000f2f53 ("net/bnxt: implement SSE vector mode")
> Cc: lance.richardson@broadcom.com
> Cc: stable@dpdk.org
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> v1->v2: fixed the commit headline
>
> drivers/net/bnxt/bnxt_rxtx_vec_sse.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> index 22d9f9e84..31457300a 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_sse.c
> @@ -289,7 +289,8 @@ bnxt_recv_pkts_vec(void *rx_queue, struct rte_mbuf
> **rx_pkts,
> (RX_PKT_CMPL_METADATA_VID_MASK |
> RX_PKT_CMPL_METADATA_DE |
> RX_PKT_CMPL_METADATA_PRI_MASK);
> - mbuf->ol_flags |= PKT_RX_VLAN;
> + mbuf->ol_flags |=
> + PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
> }
>
> bnxt_parse_csum(mbuf, rxcmp1);
> --
> 2.21.0 (Apple Git-122.2)
>
>
prev parent reply other threads:[~2020-01-22 23:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-22 0:47 [dpdk-dev] [PATCH] net/bxnt: fix vlan " Stephen Hemminger
2020-01-22 23:18 ` [dpdk-dev] [PATCH v2] net/bnxt: fix VLAN " Ajit Khaparde
2020-01-22 23:23 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhufB3ox-rHjZr91wtLW2ZQZ-yAhSNimXqL0TPMvg0cQ3g@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lance.richardson@broadcom.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).