From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76B6CA0A04; Fri, 15 Jan 2021 17:48:44 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E053C1411C1; Fri, 15 Jan 2021 17:48:43 +0100 (CET) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mails.dpdk.org (Postfix) with ESMTP id 1041E141196 for ; Fri, 15 Jan 2021 17:48:43 +0100 (CET) Received: by mail-qv1-f47.google.com with SMTP id az16so4245526qvb.5 for ; Fri, 15 Jan 2021 08:48:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XbY7E0jknWSdslgu13qpQbG6YJ7rpLxyBcUK7A/Mh5g=; b=a7Q+O/BX9GC8J0VopK4tqauqXyPTPWylEw4H05ob32CrwiRrZjgaewftXn04Ys1QXi j5b2wy84YxMjOb8LUcwgTb35u1IdE8k/WiAZhjAoaU5crxIl9nk0lh0pc/4vfrQ8/PMj KYMsqe3pc1zKgK5HNWKLG/4108HhOp26HgSgw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XbY7E0jknWSdslgu13qpQbG6YJ7rpLxyBcUK7A/Mh5g=; b=eWAVFvhmG4Tk8squ9KjdMu1nF3N2fvUFsLJfyzFXFlLcJYKG2yJ6G+hPf3fkA/fRUx kxf1QOzDsJTYvV5OHciaIwcVl41WJLzZNKJagsBI2U27OQGhwGC0e+0IHw6aiw8HyrRp k0OSCeVjmEUmeSyjupBPe0zgjpvg3TvHahoaxourQxj4oH1IvJ32uvOtJGkf0k056GF+ RevCKiDPg7njnwxwn12DeMFmZVDuKYvvoDRcdRlm86K6T1yCxIQoICnl2K36p4cds+pB 4a/ladh7q1ZkSTy7J69xhY9hvBGWc5p4xAZ5/+/iexFKvHeOFsc0W+H5Yx+TLvZ8EvFz Q6Wg== X-Gm-Message-State: AOAM533vqjv1q4mP2CzOe/Gl7C6ws2macEPm+BLBVrv0muqj83qiN6WN vihfDbNXXrR3fSBTL9BL29/5WsaDJXb/+U7/AttbNZJBQgd0Sg== X-Google-Smtp-Source: ABdhPJw3Sn03STYYKy0FqRozNJRC01A5acU7BBiu7NoWmvDGTek7Em9ICsXDp2O4mqGj3w6WpA58ZQ8Qu2GKotHGIUQ= X-Received: by 2002:a0c:a994:: with SMTP id a20mr13228187qvb.30.1610729322126; Fri, 15 Jan 2021 08:48:42 -0800 (PST) MIME-Version: 1.0 References: <20210115155232.1406688-1-ferruh.yigit@intel.com> In-Reply-To: <20210115155232.1406688-1-ferruh.yigit@intel.com> From: Ajit Khaparde Date: Fri, 15 Jan 2021 08:48:26 -0800 Message-ID: To: Ferruh Yigit Cc: Thomas Monjalon , Andrew Rybchenko , dpdk-dev , Min Hu , Wei Hu , Chengwen Feng , Chengchang Tang , Andrew Rybchenko Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000001a2b7405b8f32523" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] ethdev: rename FEC API parameters X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000001a2b7405b8f32523 Content-Type: text/plain; charset="UTF-8" On Fri, Jan 15, 2021 at 7:52 AM Ferruh Yigit wrote: > > The FEC APIs to get/set FEC mode has parameter name as 'fec_capa', > renamed them as 'fec_mode' to be more accurate with API. > > No functional change. > > Signed-off-by: Ferruh Yigit Acked-by: Ajit Khaparde > --- > Cc: Min Hu (Connor) > Cc: Wei Hu (Xavier) > Cc: Chengwen Feng > Cc: Chengchang Tang > Cc: Andrew Rybchenko > Cc: Ajit Khaparde > --- > lib/librte_ethdev/rte_ethdev.c | 10 +++++----- > lib/librte_ethdev/rte_ethdev.h | 8 ++++---- > lib/librte_ethdev/rte_ethdev_driver.h | 8 ++++---- > 3 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index 17ddacc78ded..332d7a789380 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -3948,28 +3948,28 @@ rte_eth_fec_get_capability(uint16_t port_id, > } > > int > -rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa) > +rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode) > { > struct rte_eth_dev *dev; > > - if (fec_capa == NULL) > + if (fec_mode == NULL) > return -EINVAL; > > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > dev = &rte_eth_devices[port_id]; > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_get, -ENOTSUP); > - return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_capa)); > + return eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_mode)); > } > > int > -rte_eth_fec_set(uint16_t port_id, uint32_t fec_capa) > +rte_eth_fec_set(uint16_t port_id, uint32_t fec_mode) > { > struct rte_eth_dev *dev; > > RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV); > dev = &rte_eth_devices[port_id]; > RTE_FUNC_PTR_OR_ERR_RET(*dev->dev_ops->fec_set, -ENOTSUP); > - return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, fec_capa)); > + return eth_err(port_id, (*dev->dev_ops->fec_set)(dev, fec_mode)); > } > > /* > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index 2cbce958cf6c..0aefb7cb2f4a 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -3699,7 +3699,7 @@ int rte_eth_fec_get_capability(uint16_t port_id, > * > * @param port_id > * The port identifier of the Ethernet device. > - * @param fec_capa > + * @param fec_mode > * A bitmask of enabled FEC modes. If AUTO bit is set, other > * bits specify FEC modes which may be negotiated. If AUTO > * bit is clear, specify FEC modes to be used (only one valid > @@ -3712,7 +3712,7 @@ int rte_eth_fec_get_capability(uint16_t port_id, > * - (-ENODEV) if *port_id* invalid. > */ > __rte_experimental > -int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa); > +int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode); > > /** > * @warning > @@ -3722,7 +3722,7 @@ int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa); > * > * @param port_id > * The port identifier of the Ethernet device. > - * @param fec_capa > + * @param fec_mode > * A bitmask of allowed FEC modes. If AUTO bit is set, other > * bits specify FEC modes which may be negotiated. If AUTO > * bit is clear, specify FEC modes to be used (only one valid > @@ -3735,7 +3735,7 @@ int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa); > * - (-ENODEV) if *port_id* invalid. > */ > __rte_experimental > -int rte_eth_fec_set(uint16_t port_id, uint32_t fec_capa); > +int rte_eth_fec_set(uint16_t port_id, uint32_t fec_mode); > > /** > * Get current status of the Ethernet link flow control for Ethernet device > diff --git a/lib/librte_ethdev/rte_ethdev_driver.h b/lib/librte_ethdev/rte_ethdev_driver.h > index 0eacfd842581..616a14d0361e 100644 > --- a/lib/librte_ethdev/rte_ethdev_driver.h > +++ b/lib/librte_ethdev/rte_ethdev_driver.h > @@ -625,7 +625,7 @@ typedef int (*eth_fec_get_capability_t)(struct rte_eth_dev *dev, > * > * @param dev > * ethdev handle of port. > - * @param fec_capa > + * @param fec_mode > * a bitmask of enabled FEC modes. If AUTO bit is set, other > * bits specify FEC modes which may be negotiated. If AUTO > * bit is clear, specify FEC modes to be used (only one valid > @@ -642,7 +642,7 @@ typedef int (*eth_fec_get_capability_t)(struct rte_eth_dev *dev, > * Device is removed. > */ > typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev, > - uint32_t *fec_capa); > + uint32_t *fec_mode); > > /** > * @internal > @@ -650,7 +650,7 @@ typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev, > * > * @param dev > * ethdev handle of port. > - * @param fec_capa > + * @param fec_mode > * bitmask of allowed FEC modes. It must be only one > * if AUTO is disabled. If AUTO is enabled, other > * bits specify FEC modes which may be negotiated. > @@ -667,7 +667,7 @@ typedef int (*eth_fec_get_t)(struct rte_eth_dev *dev, > * @retval -EIO > * Device is removed. > */ > -typedef int (*eth_fec_set_t)(struct rte_eth_dev *dev, uint32_t fec_capa); > +typedef int (*eth_fec_set_t)(struct rte_eth_dev *dev, uint32_t fec_mode); > > /** > * @internal > -- > 2.29.2 > --0000000000001a2b7405b8f32523--