From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B063A00C5; Thu, 7 May 2020 20:55:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D976A1DC46; Thu, 7 May 2020 20:55:46 +0200 (CEST) Received: from mail-oo1-f65.google.com (mail-oo1-f65.google.com [209.85.161.65]) by dpdk.org (Postfix) with ESMTP id 59BEE1DC3C for ; Thu, 7 May 2020 20:55:45 +0200 (CEST) Received: by mail-oo1-f65.google.com with SMTP id 190so1579022ooa.12 for ; Thu, 07 May 2020 11:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yqDYaJiZIvPSeNYe2kG0vh32CbwQGM4UecU/mmCGzgw=; b=SW92/C9vW4cxNMFfowuB2GkYdo75nfIwFYZ9d5EllDYa88NyCvG+aCpoj4ftyGUx89 Nx2jPbdvzahT3fPRl+eqBwvi5sD6XPDlNV3K9ujeKJ5rzD1ngz1kawW/XdZ/uicQGumb tq14kKMW3T0VI6cmphrKzE13e9wiKCI9YchPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yqDYaJiZIvPSeNYe2kG0vh32CbwQGM4UecU/mmCGzgw=; b=VZf9DOZ+9cTfIjh+w2/CobXuMBda9F/U+lTmZrCiLcbx/ulI26siJZjJFmbMnHR1Qt CIuNoCIxDDAPKOXmZTTBq1KjzXLbo+8IYr+mwe7UUwqRCjWkfaumW3b1S6W/pyKygYMg 6zJS2Bzx1RtvykrxLhZJ9kUJMxI1mSFPS6CZT+mhhio3KsghbxbMcyrlkGzV2j/alMn2 mMe51qX2GMkHliVqidoV2tjwZZUOtLV0tHsr+fTllowffcKC6iO+iPEBgugtj5oybal2 /eXQQR6vOm0y+PSZoiBbpm84pO4mK2JyZ2te3XpCC2kwz+l/eTNK2qHUy/Ca07C1B8ZD 9PEw== X-Gm-Message-State: AGi0PuZy5rvHIkHZWPGmuDo3PnF+wmZVjwRQnkzrGvWkGeDDFkiM3MCq OvBPc0caPhfhPLVCYZMMWTqUWUkziXi6ye0VS4hBBQ== X-Google-Smtp-Source: APiQypKSZ5/SvViNBqa0FlANRhBYOUpnv+tT1gIPQ2D6he/TetzxfcohbenEXEt/ooM4TAqi4niA5qwOFRBzllFIHxg= X-Received: by 2002:a4a:e917:: with SMTP id z23mr12873703ood.23.1588877744348; Thu, 07 May 2020 11:55:44 -0700 (PDT) MIME-Version: 1.0 References: <20200505191738.58219-1-ajit.khaparde@broadcom.com> <20200505191738.58219-3-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 7 May 2020 11:55:28 -0700 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , Somnath Kotur , Randy Schacher Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix uninitialized variable error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 2:14 AM Ferruh Yigit wrote: > On 5/5/2020 8:17 PM, Ajit Khaparde wrote: > > Fix uninitialized variable error reported by coverity. > > > > Fixes: d33b68154fa4 ("net/bnxt: add tf_core table scope support") > > The commit id and the patch title doesn't exist in next-net (also not int > next-net-brcm), I guess you mean [1] but the updated function below > ('tf_em_ctx_reg()') even not exist in that commit. > > Can you please check the tag again? > > [1] net/bnxt: support TruFlow core table scope > Yes [1] is the correct commit. dba3ca8b304f ("net/bnxt: support TruFlow core table scope"). > > > Coverity issue: 357771 > > > > Signed-off-by: Ajit Khaparde > > Reviewed-by: Somnath Kotur > > Reviewed-by: Randy Schacher > > --- > > drivers/net/bnxt/tf_core/tf_tbl.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/tf_core/tf_tbl.c > b/drivers/net/bnxt/tf_core/tf_tbl.c > > index 93f387e86..d900c9c09 100644 > > --- a/drivers/net/bnxt/tf_core/tf_tbl.c > > +++ b/drivers/net/bnxt/tf_core/tf_tbl.c > > @@ -539,7 +539,7 @@ tf_em_ctx_reg(struct tf *tfp, > > { > > struct tf_em_ctx_mem_info *ctxp = &tbl_scope_cb->em_ctx_info[dir]; > > struct tf_em_table *tbl; > > - int rc; > > + int rc = 0; > > int i; > > > > for (i = KEY0_TABLE; i < MAX_TABLE; i++) { > > > >