From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4420A459FB; Fri, 27 Sep 2024 19:21:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D01A74028C; Fri, 27 Sep 2024 19:21:16 +0200 (CEST) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 36EFD4025D for ; Fri, 27 Sep 2024 19:21:15 +0200 (CEST) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2e0b0142bbfso1245651a91.1 for ; Fri, 27 Sep 2024 10:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1727457674; x=1728062474; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=caYSo1lPMncYU30tS9P76latiQMHqaqrl9WlqfynX/g=; b=TPVrtK/2NVfFlFuiuFMoEpFifpy4jJIOIKrhjhFlJXnnKcvz9fsEuZ+gxSib+h1I7p v/tAsWnvyrYX0lvawAn3JUYKd5e7Z01ks07kuuLDyasxxi1LM8GgHPRdLagX+wgCKMB5 Rsb4aWnULn8eaXf4MW+U3QIp4kkxWCQVZx7HY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727457674; x=1728062474; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=caYSo1lPMncYU30tS9P76latiQMHqaqrl9WlqfynX/g=; b=pYyzmwdSLdHtTRxheYtnPam4cdHE0UVl1JO1C620J5k9f8Gfvz30NKcdNPOs54g41A JxgG//Ej6bvWpfPYzaKi2cWC6wVkx9spxKlV5q7C6/lT5SnexcxCfNHmuUmB7/7ahhIu G4Cmi5kkRrVqMRru9Y787RXpm25vUJqOj/OqFn8ArF9SrUyyzypmFsscvaY/pbzg2rSb ugHpyzbj4WQFs8L83fTUT88sNUNYc2zriJTiIbYICOaEKVxvBONMPm/trff/vAd7piXs USbCxRYIHKGoS5cohMoVQyaU6VYqLKCOsFup1nYb9AK5DcdCfJBVPLkmKF50JudJUXKn wFzw== X-Forwarded-Encrypted: i=1; AJvYcCWW8yEBjFDmUSmGQsbFtSAhSvHu05sLXk8y0GMF9ZPDlOcl3KcEKU/1CtywZusii3rdrjQ=@dpdk.org X-Gm-Message-State: AOJu0YwsHo5IaZ63E1Zu3xznhRIJy1x5j49SM17MADBAYW9+bMvG+56j ygtVadx+YNToyfRImERT7opPpFoAWEjgmGzMMkb/Swd2P32sg/jAzQIX1mdtc74e8aKHJ6Z+33P YCI2/pHL/YzGOmhDlBBLmYkbf8g8OIc6f+/vE X-Google-Smtp-Source: AGHT+IGEYvcVIjMsnkpX6MX8gCADneaAXhraUYKVOi0OEs7wMNaWqp41+LLszJUAyV+uVC+cBk2JzlKYC779WNVbZcg= X-Received: by 2002:a17:90a:3481:b0:2e0:8bf7:4f0f with SMTP id 98e67ed59e1d1-2e0926e39b2mr11862911a91.5.1727457674296; Fri, 27 Sep 2024 10:21:14 -0700 (PDT) MIME-Version: 1.0 References: <20240926215012.9987-1-damodharam.ammepalli@broadcom.com> <20240926215012.9987-2-damodharam.ammepalli@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Fri, 27 Sep 2024 10:20:57 -0700 Message-ID: Subject: Re: [PATCH v6 1/2] ethdev: Add link_speed lanes support To: Ferruh Yigit Cc: Damodharam Ammepalli , dev@dpdk.org, huangdengdui@huawei.com, kalesh-anakkur.purayil@broadcom.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000fa80a06231d15d9" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000000fa80a06231d15d9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Sep 26, 2024 at 5:39=E2=80=AFPM Ferruh Yigit = wrote: > > On 9/26/2024 10:43 PM, Damodharam Ammepalli wrote: > > Update the eth_dev_ops structure with new function vectors > > to get, get capabilities and set ethernet link speed lanes. > > Update the testpmd to provide required config and information > > display infrastructure. > > > > The supporting ethernet controller driver will register callbacks > > to avail link speed lanes config and get services. This lanes > > configuration is applicable only when the nic is forced to fixed > > speeds. In Autonegiation mode, the hardware automatically > > negotiates the number of lanes. > > > > These are the new commands. > > > > testpmd> show port 0 speed_lanes capabilities > > > > Supported speeds Valid lanes > > ----------------------------------- > > 10 Gbps 1 > > 25 Gbps 1 > > 40 Gbps 4 > > 50 Gbps 1 2 > > 100 Gbps 1 2 4 > > 200 Gbps 2 4 > > 400 Gbps 4 8 > > testpmd> > > > > testpmd> > > testpmd> port stop 0 > > testpmd> port config 0 speed_lanes 4 > > testpmd> port config 0 speed 200000 duplex full > > testpmd> port start 0 > > testpmd> > > testpmd> show port info 0 > > > > ********************* Infos for port 0 ********************* > > MAC address: 14:23:F2:C3:BA:D2 > > Device name: 0000:b1:00.0 > > Driver name: net_bnxt > > Firmware-version: 228.9.115.0 > > Connect to socket: 2 > > memory allocation on the socket: 2 > > Link status: up > > Link speed: 200 Gbps > > Active Lanes: 4 > > Link duplex: full-duplex > > Autoneg status: Off > > > > Signed-off-by: Damodharam Ammepalli > > > > Reviewed-by: Ferruh Yigit Reviewed-by: Ajit Khaparde > > Suggested patch title: > ethdev: support link speed lanes > > <...> > > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change, or be removed, without prior = notice > > + * > > + * Get Active lanes. > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param lanes > > + * Driver updates lanes with the number of active lanes. > > + * On a supported NIC on link up, lanes will be a non-zero value irr= espective whether the > > + * link is Autonegotiated or Fixed speed. No information is dispalye= d for error. > > > > s/dispalyed/displayed/ > > I can fix while merging > --0000000000000fa80a06231d15d9 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIK/Pe6tjBzmNLnK4tL3m QvEY1PQUeyLslNL5UDr5N5TbMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTI0MDkyNzE3MjExNFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBVWgoXmOW8nsoGA0PAi5PUXvpmvnXDDHmUVuQp h/aVH7MqiI7RI60yS4Qo6IKDKFAwofMLI9EheSeeE6gTP15by5AubT7KxwLHu3gGnLYDBNjPrnXN Z29UkWBGZZZ2tdxOZg0jy5bQpPpypgJ7AXF5Yda4F25yrvpHK5gFK4b+icduoCQ6ctB6Nkp7G+f5 WpmXY8kH7eHXqL2+1irYDiWfNMsqdDZrSydD6kG0t7wHnU4XpWiAK0koXBecXGVrmCRg/tAjSVQq +g72sAfECcNWipZyuq/mGydO/XPr0xOABbpdg29HDYP/ahu/x3IhuTNWXWWyTVW9lFeFV8inMM7Q --0000000000000fa80a06231d15d9--