From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFAB2A0C43; Wed, 20 Oct 2021 19:30:10 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B721040142; Wed, 20 Oct 2021 19:30:10 +0200 (CEST) Received: from mail-il1-f172.google.com (mail-il1-f172.google.com [209.85.166.172]) by mails.dpdk.org (Postfix) with ESMTP id B2F4F4003E for <dev@dpdk.org>; Wed, 20 Oct 2021 19:30:09 +0200 (CEST) Received: by mail-il1-f172.google.com with SMTP id x1so22946154ilv.4 for <dev@dpdk.org>; Wed, 20 Oct 2021 10:30:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+TiFfQWkox3HlJIgZd6dNsKF8OiMVZv2N4dLtkQ+tHc=; b=WkT3drWne5hKbTXOFfOkjLOq5AoFWcgq7CEB1YNOv14tEryOJgBoZ2WA4uClPpriuV V0dJy+NtuyXqT+F819PVrSSSHyL0TQp/hGpy+pQJIbIiZmmQ/dNy786RwMxPQ5cMejPZ 5JnMwtmKtn3CJqkcWxIhXuQyrD+kAaPI6Cnfc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+TiFfQWkox3HlJIgZd6dNsKF8OiMVZv2N4dLtkQ+tHc=; b=rh9l9glL5Rm1l/XrehLLCAagKliB0kQcMCa+7YfElsV5xHlhP89h/ZbhWtBrGjCdxC /Er67sSBPQ2XOtPqOAz/P2PEE61XkodhKNmqGiW0QJCIqJH0oOONyMMbbvxTsL5Cvk93 UmprzcUcNtkqEWS9m8iYhqKRBzRhbE4KldFXvKitxmnaDKQcJIjwTwz5+uc0YHJfXNf1 L+hK9CSFsRk0x8r1ZtmyNPwLfpz+r3gTBiodACbdAhoaIbNsvsztL6pmi8zgYniu1s07 cpiM9fgIdPtiYXNk2WhbKMTwAGKo39z0+oZjR96NEmqu04VP04yvbUz71cNZicC7dBNA g8Mg== X-Gm-Message-State: AOAM530Le0/ddU2+W9BKaK8aYoEyWuTHRXoSdThf6tuDj6s/btgZLDuO woOOjOxpRhXKv0EtCIoW/047Kx4g1K9gv00kGtHx6Q== X-Google-Smtp-Source: ABdhPJw+nb2hMZBZ42SfCQEqoNQBMrLbRSB1Mp90dm+GL4i1ELYk4NQQkB8XREqI82EqoRhvxtMxp+AObKP/LuEmNwA= X-Received: by 2002:a05:6e02:1846:: with SMTP id b6mr279682ilv.63.1634751009017; Wed, 20 Oct 2021 10:30:09 -0700 (PDT) MIME-Version: 1.0 References: <20210727034204.20649-1-xuemingl@nvidia.com> <20211020075319.2397551-1-xuemingl@nvidia.com> <20211020075319.2397551-5-xuemingl@nvidia.com> In-Reply-To: <20211020075319.2397551-5-xuemingl@nvidia.com> From: Ajit Khaparde <ajit.khaparde@broadcom.com> Date: Wed, 20 Oct 2021 10:29:52 -0700 Message-ID: <CACZ4nhupXECaxu7r54FVE3g3BzPxarHPUBGzqsof+-HawBxfMA@mail.gmail.com> To: Xueming Li <xuemingl@nvidia.com> Cc: dpdk-dev <dev@dpdk.org>, Zhang Yuying <yuying.zhang@intel.com>, Jerin Jacob <jerinjacobk@gmail.com>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>, Lior Margalit <lmargalit@nvidia.com>, Ananyev Konstantin <konstantin.ananyev@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v11 4/7] app/testpmd: new parameter to enable shared Rx queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Wed, Oct 20, 2021 at 12:54 AM Xueming Li <xuemingl@nvidia.com> wrote: > > Adds "--rxq-share=X" parameter to enable shared RxQ, share if device > supports, otherwise fallback to standard RxQ. > > Share group number grows per X ports. X defaults to MAX, implies all > ports join share group 1. Queue ID is mapped equally with shared Rx > queue ID. > > Forwarding engine "shared-rxq" should be used which Rx only and update > stream statistics correctly. > > Signed-off-by: Xueming Li <xuemingl@nvidia.com> > --- > app/test-pmd/config.c | 7 ++++++- > app/test-pmd/parameters.c | 13 +++++++++++++ > app/test-pmd/testpmd.c | 20 +++++++++++++++++--- > app/test-pmd/testpmd.h | 2 ++ > doc/guides/testpmd_app_ug/run_app.rst | 7 +++++++ > 5 files changed, 45 insertions(+), 4 deletions(-) > :::snip:::: > + > extern uint16_t nb_pkt_per_burst; > extern uint16_t nb_pkt_flowgen_clones; > extern int nb_flows_flowgen; > diff --git a/doc/guides/testpmd_app_ug/run_app.rst b/doc/guides/testpmd_app_ug/run_app.rst > index 640eadeff73..ff5908dcd50 100644 > --- a/doc/guides/testpmd_app_ug/run_app.rst > +++ b/doc/guides/testpmd_app_ug/run_app.rst > @@ -389,6 +389,13 @@ The command line options are: > > Generate multiple flows in txonly mode. > > +* ``--rxq-share=[X]`` > + > + Create queues in shared Rx queue mode if device supports. > + Group number grows per X ports. X defaults to MAX, implies all ports > + join share group 1. Forwarding engine "shared-rxq" should be used > + which Rx only and update stream statistics correctly. Did you mean "with Rx only"? Something like this? "shared-rxq" should be used in Rx only mode. If you say - "the Forwarding engine should update stream statistics correctly", I think that is expected anyway? So there is no need to mention that in the guide. > + > * ``--eth-link-speed`` > > Set a forced link speed to the ethernet port:: > -- > 2.33.0 >