From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1C912A04B5; Wed, 2 Sep 2020 06:04:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81F50137D; Wed, 2 Sep 2020 06:04:15 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id C75C2255 for ; Wed, 2 Sep 2020 06:04:13 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id k20so3143727otr.1 for ; Tue, 01 Sep 2020 21:04:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+v4aK/Y01SBT3WeSDQ+3TCSfDCOpRHmKQJD27erM+Vs=; b=LPiSUdAoPkKv/FxDHXjXgfGife9oIaqGy2oZBKnxh2ADFCI5RIhPELRbUqvLGYa9Ll cpboovI0DsAAea8P3RIzgNj6yiGRS85WmBJnTkChc+upMLrFhOd8duinqORJPsasgaGK i36aOTd+FOooHTwPZUW7fdTpuoHJavzWDUKC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+v4aK/Y01SBT3WeSDQ+3TCSfDCOpRHmKQJD27erM+Vs=; b=NOHrbrANBesbqv6lZodinNUA7Lcja4PXEGxnsn7N5NHCITjrNupPIKepPFCOBuS3gG hWbt7sEVP83wMd317DZxLp8b+3S7Nidr+/wNRHoRxiTovcwzZoyPj9u2Brq8Zb0HudOR nzNlHAnQ6dXzNfBbVnENu+m7MLyQzW0q5uwPHqz4bd3aaNXbJmRdeEMY5Bkf6X0rLM1c 22+VqIQce6xsuUhW73C441rJ6vAjZq6P3DqqIRenvw/KNtKJHrwwAsU+c3+JWw+3h9cl AwapTdRRiWf8hKtBSsfCydKKos6UiEomAOw1lRith5PB48TO2RGv9JSDAF0Ege6sOx9c 6wpw== X-Gm-Message-State: AOAM5313iUNFttdZlFqk6GqO/EcNkSupTb6OdHWi32bdD13XRdoQdWpA trsYrUHaXIgGeOFXdO1d8bCBfyyQwN09DK8qD+Jl8Q== X-Google-Smtp-Source: ABdhPJyUVyUWYHlT+RX2gALNPueE8PQPIqknljyrMjy+YhvFc3OrNqI9EnomDjI4nqTq8aMTnLl0kZ2/tt+cWmLrH+0= X-Received: by 2002:a9d:2c43:: with SMTP id f61mr4148643otb.154.1599019453047; Tue, 01 Sep 2020 21:04:13 -0700 (PDT) MIME-Version: 1.0 References: <20200731023444.27986-1-gaurav1086@gmail.com> <20200806035213.22538-1-gaurav1086@gmail.com> In-Reply-To: <20200806035213.22538-1-gaurav1086@gmail.com> From: Ajit Khaparde Date: Tue, 1 Sep 2020 21:03:56 -0700 Message-ID: To: Gaurav Singh Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: remove redundant null check in bnxt_validate_and_parse_flow_type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 5, 2020 at 8:52 PM Gaurav Singh wrote: > vxlan_spec cannot be NULL since its already being accessed > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index 320b53d94..c1c59bbe5 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, > } > > /* Check if VNI is masked. */ > - if (vxlan_spec && vxlan_mask) { > + if (vxlan_mask != NULL) { > vni_masked = > !!memcmp(vxlan_mask->vni, vni_mask, > RTE_DIM(vni_mask)); > -- > 2.17.1 > >