vxlan_mask cannot be NULL since its already being accessed before. Remove the redundant NULL check. Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> --- drivers/net/bnxt/bnxt_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index 320b53d94..33a074387 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, } /* Check if VNI is masked. */ - if (vxlan_spec && vxlan_mask) { + if (vxlan_mask) { vni_masked = !!memcmp(vxlan_mask->vni, vni_mask, RTE_DIM(vni_mask)); -- 2.17.1
On Thu, Jul 30, 2020 at 7:35 PM Gaurav Singh <gaurav1086@gmail.com> wrote: > vxlan_mask cannot be NULL since its already being accessed > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > --- > drivers/net/bnxt/bnxt_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index 320b53d94..33a074387 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, > } > > /* Check if VNI is masked. */ > - if (vxlan_spec && vxlan_mask) { > + if (vxlan_mask) { > vni_masked = > !!memcmp(vxlan_mask->vni, vni_mask, > RTE_DIM(vni_mask)); > -- > 2.17.1 > >
31/07/2020 07:03, Ajit Khaparde: > On Thu, Jul 30, 2020 at 7:35 PM Gaurav Singh <gaurav1086@gmail.com> wrote: > > > vxlan_mask cannot be NULL since its already being accessed > > before. Remove the redundant NULL check. Do you mean vxlan_spec? > > Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> > > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> The title has a typo: bxnt > > /* Check if VNI is masked. */ > > - if (vxlan_spec && vxlan_mask) { > > + if (vxlan_mask) { This kind of implicit check is against the coding style. Except for boolean variables, we should use == or != Ajit, please check details when reviewing, thanks.
vxlan_spec cannot be NULL since its already being accessed before. Remove the redundant NULL check. Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> --- drivers/net/bnxt/bnxt_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index 320b53d94..c1c59bbe5 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, } /* Check if VNI is masked. */ - if (vxlan_spec && vxlan_mask) { + if (vxlan_mask != NULL) { vni_masked = !!memcmp(vxlan_mask->vni, vni_mask, RTE_DIM(vni_mask)); -- 2.17.1
vxlan_spec cannot be NULL since its already being accessed before. Remove the redundant NULL check. Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> --- drivers/net/bnxt/bnxt_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c index 320b53d94..c1c59bbe5 100644 --- a/drivers/net/bnxt/bnxt_flow.c +++ b/drivers/net/bnxt/bnxt_flow.c @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, } /* Check if VNI is masked. */ - if (vxlan_spec && vxlan_mask) { + if (vxlan_mask != NULL) { vni_masked = !!memcmp(vxlan_mask->vni, vni_mask, RTE_DIM(vni_mask)); -- 2.17.1
On Wed, Aug 5, 2020 at 8:52 PM Gaurav Singh <gaurav1086@gmail.com> wrote: > vxlan_spec cannot be NULL since its already being accessed > before. Remove the redundant NULL check. > > Signed-off-by: Gaurav Singh <gaurav1086@gmail.com> > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index 320b53d94..c1c59bbe5 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -554,7 +554,7 @@ bnxt_validate_and_parse_flow_type(struct bnxt *bp, > } > > /* Check if VNI is masked. */ > - if (vxlan_spec && vxlan_mask) { > + if (vxlan_mask != NULL) { > vni_masked = > !!memcmp(vxlan_mask->vni, vni_mask, > RTE_DIM(vni_mask)); > -- > 2.17.1 > >