From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5675E43270; Thu, 2 Nov 2023 17:28:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9D7840262; Thu, 2 Nov 2023 17:28:36 +0100 (CET) Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) by mails.dpdk.org (Postfix) with ESMTP id 5832E40144 for ; Thu, 2 Nov 2023 17:28:35 +0100 (CET) Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-2800bdf888dso898913a91.1 for ; Thu, 02 Nov 2023 09:28:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1698942514; x=1699547314; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=KbxAwqULtjGBmbakW8BGSQZRcL/ylTw2Rty3f1w0BXI=; b=MFBpV3fmqyYqBEAsim5jCjBxtD8ob0tuDB2h5YEdQX5rhXYk9mXDq6fZNvx4zAyQj0 zb6BTNiYjl++aafdeuhxUiinr3aJfi/QwQb/xBUSP8ikL5w2UDUR+ZNboXmvu8xKuj+Q t67E7+RhIE06QbnY0eyCqORrgbRBm4doGsMS0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698942514; x=1699547314; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KbxAwqULtjGBmbakW8BGSQZRcL/ylTw2Rty3f1w0BXI=; b=TR616N9m1puEbrIi0OmD6MlufOhJv4f1LEJnF2ZywVjC6IAnCcf9G9GuUozdyAltjI yQSbp/dDcTCVqfPktw1cvAyMvzq5iW9m/v46ot80VxpLJbNHdCVadGo/QQ4kzofPmZBh VNkG9m7w2uPRQP/V2BxHEfpSF2heiM3o9d2jvNHBQHzwOjnrC1tvgsEO7AyrDleRITMC UM1d3MHuwzt8y2aYCcLhO0SZKS1GygGzS/QeLca5MIcohGrcH1k9EeckKNqgW1W2AuZU 0SiDtngRvZkXEmbFNQ5dpeSxD9nvBxrdQhZsr91dBSeBtjfBSe1+b+xw5iA+y4h/c+Z0 PdPw== X-Gm-Message-State: AOJu0YxxK6MrbtMsM89+drR9296AIEXXef35lq/MfT29e5faiWa54M1h NYJZw2g9vOe5W/QNyhyeqMdA/EMmh7TU3a6u5MhLIg== X-Google-Smtp-Source: AGHT+IF/ieUe4I83iXmQ+Efx3l/jDTA2NfPUJsoVdlLnjvX95QcWmo/OdO5yxa4V6kTzVynN3lUfd700EyH7KvEqIFY= X-Received: by 2002:a17:90b:1648:b0:280:a69e:45ec with SMTP id il8-20020a17090b164800b00280a69e45ecmr372379pjb.5.1698942514232; Thu, 02 Nov 2023 09:28:34 -0700 (PDT) MIME-Version: 1.0 References: <20230301030610.49468-1-fengchengwen@huawei.com> <20231020100746.31520-1-fengchengwen@huawei.com> <20231020100746.31520-4-fengchengwen@huawei.com> In-Reply-To: <20231020100746.31520-4-fengchengwen@huawei.com> From: Ajit Khaparde Date: Thu, 2 Nov 2023 09:28:17 -0700 Message-ID: Subject: Re: [PATCH v2 3/7] net/bnxt: fix race-condition when report error recovery To: Chengwen Feng Cc: thomas@monjalon.net, ferruh.yigit@amd.com, konstantin.ananyev@huawei.com, Somnath Kotur , Kalesh AP , dev@dpdk.org, andrew.rybchenko@oktetlabs.ru, Honnappa.Nagarahalli@arm.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000014dfb006092de1bc" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000014dfb006092de1bc Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Oct 20, 2023 at 3:11=E2=80=AFAM Chengwen Feng wrote: > > If set data path functions to dummy functions before reports error > recovering event, there maybe a race-condition with data path threads, > this patch fixes it by setting data path functions to dummy functions > only after reports such event. > > Fixes: e11052f3a46f ("net/bnxt: support proactive error handling mode") > Cc: stable@dpdk.org > > Signed-off-by: Chengwen Feng > Acked-by: Konstantin Ananyev Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_cpr.c | 13 +++++++------ > drivers/net/bnxt/bnxt_ethdev.c | 4 ++-- > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c > index 0733cf4df2..d8947d5b5f 100644 > --- a/drivers/net/bnxt/bnxt_cpr.c > +++ b/drivers/net/bnxt/bnxt_cpr.c > @@ -168,14 +168,9 @@ void bnxt_handle_async_event(struct bnxt *bp, > PMD_DRV_LOG(INFO, "Port conn async event\n"); > break; > case HWRM_ASYNC_EVENT_CMPL_EVENT_ID_RESET_NOTIFY: > - /* > - * Avoid any rx/tx packet processing during firmware rese= t > - * operation. > - */ > - bnxt_stop_rxtx(bp->eth_dev); > - > /* Ignore reset notify async events when stopping the por= t */ > if (!bp->eth_dev->data->dev_started) { > + bnxt_stop_rxtx(bp->eth_dev); > bp->flags |=3D BNXT_FLAG_FATAL_ERROR; > return; > } > @@ -184,6 +179,12 @@ void bnxt_handle_async_event(struct bnxt *bp, > RTE_ETH_EVENT_ERR_RECOVERING= , > NULL); > > + /* > + * Avoid any rx/tx packet processing during firmware rese= t > + * operation. > + */ > + bnxt_stop_rxtx(bp->eth_dev); > + > pthread_mutex_lock(&bp->err_recovery_lock); > event_data =3D data1; > /* timestamp_lo/hi values are in units of 100ms */ > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethde= v.c > index 5c4d96d4b1..003a6eec11 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4616,14 +4616,14 @@ static void bnxt_check_fw_health(void *arg) > bp->flags |=3D BNXT_FLAG_FATAL_ERROR; > bp->flags |=3D BNXT_FLAG_FW_RESET; > > - bnxt_stop_rxtx(bp->eth_dev); > - > PMD_DRV_LOG(ERR, "Detected FW dead condition\n"); > > rte_eth_dev_callback_process(bp->eth_dev, > RTE_ETH_EVENT_ERR_RECOVERING, > NULL); > > + bnxt_stop_rxtx(bp->eth_dev); > + > if (bnxt_is_primary_func(bp)) > wait_msec =3D info->primary_func_wait_period; > else > -- > 2.17.1 > --00000000000014dfb006092de1bc Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEINYok4QTW0bE6CG5SNI2 j4DxBakUgWbZTpmV4idJYSwcMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMTEwMjE2MjgzNFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBJuQ6ebUXN3PAsdQRsOHQrQm8MwBhOD5EE4w50 Xw8r8VVkbcAwDB+hUkrO1xfLFWD+C6yMXGD++RE2BFzMVhOwh6SBdB/+Bd5lBs5ZriRzXkxqbRFr T9Y8RoZNmeKV9ce8VrHEe6+wPNqdxDQY5V3125GuH0um8r3flwKGf94xwZVWqFG4IxJsuuQu1Gjc Mty5rs1gsf8J6z9SFZlfUa9T3gYOCtjzXb3EKQmA28V9+i6aBY5V2KRfmX4lwy1d7VV/dL52MAYu UwKaQJug+SEyFqX2kdYVbIAIJ4G7gWHlLkeQSing08ENRtLpAj9agzHpgx45fTNrMMHNeq5XXXbm --00000000000014dfb006092de1bc--