From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D038BA0350; Sat, 23 May 2020 02:27:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C46AB1D9EB; Sat, 23 May 2020 02:27:05 +0200 (CEST) Received: from mail-oo1-f67.google.com (mail-oo1-f67.google.com [209.85.161.67]) by dpdk.org (Postfix) with ESMTP id D39711D9EA for ; Sat, 23 May 2020 02:27:04 +0200 (CEST) Received: by mail-oo1-f67.google.com with SMTP id u190so2509600ooa.10 for ; Fri, 22 May 2020 17:27:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=P/hyiOiIyDm9nFqAm4B3MTbnU+HS0LseiGbhd+UYZeg=; b=PDgg+FU7oTLdIij+FAD9DgkajbDRjE6M4Kc+3W0X/RTzfhv9UmdEzPL42nEv5/rn1u qsGppGXZWyvHKWsUdAK5x44kGfMpgPzfmVRQZgG99SXLa5bpaZMLLgGOLGHQczVVYA3X eqgebVqrVp6sCq1jlb/jrGtlZtvYDRUPU9/bQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=P/hyiOiIyDm9nFqAm4B3MTbnU+HS0LseiGbhd+UYZeg=; b=M5OSNEnEHak4/42a231CMncj1dKfYlboDChwYqVpkpzQNCkl7WBdN+5LIQ2wMJA+Z8 axDlDVc07UmqBVFNBOP1KymO/Dc46HGlDZcT7iX1Ew/svTVrqt6PsqQS6IIu+1AD7+2d yv2KngJsDreFKn0bedl/1nGZx9eBx1nzDJl2YjkzRUCLW1fVGqGuBrC7v/469mwQxZEJ RsdXJxieDuFb846KaMIpqRD0aE8BEwfnbsMM3gUt2swLyDePhX7R6dNwbrqeAwsf/f99 fDKkDnp7oYdtg811Q54YT3CI3fc3BQTPtVGKCaGVloXUBqcQzRaPAo5TxE/bTkdxkdRf 0WGw== X-Gm-Message-State: AOAM5318grbjYzJJvqY+2RYEkFWXvCLqbGdzO70bbLQKp4LNJfuuUH0U /mFgwxa5ZpE/18GkWRLGfG6HIV4r2WMCxOfKHVVvzF/Dp8g= X-Google-Smtp-Source: ABdhPJyP5UxXbpYOxgjk8vvSb+MAqA3ZqT+x8q7rq2vpokDqJJAmdC84vCZeFmxSsNSQKhvdoQ0zNG7cU0N32tbYaPg= X-Received: by 2002:a4a:615d:: with SMTP id u29mr5071077ooe.15.1590193622370; Fri, 22 May 2020 17:27:02 -0700 (PDT) MIME-Version: 1.0 References: <20200522212731.94269-1-ajit.khaparde@broadcom.com> In-Reply-To: <20200522212731.94269-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Fri, 22 May 2020 17:26:46 -0700 Message-ID: To: dpdk-dev Cc: Ferruh Yigit Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix a segfault during close X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 22, 2020 at 2:27 PM Ajit Khaparde wrote: > We are freeing flow_stats a little early. This results in a > segfault when the driver accesses the members during cleanup. > Move the call to bnxt_free_flow_stats_info() to prevent this. > > Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") > Signed-off-by: Ajit Khaparde > Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index e63578109..e8b4c058a 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -221,8 +221,6 @@ static void bnxt_free_cos_queues(struct bnxt *bp) > > static void bnxt_free_mem(struct bnxt *bp, bool reconfig) > { > - bnxt_free_flow_stats_info(bp); > - > bnxt_free_filter_mem(bp); > bnxt_free_vnic_attributes(bp); > bnxt_free_vnic_mem(bp); > @@ -5613,6 +5611,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool > reconfig_dev) > bnxt_uninit_ctx_mem(bp); > > bnxt_uninit_locks(bp); > + bnxt_free_flow_stats_info(bp); > rte_free(bp->ptp_cfg); > bp->ptp_cfg = NULL; > return rc; > -- > 2.21.1 (Apple Git-122.3) > >