From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23E0FA04B1; Thu, 24 Sep 2020 02:55:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6B07A1DA0E; Thu, 24 Sep 2020 02:55:03 +0200 (CEST) Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id CD03A1DA0D for ; Thu, 24 Sep 2020 02:55:02 +0200 (CEST) Received: by mail-ot1-f67.google.com with SMTP id 60so1610925otw.3 for ; Wed, 23 Sep 2020 17:55:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=11TkJbnLXqw4UsyeJKHUDEo/euY2uiKpMHrIbiJJoVY=; b=VGylMRzg5PEjoCafJEXVaj5W6WgEOqdN40TQs4jbajhOZPD9zkOf/lKY9Wiw+yNOnC LTI3YCCdFkpnTd5v1b0gNBApicOXBXa8q+o1Q6OzuG5oZOCwRqzaD0K2Ma11kVrmfK6C oCdtUcM4bTKwOw9/Y32oNlVI17WcP3GOjVFVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=11TkJbnLXqw4UsyeJKHUDEo/euY2uiKpMHrIbiJJoVY=; b=BRlXseFKOLTTj7BlALeu/wxA5qkS5E7xdeIuVy8JkT5ENqaJJPNUOBfDuskxkjUkQD OO1yvSoT39hM9WtIserb1pUoOS1Dku5kSFF7uWQbItQilFX6K4ATSGiqC3hIeTxiSdOV LQhrpIhZGQOG/uyqdMyGRdEd6JsTsSMbzDpaqfGwD4u4zu+1extrzbpdvUPOG04LN5Ju IF+unSjqk4P+A0v634o9q3zUfIMYn8wImhG509kKZQ3jw4XhnD10v5YrQWtXj0J9GVXz W7yMpAAGTw6ob6wOAEMvPl0Hvitjd4tgFnauUrJ3r9env/gCJYQ/0Qgg8poZM58hFIuc Lzag== X-Gm-Message-State: AOAM53230WDv1gPXov3NyuFgsCpTqnCpB+LVJ8tKsBb+8l1Ty5EeDPkg z3TQljoDWBENL2xEnlP/MOvZ0aXH9JwCr5T1efhpLw== X-Google-Smtp-Source: ABdhPJwgwI8zwjuUZfhdLLlfQjospCj3vBVmJO+ZQmTBr7cUoX5cAcux+9hj5jN7YT6Vo3DHjxsLMpFa97gozjkdGz4= X-Received: by 2002:a9d:ae7:: with SMTP id 94mr1542944otq.283.1600908901733; Wed, 23 Sep 2020 17:55:01 -0700 (PDT) MIME-Version: 1.0 References: <20200922140438.284862-1-lance.richardson@broadcom.com> In-Reply-To: <20200922140438.284862-1-lance.richardson@broadcom.com> From: Ajit Khaparde Date: Wed, 23 Sep 2020 17:54:45 -0700 Message-ID: To: Lance Richardson Cc: Somnath Kotur , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix drop en in rxq get information X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Sep 22, 2020 at 7:04 AM Lance Richardson wrote: > > Return correct value for rx_drop_en. Add per-queue field to > track rx_drop_en configuration. > > Fixes: 2fc201884be8 ("net/bnxt: support rxq/txq get information") > Cc: stable@dpdk.org > > Signed-off-by: Lance Richardson > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Khaparde Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 5 ++--- > drivers/net/bnxt/bnxt_rxq.c | 5 +++++ > drivers/net/bnxt/bnxt_rxq.h | 4 ++++ > 3 files changed, 11 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 05e9a6abbf..61684e0291 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -887,8 +887,7 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev, > .wthresh = 0, > }, > .rx_free_thresh = 32, > - /* If no descriptors available, pkts are dropped by default */ > - .rx_drop_en = 1, > + .rx_drop_en = BNXT_DEFAULT_RX_DROP_EN, > }; > > dev_info->default_txconf = (struct rte_eth_txconf) { > @@ -2600,7 +2599,7 @@ bnxt_rxq_info_get_op(struct rte_eth_dev *dev, uint16_t queue_id, > qinfo->nb_desc = rxq->nb_rx_desc; > > qinfo->conf.rx_free_thresh = rxq->rx_free_thresh; > - qinfo->conf.rx_drop_en = 0; > + qinfo->conf.rx_drop_en = rxq->drop_en; > qinfo->conf.rx_deferred_start = rxq->rx_deferred_start; > } > > diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c > index 793a47d112..8cc77f7f9e 100644 > --- a/drivers/net/bnxt/bnxt_rxq.c > +++ b/drivers/net/bnxt/bnxt_rxq.c > @@ -330,6 +330,11 @@ int bnxt_rx_queue_setup_op(struct rte_eth_dev *eth_dev, > rxq->rx_free_thresh = > RTE_MIN(rte_align32pow2(nb_desc) / 4, RTE_BNXT_MAX_RX_BURST); > > + if (rx_conf->rx_drop_en != BNXT_DEFAULT_RX_DROP_EN) > + PMD_DRV_LOG(NOTICE, > + "Per-queue config of drop-en is not supported.\n"); > + rxq->drop_en = BNXT_DEFAULT_RX_DROP_EN; > + > PMD_DRV_LOG(DEBUG, "RX Buf MTU %d\n", eth_dev->data->mtu); > > rc = bnxt_init_rx_ring_struct(rxq, socket_id); > diff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h > index fae92ea45c..f70cb04373 100644 > --- a/drivers/net/bnxt/bnxt_rxq.h > +++ b/drivers/net/bnxt/bnxt_rxq.h > @@ -9,6 +9,9 @@ > /* Maximum receive burst supported in vector mode. */ > #define RTE_BNXT_MAX_RX_BURST 64U > > +/* Drop by default when receive desc is not available. */ > +#define BNXT_DEFAULT_RX_DROP_EN 1 > + > struct bnxt; > struct bnxt_rx_ring_info; > struct bnxt_cp_ring_info; > @@ -34,6 +37,7 @@ struct bnxt_rx_queue { > uint8_t crc_len; /* 0 if CRC stripped, 4 otherwise */ > uint8_t rx_deferred_start; /* not in global dev start */ > uint8_t rx_started; /* RX queue is started */ > + uint8_t drop_en; /* Drop when rx desc not available. */ > > struct bnxt *bp; > int index; > -- > 2.25.1 >