From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7BEAA0A0C; Mon, 2 Aug 2021 23:17:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DBF64117A; Mon, 2 Aug 2021 23:17:50 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 8CEB341147 for ; Mon, 2 Aug 2021 23:17:49 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id z24so18020328qkz.7 for ; Mon, 02 Aug 2021 14:17:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O9zhQ1MKSewM1aEQ1nH+ED/0+TsK3B+0Zhgjbt81mks=; b=KXmMLzLQlMVfRnat+ZupPTCaSSXB/ZLa5EMZCZTQYDao6VNXj4EhNCDALVPcNgMXiC oE5n/wXkRqvhJnEsCjT+b7TMnByvewpx7e75ISnfEMIoGPR3lgLFRBrQhbpb7bknzKD9 ZHHAKROUrpCNafa4gJTKqZK6ziSmGUoG8JOKo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O9zhQ1MKSewM1aEQ1nH+ED/0+TsK3B+0Zhgjbt81mks=; b=MSO/lOIj2npGZPjMza06wlvf2c44JFxXtoXzHgkXnlz3vhBp/BYZj4pAU3oaKYPqPB nZCJVvqR3pwcaDctPlF1WJJHSl/VTD4BWmKcGvAprW7X+yyp/m2dms3MWu6ALWuxY7R0 /Hgh9cGc5khuCypfT4xxEHLxXtX8ojuXp9q3pp2PWfPB4DF8P42VjQYkJDbrcQHiePJ/ QSrM8kVDi1E5A2RehIbedFFJlIY6wDGSq/m80Br23SPP1qz6/S71HmTOtR+8AxR4t9Bg 1dhQXS9Ne1zdl8/Y2sSkoRkgL5FqICMeFmYtceOCoBZZupTAT1SAiyJz4pkCAdZZDNLg AcKA== X-Gm-Message-State: AOAM532Z4LRtM9tTR5BqP90hW2KDJ/7jehV8PpNDaFKgnUm+sPcUc3rf oWIRj0OZTvjPj1uBnZek2HcOpOoscZfd2bVKjI8GCQ== X-Google-Smtp-Source: ABdhPJzbqhvqgD2OjlZNwbPkx6/VJkZeVPPVLi4wOzfoRTn+lIYOEGlrMJPNtbPzmm8L2EEw2IsMAw8JpJoPSiOoQlU= X-Received: by 2002:a37:394:: with SMTP id 142mr17821385qkd.423.1627939068804; Mon, 02 Aug 2021 14:17:48 -0700 (PDT) MIME-Version: 1.0 References: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> <20210802195723.2153114-1-andrew.rybchenko@oktetlabs.ru> <20210802195723.2153114-2-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210802195723.2153114-2-andrew.rybchenko@oktetlabs.ru> From: Ajit Khaparde Date: Mon, 2 Aug 2021 14:17:32 -0700 Message-ID: To: Andrew Rybchenko Cc: Thomas Monjalon , Ferruh Yigit , Ori Kam , dpdk-dev , Eli Britstein , Ilya Maximets , Matan Azrad , Ivan Malov , Viacheslav Galaktionov Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000ef5abc05c89a19ff" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v3 2/2] ethdev: announce clarification of implicit filter by port X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000ef5abc05c89a19ff Content-Type: text/plain; charset="UTF-8" On Mon, Aug 2, 2021 at 12:57 PM Andrew Rybchenko wrote: > > Transfer flow rules may be applied to traffic entering switch from > many sources. There are flow API pattern items which allow to specify > ingress port match criteria explicitly, but it is not documented > if ethdev port used to create flow rule adds any implicit match > criteria and how it coexists with explicit ones. > > These aspects should be documented and drivers and applications > which use it in a a different way must be fixed. nit! "in a different way..." otherwise Acked-by: Ajit Khaparde > > Signed-off-by: Andrew Rybchenko > Acked-by: Ori Kam > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 6e6413c89f..4d174c8952 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -163,3 +163,8 @@ Deprecation Notices > clarification. Structure rte_flow_action_port_id will be extended to > specify traffic direction to represented entity or ethdev port itself in > DPDK 21.11. > + > +* ethdev: Flow API documentation is unclear if ethdev port used to create > + a flow rule adds any implicit match criteria in the case of transfer rules. > + The semantics will be clarified in DPDK 21.11 and it will require fixes in > + drivers and applications which interpret it in a different way. > -- > 2.30.2 > --000000000000ef5abc05c89a19ff--