From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6D8FA0C45; Mon, 22 Nov 2021 06:20:16 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4E8924014E; Mon, 22 Nov 2021 06:20:16 +0100 (CET) Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by mails.dpdk.org (Postfix) with ESMTP id 2BDD64003C for ; Mon, 22 Nov 2021 06:20:15 +0100 (CET) Received: by mail-io1-f54.google.com with SMTP id w22so21751639ioa.1 for ; Sun, 21 Nov 2021 21:20:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dp13jkcoc3y+hL8TNZrvUrj1+9zBU0etfDoYyZIFXPY=; b=AjjO8PSa0tkOjZz9PtLmZu0QJ0IqqLbZGgMeYXkvphGDVlF07RWuIhTW4S8T0No/Gg EZlGNjEYxccQJwTXvEKlarveTTHC0KnW2eVgXzKswj85lPb0fxpvKH/m59+OoiYOsM3F NxRMdOaMEoHJvRbU6ISKTdkjiS4yQ2fwdcNr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dp13jkcoc3y+hL8TNZrvUrj1+9zBU0etfDoYyZIFXPY=; b=ul3nS+bjc5yQvxGlQrRdfwmwzETfVSIiAOtxRxP0dSQziUbA8USoaZeDpc548bwTjV O9hrAe03ekIRMK1Eu4VZpL0MCIQclfVmdJ2bLVSwIWLQcFdbNO++q4ggxWXFBabWDLS1 5AuaWr90+HVLeGB+5idG8aTV1Tp0Z33ktNJPbpFcLiB7f+KYrlnC+6d/jqCkw8vlHHXM TH4ZjTCd2krBzVNO7MHUaQD5YuzyWeogXY2xVtBxqdf2bKAkILPmvXwNgRofdTYdldn5 2BbUbE8+z5DpqrRSRG+FpLUpkFgESe8lNuKAHhSpVAHOZweub4wu7Pnk90zknVoewIQR G8hg== X-Gm-Message-State: AOAM532NAp50vSAZqsSADt/mfafV2ogy4vDcXUhgrliQdrImGIELqCgI sw0+h4LGBuXDMzFeVUukiEWB6wBvdzhKGIVvgTENUme36AiXjA== X-Google-Smtp-Source: ABdhPJxF3nfiQZrHuTPN+2YipSbUt8RmXt747zkamXxiriRjASbvfyHSHxnyUKQTO/xbDGTwn+znqD9Czp70QC33XDE= X-Received: by 2002:a05:6602:1410:: with SMTP id t16mr20035042iov.160.1637558414444; Sun, 21 Nov 2021 21:20:14 -0800 (PST) MIME-Version: 1.0 References: <20211122045314.8860-1-somnath.kotur@broadcom.com> In-Reply-To: <20211122045314.8860-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Sun, 21 Nov 2021 21:19:58 -0800 Message-ID: Subject: Re: [PATCH] net/bnxt: restore fast-path API pointers post recovery To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , Kalesh AP Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Nov 21, 2021 at 8:59 PM Somnath Kotur wrote: > > In bnxt_dev_recover(), restore the newly introduced fast-path API pointers > (struct rte_eth_fp_ops)->rx_pkt_burst to the real burst routines instead of > the dummy ones, once error recovery has successfully completed. > > Fixes: c87d435a4d79 ("ethdev: copy fast-path API into separate structure") > > Signed-off-by: Somnath Kotur > Reviewed-by: Kalesh AP Squashed with previous commit [1]. [1] https://patchwork.dpdk.org/project/dpdk/patch/20211119035041.4493-1-somnath.kotur@broadcom.com/ > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index c1bdf9a921..f79f33ab4e 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4345,6 +4345,12 @@ static void bnxt_dev_recover(void *arg) > goto err_start; > } > > + rte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst = > + bp->eth_dev->rx_pkt_burst; > + rte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst = > + bp->eth_dev->tx_pkt_burst; > + rte_mb(); > + > rc = bnxt_restore_filters(bp); > if (rc) > goto err_start; > -- > 2.28.0.497.g54e85e7 >