From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6880A0562; Fri, 19 Mar 2021 01:16:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B99440143; Fri, 19 Mar 2021 01:16:34 +0100 (CET) Received: from mail-qv1-f53.google.com (mail-qv1-f53.google.com [209.85.219.53]) by mails.dpdk.org (Postfix) with ESMTP id 459674003F for ; Fri, 19 Mar 2021 01:16:33 +0100 (CET) Received: by mail-qv1-f53.google.com with SMTP id cx5so4170601qvb.10 for ; Thu, 18 Mar 2021 17:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RM0ao6XqlvS4aVEeNrpVWVLmXk9ftPwXt917roJkNZc=; b=NxjlhpExLVXSuMN5xxA9PsyNyQfUAV8U/pnsqON9mcYl5vNsIbeSNWU5sjgz+r6Uk0 rlb8f4zny/GvhoY498QcP6I015moZXjO6M0JIPxb7opZcHbZxDDwdcuj/JQMS6vVfGyz YtRpuPelRNaQ1bEwgY95Ne8cwKsmOIOtRkuX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RM0ao6XqlvS4aVEeNrpVWVLmXk9ftPwXt917roJkNZc=; b=P9WEvQy0aY/Re/Wo20vgUbup/t6rhhUPIckgwny2sC0tPsYQ2JwzKts9U3k/z4qXYZ Hqj6LDvMbCwh9HdOAPvvUuMQLQVKD3+8xESRs52+7Gauq3Nh8w3NdLFFzDyIb6JgB3O4 RkeZyveMgzoILg6v8atTumpzR8aQ8dE3RdN//ju59zlc/47ODzYyHzm8TvC18V82iaTF fcEjkJUGeFTwn830dxDzvq3c37bg+Suv/rUii1/g0L3AgnsKlTSxn2zkRkiIyZ3u9Ygo qvBioO9aZvbMTCYP2u8Dj005mcwLEj92f+FAibp+eGeTWmTSzH19kv3R0FW3epSjNqGS Ag7g== X-Gm-Message-State: AOAM530IpuSZfsABFLE0K62ORGK1KjweCnZ7rTvNdXXRaesUb2xC1dH/ si+yKpTfUawZuqmINu8Ze/Nu6qsrM8YuUdUxFi7dVg== X-Google-Smtp-Source: ABdhPJw21uqr1prxeIwNagnU2mqNabD2uHHIKt4QWjOQOyLktAwJ/pZ/C52uznly040lQM+gde2CwGUGudH1YiNfs8k= X-Received: by 2002:a05:6214:80d:: with SMTP id df13mr7039692qvb.55.1616112992585; Thu, 18 Mar 2021 17:16:32 -0700 (PDT) MIME-Version: 1.0 References: <20210318093523.1689-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210318093523.1689-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Thu, 18 Mar 2021 17:16:16 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000db6b0f05bdd8a0d5" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix link state operations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000db6b0f05bdd8a0d5 Content-Type: text/plain; charset="UTF-8" On Thu, Mar 18, 2021 at 2:13 AM Kalesh A P wrote: > > From: Kalesh AP > > VFs does not have the privilege to change link configuration. > But the driver silently returns success to these ethdev callbacks > without actually issuing the HWRM command to bring the link up/down. > > Fixes: 5c206086feaa ("net/bnxt: add link state operations") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Kumar Khaparde Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 1997783..3665f31 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1268,6 +1268,9 @@ static int bnxt_dev_set_link_up_op(struct rte_eth_dev *eth_dev) > struct bnxt *bp = eth_dev->data->dev_private; > int rc = 0; > > + if (!BNXT_SINGLE_PF(bp)) > + return -ENOTSUP; > + > if (!bp->link_info->link_up) > rc = bnxt_set_hwrm_link_config(bp, true); > if (!rc) > @@ -1281,6 +1284,9 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev) > { > struct bnxt *bp = eth_dev->data->dev_private; > > + if (!BNXT_SINGLE_PF(bp)) > + return -ENOTSUP; > + > eth_dev->data->dev_link.link_status = 0; > bnxt_set_hwrm_link_config(bp, false); > bp->link_info->link_up = 0; > -- > 2.10.1 > --000000000000db6b0f05bdd8a0d5--