From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86131A0562; Fri, 19 Mar 2021 01:16:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CB7D140FBE; Fri, 19 Mar 2021 01:16:57 +0100 (CET) Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by mails.dpdk.org (Postfix) with ESMTP id 20FDE4003F for ; Fri, 19 Mar 2021 01:16:56 +0100 (CET) Received: by mail-qk1-f174.google.com with SMTP id g15so1218851qkl.4 for ; Thu, 18 Mar 2021 17:16:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eqtik+XvbPVoZ1EZ6XeWG8PF1Lpju7h6d9Wr5CovU8s=; b=X6nHg9MZl3goolAETDympiczsPIKYoxExkpzMk3pQ4kGbtOgURX0WiU4t9yKgKa4jL BO4xvaeN25JSb9SX6Wp75EEWzRNuboOqEMN7Zv2+N0P54mF/Hm3r1z02tJEAqWjbqRhT c0b4vRRm1Hox3MpO5pz1viAb+vF1I++W/r8is= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eqtik+XvbPVoZ1EZ6XeWG8PF1Lpju7h6d9Wr5CovU8s=; b=mYRuH4AIumq0FLiVNjp02waVPs+jHaaPA/p5IrecRz4Tel3mlwLwD7TMAwhChjoWXZ WcX/jHNDFxPGnDPvpSRNMxdXx5/bBawyjg7ZW1r/9Hs9w4+wMBnLpRY4JhM4sAsGJKvc vGIlNezMSM6ny4MLz5SaVGZGrylTVzQTmtj3RiyuF15Vb2m5ce1SarkPryHaEE3LhAQS DMKPA9edXmIhfSXDr2SUgrH1hXn1GurgmDFK3I30LkaZO+0zAddC+S3ORSkYXMDa5+vD //9OnIcA7kixL/FMtFax0Pg53FFrgA6vgmtir62LRnrd2HYS0Qq3NRY3UmIVeufZCM7j IT0A== X-Gm-Message-State: AOAM531aPcVPpvsrRbtozpqMHPgVHVP2mYQCkZRzu4Oxpj9Q4dZGZYiy +krIh0svqfPWbRK6XGBXkINr82Butkl50Uet89AJgg== X-Google-Smtp-Source: ABdhPJxdnKRhq1y+zDoiJzSmhhHbyk8FKTFBVsTQLFYUYM93VRzqZzmbeCe0jfOxewxRQ9VlimKyGDdlT8rqCM8pMvA= X-Received: by 2002:a37:c08:: with SMTP id 8mr7189198qkm.423.1616113015426; Thu, 18 Mar 2021 17:16:55 -0700 (PDT) MIME-Version: 1.0 References: <20210318093523.1689-1-kalesh-anakkur.purayil@broadcom.com> <20210318093523.1689-2-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210318093523.1689-2-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Thu, 18 Mar 2021 17:16:39 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000038d11e05bdd8a2ed" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 2/2] net/bnxt: fix unsupported handling in PTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000038d11e05bdd8a2ed Content-Type: text/plain; charset="UTF-8" On Thu, Mar 18, 2021 at 2:13 AM Kalesh A P wrote: > > From: Kalesh AP > > Fixed to return error when PTP support is not supported on the port. > Also, removed an unnecessary check inside bnxt_get_rx_ts(). > > Fixes: b11cceb83a34 ("net/bnxt: support timesync") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Kumar Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 3665f31..4fd9653 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -3395,9 +3395,6 @@ static int bnxt_get_rx_ts(struct bnxt *bp, uint64_t *ts) > uint16_t port_id; > uint32_t fifo; > > - if (!ptp) > - return -ENODEV; > - > fifo = rte_le_to_cpu_32(rte_read32((uint8_t *)bp->bar0 + > ptp->rx_mapped_regs[BNXT_PTP_RX_FIFO])); > if (!(fifo & BNXT_PTP_RX_FIFO_PENDING)) > @@ -3430,7 +3427,7 @@ bnxt_timesync_write_time(struct rte_eth_dev *dev, const struct timespec *ts) > struct bnxt_ptp_cfg *ptp = bp->ptp_cfg; > > if (!ptp) > - return 0; > + return -ENOTSUP; > > ns = rte_timespec_to_ns(ts); > /* Set the timecounters to a new value. */ > @@ -3450,7 +3447,7 @@ bnxt_timesync_read_time(struct rte_eth_dev *dev, struct timespec *ts) > int rc = 0; > > if (!ptp) > - return 0; > + return -ENOTSUP; > > if (BNXT_CHIP_P5(bp)) > rc = bnxt_hwrm_port_ts_query(bp, BNXT_PTP_FLAGS_CURRENT_TIME, > @@ -3472,7 +3469,7 @@ bnxt_timesync_enable(struct rte_eth_dev *dev) > int rc; > > if (!ptp) > - return 0; > + return -ENOTSUP; > > ptp->rx_filter = 1; > ptp->tx_tstamp_en = 1; > @@ -3513,7 +3510,7 @@ bnxt_timesync_disable(struct rte_eth_dev *dev) > struct bnxt_ptp_cfg *ptp = bp->ptp_cfg; > > if (!ptp) > - return 0; > + return -ENOTSUP; > > ptp->rx_filter = 0; > ptp->tx_tstamp_en = 0; > @@ -3540,7 +3537,7 @@ bnxt_timesync_read_rx_timestamp(struct rte_eth_dev *dev, > uint64_t ns; > > if (!ptp) > - return 0; > + return -ENOTSUP; > > if (BNXT_CHIP_P5(bp)) > rx_tstamp_cycles = ptp->rx_timestamp; > @@ -3563,7 +3560,7 @@ bnxt_timesync_read_tx_timestamp(struct rte_eth_dev *dev, > int rc = 0; > > if (!ptp) > - return 0; > + return -ENOTSUP; > > if (BNXT_CHIP_P5(bp)) > rc = bnxt_hwrm_port_ts_query(bp, BNXT_PTP_FLAGS_PATH_TX, > @@ -3584,7 +3581,7 @@ bnxt_timesync_adjust_time(struct rte_eth_dev *dev, int64_t delta) > struct bnxt_ptp_cfg *ptp = bp->ptp_cfg; > > if (!ptp) > - return 0; > + return -ENOTSUP; > > ptp->tc.nsec += delta; > ptp->tx_tstamp_tc.nsec += delta; > -- > 2.10.1 > --00000000000038d11e05bdd8a2ed--