From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5A18A0524; Mon, 3 May 2021 00:30:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6AFA440150; Mon, 3 May 2021 00:30:28 +0200 (CEST) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mails.dpdk.org (Postfix) with ESMTP id 4C51C40142 for ; Mon, 3 May 2021 00:30:27 +0200 (CEST) Received: by mail-qk1-f181.google.com with SMTP id q127so3496443qkb.1 for ; Sun, 02 May 2021 15:30:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zOEJC75nvWfIojI9NeMsiI+Bp4G1Akl7Vtnhl+aViB0=; b=cvcpZBV8oB4lqOyS2gLFjW1hhBxezF7ty+hTahl6NCmOEeTSRHXYfNU9wRO2xdeoBf GRWck4H7Zxra5E36mFFDJ/yNj2QmyJYMcmYdgN6ikn14OnWZORS/qe7Dh3rzaI0C5biv xW0t5k9OX/nlgZHo++wteSAw1ndEpyC3lRGlg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zOEJC75nvWfIojI9NeMsiI+Bp4G1Akl7Vtnhl+aViB0=; b=qx2eePmOA3XtBRs47KmpfHDcGut+h4hu2X1JAaR18Rw0e2uj7wchirzZrSvnpRS1+0 sxZ3MTxBhWb3MY82M8ddnj88ynjzgIBXS4qz01LKT6cLLA0iiVsimZQV+M3ybp5neX76 nqGav2qaibfe0ArGjYDVK7Bw70NR6+zPBr/i8k6Qd+EbVYx+hr6wW6UZ3/lX863S2a4u ZF4hvmuqTopeDvK/c3Vca6eioxQyKkIQuvlwBAeb/ewhvLk60PBoATVFGVqI33xSxwLg rSvyB6J1iyeB5PzACWnd0j67iFTHTIkmpww9tkFDvWUJx83Lk46lzXwwEkm+gqBoTbIG V8PQ== X-Gm-Message-State: AOAM531y+1e0IsdlGmH3mKLUzluHt5qeqFGjHzguYyGuRUfZypuWGRGf pKOjkPffOYGKz8qmYzZBywukLj6EbwIUT2Ho5FFxQg== X-Google-Smtp-Source: ABdhPJy3aAUmfWZ9XHr9Ra9jS95fL8MoxTeLDqoXfvmU25v2WSR4ujWmH7fjx0kytdY2ZqH1rGa03eDQsSFt/fsR0kc= X-Received: by 2002:a37:e412:: with SMTP id y18mr16934345qkf.40.1619994626482; Sun, 02 May 2021 15:30:26 -0700 (PDT) MIME-Version: 1.0 References: <20210426060755.12821-1-somnath.kotur@broadcom.com> In-Reply-To: <20210426060755.12821-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Sun, 2 May 2021 15:30:09 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000045a34d05c160641d" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: refactor multi queue Rx configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000045a34d05c160641d Content-Type: text/plain; charset="UTF-8" On Sun, Apr 25, 2021 at 11:09 PM Somnath Kotur wrote: > Eliminate separate codepath/handling for single queue > as the multiqueue code path takes care of it as well. > The only difference being the end_grp_id being 1 > now instead of 0 for single queue, but that does not matter > for single queue and does not alter any functionality. > > Fixes: 6133f207970c ("net/bnxt: add Rx queue create/destroy") > > Signed-off-by: Somnath Kotur > Reviewed-by: Ajit Khaparde > Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_rxq.c | 30 ------------------------------ > 1 file changed, 30 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c > index 2b0d3d4ac7..45e0c3d01c 100644 > --- a/drivers/net/bnxt/bnxt_rxq.c > +++ b/drivers/net/bnxt/bnxt_rxq.c > @@ -40,35 +40,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp) > > bp->nr_vnics = 0; > > - /* Single queue mode */ > - if (bp->rx_cp_nr_rings < 2) { > - vnic = &bp->vnic_info[0]; > - if (!vnic) { > - PMD_DRV_LOG(ERR, "VNIC alloc failed\n"); > - rc = -ENOMEM; > - goto err_out; > - } > - vnic->flags |= BNXT_VNIC_INFO_BCAST; > - bp->nr_vnics++; > - > - rxq = bp->eth_dev->data->rx_queues[0]; > - rxq->vnic = vnic; > - > - vnic->func_default = true; > - vnic->start_grp_id = 0; > - vnic->end_grp_id = vnic->start_grp_id; > - filter = bnxt_alloc_filter(bp); > - if (!filter) { > - PMD_DRV_LOG(ERR, "L2 filter alloc failed\n"); > - rc = -ENOMEM; > - goto err_out; > - } > - filter->mac_index = 0; > - filter->flags |= > HWRM_CFA_L2_FILTER_ALLOC_INPUT_FLAGS_OUTERMOST; > - STAILQ_INSERT_TAIL(&vnic->filter, filter, next); > - goto out; > - } > - > /* Multi-queue mode */ > if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_VMDQ_DCB_RSS) { > /* VMDq ONLY, VMDq+RSS, VMDq+DCB, VMDq+DCB+RSS */ > @@ -163,7 +134,6 @@ int bnxt_mq_rx_configure(struct bnxt *bp) > end_grp_id += nb_q_per_grp; > } > > -out: > bp->rx_num_qs_per_vnic = nb_q_per_grp; > > if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) { > -- > 2.28.0.497.g54e85e7 > > --00000000000045a34d05c160641d--