From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 766A4A0C43; Wed, 15 Sep 2021 05:48:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58F3D4014F; Wed, 15 Sep 2021 05:48:29 +0200 (CEST) Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) by mails.dpdk.org (Postfix) with ESMTP id 784AA4003C for ; Wed, 15 Sep 2021 05:48:28 +0200 (CEST) Received: by mail-il1-f182.google.com with SMTP id b15so1436021ils.10 for ; Tue, 14 Sep 2021 20:48:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RxmCVUfGO0gtSUaD8BRIcwYYA+F29C6m0cvup/mBYT4=; b=QDa8mbxdwKVSvOtQczq9UdzThqgBgDW3jiu0MgbKR7RUM7JtwJd+NVZh9IpGZGqc/0 a4+lPM3A0v5n1POGQwwKuv8NKGcBa35de4dzyMPizI52uWsNyrCYBtBfYgzU1/96goJn rJL7KJveW36iEP7UXnjIVKYiSGP/ntCe51/rw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RxmCVUfGO0gtSUaD8BRIcwYYA+F29C6m0cvup/mBYT4=; b=5aXBxtW+OQyhWIfzmanqjgtA74JGSKtq2dgHv/O5YX8Fc/wrkn1ZJ/RZV9qOFb8e/+ FvyWGZUvPx+kcrj+CMRu0ShlJDXa9a4V70LPWWYnOX8nGfGxQBgMufCnSkPWOUB3rouW BOCuVmP7akGL+uGy2K41kd4IarsBxEG/P91eXK5/YdM8CBLHQ+aEtZxOqtriclXWlhE9 UTzHZAwhEC5m6Jz4+gYZ7B1sC79fFs+QuPeloZt5PqMz/lz+lL0yxZskoFLW9Ko607LE 7QB0dE3TMLoVxEJ/8wtscMbuBkTJ1s1a8yiIkyvn0GVYFUaJKAmNCyfdssCVrOZsLpg7 aa1g== X-Gm-Message-State: AOAM533DmZ+b/GpvNKiYJriCL3Ydr0N8GewzSpQi4yNR7saoGd21wgQi WRGpX7ZAQQSFrGfb14FyKUvn0Hb6wQgsFQOx8W36wQ== X-Google-Smtp-Source: ABdhPJx5zXiuuto8g8lted/L8Yn6wFZOc1EahEmjVLXLNls9QY3e6NkEhJaXDozFfWtB8CUuD6Q8u+PQHo5W9SkI4IY= X-Received: by 2002:a92:6904:: with SMTP id e4mr14824240ilc.311.1631677707574; Tue, 14 Sep 2021 20:48:27 -0700 (PDT) MIME-Version: 1.0 References: <20210914125058.215396-1-lance.richardson@broadcom.com> In-Reply-To: <20210914125058.215396-1-lance.richardson@broadcom.com> From: Ajit Khaparde Date: Tue, 14 Sep 2021 20:48:11 -0700 Message-ID: To: Lance Richardson Cc: Somnath Kotur , dpdk-dev , Kalesh Anakkur Purayil Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000002d414705cc009264" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix Rx queue startup state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000002d414705cc009264 Content-Type: text/plain; charset="UTF-8" On Tue, Sep 14, 2021 at 5:51 AM Lance Richardson wrote: > > Since the addition of support for runtime queue setup, > receive queues that are started by default no longer > have the correct state. Fix this by setting the state > when a port is started. > > Fixes: 0105ea1296c9 ("net/bnxt: support runtime queue setup") > Signed-off-by: Lance Richardson > Reviewed-by: Ajit Khaparde > Reviewed-by: Somnath Kotur > Reviewed-by: Kalesh Anakkur Purayil Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index d6e3847963..097dd10de9 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -482,6 +482,12 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) > rxq->vnic->fw_grp_ids[j] = INVALID_HW_RING_ID; > else > vnic->rx_queue_cnt++; > + > + if (!rxq->rx_deferred_start) { > + bp->eth_dev->data->rx_queue_state[j] = > + RTE_ETH_QUEUE_STATE_STARTED; > + rxq->rx_started = true; > + } > } > > PMD_DRV_LOG(DEBUG, "vnic->rx_queue_cnt = %d\n", vnic->rx_queue_cnt); > -- > 2.25.1 > --0000000000002d414705cc009264--