From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF82AA0546; Wed, 7 Apr 2021 05:05:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B2DDF141009; Wed, 7 Apr 2021 05:05:20 +0200 (CEST) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id 95032407FF for ; Wed, 7 Apr 2021 05:05:19 +0200 (CEST) Received: by mail-qk1-f173.google.com with SMTP id c3so17345403qkc.5 for ; Tue, 06 Apr 2021 20:05:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=91EuilFXxZxVT6ilgD1kwnpvSw/sPrXcPPExppRFynk=; b=hQn0Bx8mLSUGQytfZ2lVaHU6LD7yA5b3GqCeyElEgBCwVJdfOkzbrCoK0vqAVPfpa3 rGX+UjV5aT1LEKSrauRv6SwEOCdmD8IyTu+FcTLLa5O4R/ZeQwg3u/0h3mSewFUUbFRm lA8lIxoYCG+V3jvSlUFg0zX09z0Junr+Shsgo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=91EuilFXxZxVT6ilgD1kwnpvSw/sPrXcPPExppRFynk=; b=oeh6j+YP266qkk0FT4X4RWUJlBw6K8MU7nFPa8dMkcVQ+pngpQCAy/fLWdK/86fddZ DaPzMTQgLzn0j+uksZK2hEQmvIuCakfCZ6H2cGzQLTw3gZy/NNLpfsazgyMDgSrYHOZt dSflMLGbvjhGdtSO4/+gT1HzLQhk+W3sDej4DvzGNOr102QntpteTTJkNj76e+0n13pM +NJ1RuSl3R8f1LtqBZR92gEPCDgpi131x5FIOHgeVVI1SlDh4uETf9hY39ygJC35Dt3W GEm8/2J5LPGag5Fu7C6tT8CmqNYy7u1Sc7LRpnYUxz7oD0lSs2s+sAbfvq7C98OOUzEF 5TtA== X-Gm-Message-State: AOAM532bE9SNlJH60kzrIoJJMVsLQMGrzbgCTzue2W14dWgygnrCJXJf 5uM0U9lurn4W1grpZHgQrShWMM2+mVuOIMERK7HetQ== X-Google-Smtp-Source: ABdhPJwZ3t4yRHdivXpvUV77diKt22lxIWYe9qcGhzst0WMCZalTw+TiaH3XlX9zHz+b+CgXR1oOrpXkNScAySDf0d0= X-Received: by 2002:a05:620a:749:: with SMTP id i9mr1188651qki.40.1617764718923; Tue, 06 Apr 2021 20:05:18 -0700 (PDT) MIME-Version: 1.0 References: <20210406060403.29938-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210406060403.29938-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Tue, 6 Apr 2021 20:05:02 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000006b7bb705bf593318" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix FW unregister log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000006b7bb705bf593318 Content-Type: text/plain; charset="UTF-8" On Mon, Apr 5, 2021 at 10:42 PM Kalesh A P wrote: > > From: Kalesh AP > > The "Unregistered with fw" message was being logged in a wrong function. > Moved it to the right place. > > Fixes: a7dda7e0a00b ("net/bnxt: log port id in async events") > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Kumar Khaparde Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_hwrm.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 6a70b6e..a119fc3 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -1364,6 +1364,9 @@ int bnxt_hwrm_func_driver_unregister(struct bnxt *bp, uint32_t flags) > HWRM_CHECK_RESULT(); > HWRM_UNLOCK(); > > + PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n", > + bp->eth_dev->data->port_id); > + > return rc; > } > > @@ -1448,8 +1451,6 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf) > HWRM_CHECK_RESULT(); > HWRM_UNLOCK(); > > - PMD_DRV_LOG(DEBUG, "Port %u: Unregistered with fw\n", > - bp->eth_dev->data->port_id); > return rc; > } > > -- > 2.10.1 > --0000000000006b7bb705bf593318--