From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 55498A0C43;
	Fri,  1 Oct 2021 00:12:24 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D74AA4067A;
	Fri,  1 Oct 2021 00:12:23 +0200 (CEST)
Received: from mail-il1-f174.google.com (mail-il1-f174.google.com
 [209.85.166.174])
 by mails.dpdk.org (Postfix) with ESMTP id 419E540040
 for <dev@dpdk.org>; Fri,  1 Oct 2021 00:12:22 +0200 (CEST)
Received: by mail-il1-f174.google.com with SMTP id y17so252388ilb.9
 for <dev@dpdk.org>; Thu, 30 Sep 2021 15:12:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=kbhpsNesmRrO8F7nxsuNMD8zxrBuZk9vQEmug2R2SjI=;
 b=GnvUk0tHHB02Njxp+NzIdn71Xf7Y6SYaYma3IrxrgIciZ5Fvfb4FQ/kTeYHs9FZ9aJ
 gTi679U+cIqLEcsK4VfEO4PSGgTrLO12ZkpsgddaEYEI3DNow1jFMlXQgDe/Ua5hhfRh
 LIq7W/0Yhnip2lsXV16GBF3REYyCaBOXNy3CA=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=kbhpsNesmRrO8F7nxsuNMD8zxrBuZk9vQEmug2R2SjI=;
 b=VCSVc+X1rlyJCTwrz3zK+sZTjv9r71lw4AK8OH4xe90mCuxpmazWSJNg+ukYY5PSLr
 akw6oHpFfNKY+0Tk6o67VcemQMJIDocBLxWDrMsI7p3+7hQPMU7dIvcUbdMu2NamXgFE
 oDWnNCTFpLjfJF1k+THKXU3z7RGvlaxAChoNhzHoh1Reblb+wgIMakESBCe6FTbOjxrD
 WYQtEX8FF4y/MV7pCZUEypOE4Vkf7JuJKZwr0BBv6qXeTykw2sSYwB/HEMm/RNxZKyqN
 Ry9af8AeG50wxxEK9/3xhky7YR8ECJV5HuAlsjK3TOl0Vh7L5RW7s5HS1aNmWVR0PWhu
 hlzQ==
X-Gm-Message-State: AOAM5325ID3u1L7Cr12SRcZ0mswZPRQGkppQT9JpmrwyIO5xvekCWr8W
 bgh/Z3n0m7/JWQ2nwKq6aJRwXbQV5hllYvvi7ilCJA==
X-Google-Smtp-Source: ABdhPJz7tnYSfTJQ0MUgCl533aKNrguA/RjiB+D/bw6U2ZjMG2KtLX3lvvqk4bOGYiPVKKUXfxAZwUWyMpcGaPKT6Lk=
X-Received: by 2002:a05:6e02:1985:: with SMTP id
 g5mr6269917ilf.311.1633039941301; 
 Thu, 30 Sep 2021 15:12:21 -0700 (PDT)
MIME-Version: 1.0
References: <20210902142359.28138-1-ivan.malov@oktetlabs.ru>
 <20210923112012.14595-1-ivan.malov@oktetlabs.ru>
 <20210923112012.14595-2-ivan.malov@oktetlabs.ru>
 <CACZ4nhtMqZ6mR3+2jo9suV2DxJdxzaPWcZmkV2YZFXOqSU_T5g@mail.gmail.com>
 <f48e50a2-6d95-18b0-7cbe-4bdfafa19346@oktetlabs.ru>
In-Reply-To: <f48e50a2-6d95-18b0-7cbe-4bdfafa19346@oktetlabs.ru>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Thu, 30 Sep 2021 15:12:05 -0700
Message-ID: <CACZ4nhvQzxYcTE=g2FjPCPa_DfgNmO1NABs7P0qRxwEysDOEww@mail.gmail.com>
To: Ivan Malov <Ivan.Malov@oktetlabs.ru>
Cc: dpdk-dev <dev@dpdk.org>, Andy Moreton <amoreton@xilinx.com>, 
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ray Kinsella <mdr@ashroe.eu>,
 Jerin Jacob <jerinj@marvell.com>, Wisam Jaddo <wisamm@nvidia.com>, 
 Xiaoyun Li <xiaoyun.li@intel.com>, Thomas Monjalon <thomas@monjalon.net>, 
 Ferruh Yigit <ferruh.yigit@intel.com>, Ori Kam <orika@nvidia.com>
Content-Type: multipart/signed; protocol="application/pkcs7-signature";
 micalg=sha-256; boundary="0000000000009f642405cd3dbdd1"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add API to negotiate delivery
 of Rx meta data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

--0000000000009f642405cd3dbdd1
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 30, 2021 at 3:01 PM Ivan Malov <Ivan.Malov@oktetlabs.ru> wrote:
>
> Hi Ajit,
>
> On 01/10/2021 00:48, Ajit Khaparde wrote:
> > ::::
> >> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> >> index 97ae52e17e..7a8da3d7ab 100644
> >> --- a/app/test-pmd/testpmd.c
> >> +++ b/app/test-pmd/testpmd.c
> >> @@ -1485,10 +1485,36 @@ static void
> >>   init_config_port_offloads(portid_t pid, uint32_t socket_id)
> >>   {
> >>          struct rte_port *port = &ports[pid];
> >> +       uint64_t rx_meta_features = 0;
> >>          uint16_t data_size;
> >>          int ret;
> >>          int i;
> >>
> >> +       rx_meta_features |= RTE_ETH_RX_META_USER_FLAG;
> >> +       rx_meta_features |= RTE_ETH_RX_META_USER_MARK;
> >> +       rx_meta_features |= RTE_ETH_RX_META_TUNNEL_ID;
> >> +
> >> +       ret = rte_eth_rx_meta_negotiate(pid, &rx_meta_features);
> >> +       if (ret == 0) {
> >> +               if (!(rx_meta_features & RTE_ETH_RX_META_USER_FLAG)) {
> >> +                       TESTPMD_LOG(INFO, "Flow action FLAG will not affect Rx mbufs on port %u\n",
> > Log level info might be a little too noisy?
>
> Do you really think so? But main() sets default log level to DEBUG, quote:
>      rte_log_set_level(testpmd_logtype, RTE_LOG_DEBUG);
>
> If I go for DEBUG instead of INFO here, it won't get any quieter, will it?
You are right. It won't.
But then three extra messages per port will stand out. But that's my opinion.
Maybe you could log the message when a flow is created with any of the
meta features?

>
> >
> >> +                                   pid);
> >> +               }
> >> +
> >> +               if (!(rx_meta_features & RTE_ETH_RX_META_USER_MARK)) {
> >> +                       TESTPMD_LOG(INFO, "Flow action MARK will not affect Rx mbufs on port %u\n",
> >> +                                   pid);
> >> +               }
> >> +
> >> +               if (!(rx_meta_features & RTE_ETH_RX_META_TUNNEL_ID)) {
> >> +                       TESTPMD_LOG(INFO, "Flow tunnel offload support might be limited or unavailable on port %u\n",
> >> +                                   pid);
> >> +               }
> > :::
> >>
>
> --
> Ivan M

--0000000000009f642405cd3dbdd1--