From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2C6DA0547; Wed, 27 Oct 2021 03:51:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7BC5140DDA; Wed, 27 Oct 2021 03:51:51 +0200 (CEST) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 3BE82407FF for ; Wed, 27 Oct 2021 03:51:50 +0200 (CEST) Received: by mail-io1-f48.google.com with SMTP id d63so1751277iof.4 for ; Tue, 26 Oct 2021 18:51:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WaNivmc63lMw36ogpKPoXgJrLpjuweu8bKPMf+dm7d0=; b=QDqPVSEDvoyxgcIxJ70NeCrs7bryqeGp66nuqG42cCmARMAz4cC+YI2PckYjJoyDQn cYyq9v+S4r7wT3oW78070Gq6jn7paMpKavpZ/3Lu+f8ySQDyP3+0Dz95dr3Y3G5wESm1 BV8pI5yrINv5E4eNpcUPiBiV19oDTnFpb4aT0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WaNivmc63lMw36ogpKPoXgJrLpjuweu8bKPMf+dm7d0=; b=Kk5IFFgCSxULZ4P/2ycYAArryppFZ3FxSofZNMHsgpBKeS0VVzh0vo7ycc9l3JwvSW 10vTZ0fDXVVZon/Mjs1Na568zXeoYCQ2a189HEXdPZEah4VSl8Uo3FwKJtRWTBooaJCS g3n4wRhQ+M/M/Hro4C5AsZBLsHWfFEB/wC6euopQ2lI7sjtevkxAHKX37p/11q/TzV0A y1EeYM/7+VdYGGfgsUD8TBUW4kSL4ceQjZ+HQNz0zdxXPX1Pc8GMwq1YW2w/YuRn5Zkp egHDJfKRuvIwa76rHMQFC0El3ZBDx9xewj1iOKIY9OHGhjAu2QoFzjlYtxPdxPHLXjiS oZwA== X-Gm-Message-State: AOAM530LDYXI3U/j7K8TOQsPLBk+W2zkCxdcIgEA9R6gapgz7XUzjp+b HSiVD3sPDNGoLdCtauESWtZVUWuPBbUoXwZpELCHagA4/LegXA== X-Google-Smtp-Source: ABdhPJwozqRrty/wTnOfkJDaSFdkH9DJoBsiwSfaH5Dr1QxnonGz0a2mJYdzYjcedzdFsq3t4/s2GpsHjl1iHVLMiRI= X-Received: by 2002:a02:cb0f:: with SMTP id j15mr11983077jap.60.1635299509440; Tue, 26 Oct 2021 18:51:49 -0700 (PDT) MIME-Version: 1.0 References: <20211026051432.83989-1-ajit.khaparde@broadcom.com> In-Reply-To: <20211026051432.83989-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Tue, 26 Oct 2021 18:51:33 -0700 Message-ID: To: dpdk-dev Cc: Kalesh AP , Somnath Kotur Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix RSS action parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 25, 2021 at 10:14 PM Ajit Khaparde wrote: > > Minor fixes are needed in the RTE_FLOW RSS action parser. > 1. Update the comment in the parser to indicate rss level 1 implies > RSS on outer header. > 2. RSS action will not be supported if level is > 1. > 3. RSS action will not be supported if user or application specifies > MARK or COUNT action. > 4. If RSS types is not specified i.e., is 0, the best effort RSS should > use IPV4 and IPV6 headers. Currently we are considering only IPV4. > > Fixes: fe0bab7eb34e ("net/bnxt: enhance support for RSS action") > > Signed-off-by: Ajit Khaparde > Acked-by: Kalesh AP > Acked-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_flow.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index ced697a739..9526a8fc5a 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -1084,10 +1084,6 @@ bnxt_validate_rss_action(const struct rte_flow_action actions[]) > break; > case RTE_FLOW_ACTION_TYPE_RSS: > break; > - case RTE_FLOW_ACTION_TYPE_MARK: > - break; > - case RTE_FLOW_ACTION_TYPE_COUNT: > - break; > default: > return -ENOTSUP; > } > @@ -1151,11 +1147,10 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, > } > > /* Currently RSS hash on inner and outer headers are supported. > - * 0 => Default setting > - * 1 => Inner > - * 2 => Outer > + * 0 => Default (innermost RSS) setting > + * 1 => Outermost > */ > - if (rss->level > 2) { > + if (rss->level > 1) { > rte_flow_error_set(error, > ENOTSUP, > RTE_FLOW_ERROR_TYPE_ACTION, > @@ -1177,7 +1172,7 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, > } > > /* If RSS types is 0, use a best effort configuration */ > - types = rss->types ? rss->types : RTE_ETH_RSS_IPV4; > + types = rss->types ? rss->types : ETH_RSS_IPV4 | ETH_RSS_IPV6; > > hash_type = bnxt_rte_to_hwrm_hash_types(types); > > -- > 2.30.1 (Apple Git-130) >